From: Jean Delvare <jdelvare@suse.de>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Phil Reid <preid@electromag.com.au>,
kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, wsa@the-dreams.de, robh+dt@kernel.org,
mark.rutland@arm.com, sre@kernel.org, jglauber@cavium.com,
david.daney@cavium.com, peda@axentia.se,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v8 3/9] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter
Date: Sat, 22 Jul 2017 13:49:45 +0200 [thread overview]
Message-ID: <20170722134945.6db60b24@endymion> (raw)
In-Reply-To: <20170721164533.54855e1d@endymion>
On Fri, 21 Jul 2017 16:45:33 +0200, Jean Delvare wrote:
> On Fri, 21 Jul 2017 11:37:59 +0200, Benjamin Tissoires wrote:
> > What if I2C selects I2C_SMBUS directly?
>
> Selecting I2C_SMBUS is what device drivers are indeed supposed to do.
> However doing it from i2c-core seems awkward, because i2c-smbus itself
> depends on i2c-core. If they end up both built in, I guess it will be
> fine. But if they are modular, I'm afraid you won't be able to load the
> modules, because each of them requires the other to be loaded first for
> proper symbol resolution.
Out of curiosity I gave it a try and I can confirm it fails as I
expected.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-07-22 11:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 8:19 [PATCH v8 0/9] Add sbs-manager with smbalert support Phil Reid
2017-07-18 8:19 ` [PATCH v8 1/9] i2c: i2c-smbus: Use threaded irq for smbalert Phil Reid
[not found] ` <1500365984-61404-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-07-18 8:19 ` [PATCH v8 2/9] i2c: i2c-smbus: add of_i2c_setup_smbus_alert Phil Reid
2017-07-18 8:19 ` [PATCH v8 3/9] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter Phil Reid
2017-07-19 18:30 ` kbuild test robot
[not found] ` <201707200255.SHskJrcM%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-07-20 4:44 ` Phil Reid
2017-07-21 9:37 ` Benjamin Tissoires
2017-07-21 14:45 ` Jean Delvare
2017-07-22 11:49 ` Jean Delvare [this message]
2017-07-21 14:33 ` Jean Delvare
2017-07-24 8:27 ` Phil Reid
[not found] ` <1500365984-61404-4-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-07-19 20:55 ` kbuild test robot
2017-07-18 8:19 ` [PATCH v8 7/9] power: Adds support for Smart Battery System Manager Phil Reid
2017-07-18 8:19 ` [PATCH v8 4/9] i2c: mux: pca954x: Call request irq after adding mux segments Phil Reid
2017-07-18 8:19 ` [PATCH v8 5/9] i2c: mux: pca954x: Return error if irq_create_mapping fails Phil Reid
2017-07-18 20:41 ` Peter Rosin
2017-07-18 8:19 ` [PATCH v8 6/9] Documentation: Add sbs-manager device tree node documentation Phil Reid
2017-07-18 8:19 ` [PATCH v8 8/9] power: supply: sbs-manager: Add alert callback and battery change notification Phil Reid
2017-07-18 8:19 ` [PATCH v8 9/9] power: supply: sbs-battery: move gpio present detect to sbs_get_property Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170722134945.6db60b24@endymion \
--to=jdelvare@suse.de \
--cc=benjamin.tissoires@redhat.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=jglauber@cavium.com \
--cc=kbuild-all@01.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).