From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH v8 3/9] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter Date: Sat, 22 Jul 2017 13:49:45 +0200 Message-ID: <20170722134945.6db60b24@endymion> References: <201707200255.SHskJrcM%fengguang.wu@intel.com> <20170721093759.GD11387@mail.corp.redhat.com> <20170721164533.54855e1d@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170721164533.54855e1d@endymion> Sender: linux-pm-owner@vger.kernel.org To: Benjamin Tissoires Cc: Phil Reid , kbuild test robot , kbuild-all@01.org, wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, sre@kernel.org, jglauber@cavium.com, david.daney@cavium.com, peda@axentia.se, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, 21 Jul 2017 16:45:33 +0200, Jean Delvare wrote: > On Fri, 21 Jul 2017 11:37:59 +0200, Benjamin Tissoires wrote: > > What if I2C selects I2C_SMBUS directly? > > Selecting I2C_SMBUS is what device drivers are indeed supposed to do. > However doing it from i2c-core seems awkward, because i2c-smbus itself > depends on i2c-core. If they end up both built in, I guess it will be > fine. But if they are modular, I'm afraid you won't be able to load the > modules, because each of them requires the other to be loaded first for > proper symbol resolution. Out of curiosity I gave it a try and I can confirm it fails as I expected. -- Jean Delvare SUSE L3 Support