Re: [PATCH 1/2] fdt: Allow stacked overlays phandle references

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

On Thu, Jul 13, 2017 at 12:40:24PM -0700, Frank Rowand wrote:
> On 07/07/17 00:09, David Gibson wrote:
> > On Mon, Jul 03, 2017 at 03:41:14PM +0300, Pantelis Antoniou wrote:
> >> Hi David,
> >>
> >> On Mon, 2017-07-03 at 19:06 +1000, David Gibson wrote:
> >>> On Wed, Jun 14, 2017 at 05:52:25PM +0300, Pantelis Antoniou wrote:
> >>>> This patch enables an overlay to refer to a previous overlay's
> >>>> labels by performing a merge of symbol information at application
> >>>> time.
> >>>
> >>> This seems to be doing things the hard way.
> >>>
> >>
> >> It is the minimal implementation to get things to work, with the current
> >> overlay implementation.
> > 
> > Is it, though?  I'd expect reworking the symbol creation during
> > compile to be of similar complexity to the symbol merging here.  And
> > it only needs to be done in one place, not two.  And it doesn't
> > implicitly extend the overlay spec.
> > 
> >> I do have plans for a version 2 with fixes to
> >> a number of areas.
> > 
> > Saying you'll fix it in v2 is missing the point.  If v1 is out there,
> > we have to keep supporting it.  The number of half-arsed overlay
> > variants out in the wild just seems to keep growing.
> > 
> >>> You're essentially extending the semantics of overlay application to
> >>> add the symbol merging.  You've implemented these extended semantics
> >>> in libfdt, which is all very well, but that's not the only overlay
> >>> application implementation.
> >>
> >> This is a port of the same patch that's against the linux kernel.
> >> As far as I know there's no other implementations, or at least none
> >> that are open source.
> > 
> > So, it's already in the wild and we have to deal with it.  Yay.
> 
> It was only a proposed patch.  It is not in the kernel.  We don't
> have to deal with it.

Ah, I misread.  Well, that's something.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]