From: Jiri Pirko <jiri@resnulli.us>
To: Pavel Machek <pavel@ucw.cz>
Cc: Vadim Pasternak <vadimp@mellanox.com>,
lee.jones@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, j.anaszewski@samsung.com,
rpurdie@rpsys.net, linux-leds@vger.kernel.org
Subject: Re: [patch v1 1/2] mfd: Add Mellanox regmap core driver
Date: Wed, 26 Jul 2017 13:28:20 +0200 [thread overview]
Message-ID: <20170726112820.GB1845@nanopsycho> (raw)
In-Reply-To: <20170726111846.GB6033@amd>
Wed, Jul 26, 2017 at 01:18:46PM CEST, pavel@ucw.cz wrote:
>Hi!
>
[...]
>
>> +static void
>> +mlxreg_core_work_helper(struct mlxreg_core_priv_data *priv,
>> + struct mlxreg_core_item *item, u8 is_inverse,
>> + u16 off, u32 mask, u32 *cache)
>> +{
>> + struct mlxreg_core_data *data;
>> + u32 asserted, regval, bit;
>> + int ret;
>> +
>> + /*
>> + * Validate if item related to received signal type is valid.
>> + * It should never happen, excepted the situation when some
>> + * piece of hardware is broken. In such situation just produce
>> + * error message and return. Caller must continue to handle the
>> + * signals from other devices if any.
>> + */
>> + if (unlikely(!item)) {
>> + dev_err(priv->dev, "False signal is received: register at offset 0x%02x, mask 0x%02x.\n",
>> + off, mask);
>
>Slightly too long line.
That is totally ok to have it like that for printables though. Actually,
wraping the text in half would be wrong.
next prev parent reply other threads:[~2017-07-26 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 16:51 [patch v1 0/2] Introduce support for mlxreg mfd core and I2C drivers Vadim Pasternak
2017-07-25 16:51 ` [patch v1 1/2] mfd: Add Mellanox regmap core driver Vadim Pasternak
[not found] ` <1501001499-21971-2-git-send-email-vadimp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-07-26 11:18 ` Pavel Machek
2017-07-26 11:28 ` Jiri Pirko [this message]
2017-07-26 11:42 ` Pavel Machek
2017-07-26 17:18 ` Vadim Pasternak
[not found] ` <AM4PR05MB3330F7C7913391C906CB2069A2B90-n5Jp0YuYvM1LPiJj6BpYmdqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-07-26 18:25 ` Pavel Machek
2017-07-25 16:51 ` [patch v1 2/2] mfd: Add Mellanox regmap I2C driver Vadim Pasternak
[not found] ` <1501001499-21971-3-git-send-email-vadimp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-07-26 11:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726112820.GB1845@nanopsycho \
--to=jiri@resnulli.us \
--cc=devicetree@vger.kernel.org \
--cc=j.anaszewski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox