From: Will Deacon <will.deacon@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
luc.vanoostenryck@gmail.com, dan.carpenter@oracle.com
Subject: Re: [PATCH] arm64: Convert to using %pOF instead of full_name
Date: Wed, 26 Jul 2017 13:02:33 +0100 [thread overview]
Message-ID: <20170726120233.GC2115@arm.com> (raw)
In-Reply-To: <CAL_JsqJFD4y3MXFApApj59brOyagysGjmrPFBGx96gf-ZjCdSA@mail.gmail.com>
Hi Rob,
On Tue, Jul 25, 2017 at 07:27:29PM -0500, Rob Herring wrote:
> On Tue, Jul 25, 2017 at 7:04 AM, Will Deacon <will.deacon@arm.com> wrote:
> > On Tue, Jul 18, 2017 at 04:42:42PM -0500, Rob Herring wrote:
> >> Now that we have a custom printf format specifier, convert users of
> >> full_name to use %pOF instead. This is preparation to remove storing
> >> of the full path string for each node.
> >>
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> Cc: Catalin Marinas <catalin.marinas@arm.com>
> >> Cc: Will Deacon <will.deacon@arm.com>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> ---
> >> arch/arm64/kernel/cpu_ops.c | 4 ++--
> >> arch/arm64/kernel/smp.c | 12 ++++++------
> >> arch/arm64/kernel/topology.c | 22 +++++++++++-----------
> >> 3 files changed, 19 insertions(+), 19 deletions(-)
> >
> > I've queued this and the perf patch too, but it would be good if somebody
> > could update sparse to recognise this format specifier. Currently it
> > just complains about it.
>
> I'm happy to fix it, but I ran sparse and don't see any errors. Got a pointer?
I went back and checked again and it's not sparse that's warning, it's
actually smatch (sorry for getting that mixed up):
arch/arm64/kernel/cpu_ops.c:85 cpu_read_enable_method() error: unrecognized %p extension 'O', treated as normal %p [smatch]
Will
next prev parent reply other threads:[~2017-07-26 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:42 [PATCH] arm64: Convert to using %pOF instead of full_name Rob Herring
2017-07-25 12:04 ` Will Deacon
[not found] ` <20170725120422.GD27768-5wv7dgnIgG8@public.gmane.org>
2017-07-26 0:27 ` Rob Herring
2017-07-26 12:02 ` Will Deacon [this message]
2017-07-26 12:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726120233.GC2115@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).