From: Shawn Guo <shawnguo@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Baoyou Xie <xie.baoyou@sanechips.com.cn>,
Xin Zhou <zhou.xin8@sanechips.com.cn>,
Jun Nie <jun.nie@linaro.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 2/2] pwm: add ZTE ZX PWM device driver
Date: Thu, 27 Jul 2017 16:26:51 +0800 [thread overview]
Message-ID: <20170727082649.GJ29754@dragon> (raw)
In-Reply-To: <20170725115343.GD22355@ulmo>
On Tue, Jul 25, 2017 at 01:53:43PM +0200, Thierry Reding wrote:
> On Thu, Jun 29, 2017 at 10:54:34AM +0800, Shawn Guo wrote:
> > From: Shawn Guo <shawn.guo@linaro.org>
> >
> > It adds PWM device driver for ZTE ZX family SoCs. The PWM controller
> > supports 4 devices with polarity configuration.
> >
> > The driver has been tested with pwm-regulator support to scale core
> > voltage via cpufreq.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > drivers/pwm/Kconfig | 9 ++
> > drivers/pwm/Makefile | 1 +
> > drivers/pwm/pwm-zx.c | 244 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 254 insertions(+)
> > create mode 100644 drivers/pwm/pwm-zx.c
>
> Hi Shawn,
>
> This is close to perfect. Two minor things, see below.
Hi Thierry,
Thanks for helping review the patch. I just send out v2 to address
your comments.
Shawn
prev parent reply other threads:[~2017-07-27 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 2:54 [PATCH 0/2] Add ZTE ZX PWM device driver support Shawn Guo
2017-06-29 2:54 ` [PATCH 1/2] dt-bindings: pwm: add bindings doc for ZTE ZX PWM controller Shawn Guo
[not found] ` <1498704874-14599-2-git-send-email-shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-06 14:57 ` Rob Herring
[not found] ` <1498704874-14599-1-git-send-email-shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-29 2:54 ` [PATCH 2/2] pwm: add ZTE ZX PWM device driver Shawn Guo
2017-07-25 11:53 ` Thierry Reding
2017-07-27 8:26 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727082649.GJ29754@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=xie.baoyou@sanechips.com.cn \
--cc=zhou.xin8@sanechips.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).