From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Rob Herring <robh@kernel.org>
Cc: Milo Kim <Milo.Kim@ti.com>, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Jingoo Han <jingoohan1@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight binding
Date: Thu, 27 Jul 2017 12:29:04 +0200 [thread overview]
Message-ID: <20170727102904.4l6atdtjsas2lhri@earth> (raw)
In-Reply-To: <20170724165826.3jcnrsirfqzefldj@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
Hi,
On Mon, Jul 24, 2017 at 11:58:26AM -0500, Rob Herring wrote:
> On Mon, Jul 17, 2017 at 03:39:55PM +0200, Sebastian Reichel wrote:
> > +Required property:
> > + - compatible: Should be one of:
> > + "ti,lm3532-backlight"
> > + "ti,lm3631-backlight"
> > + "ti,lm3632-backlight"
> > + "ti,lm3633-backlight"
> > + "ti,lm3695-backlight"
> > + "ti,lm3697-backlight"
>
> Some of the parts only do backlight, so drop the "-backlight" on those.
> And having a sub-node makes no sense in that case. Perhaps it should be
> 2 binding documents separating the single function devices and MFDs. The
> binding doc(s) doesn't have to align with the driver(s). You can have 1
> driver serve 2 bindings.
Yes, there is LM3532 and LM3695, which is backlight only as far as I
can see. Your suggestion contradicts with existing binding, though:
Documentation/devicetree/bindings/mfd/ti-lmu.txt
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-27 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 13:39 [PATCHv2 0/2] backlight: Add TI LMU backlight driver Sebastian Reichel
2017-07-17 13:39 ` [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight binding Sebastian Reichel
2017-07-24 16:58 ` Rob Herring
2017-07-27 10:29 ` Sebastian Reichel [this message]
2017-07-17 13:39 ` [PATCHv2 2/2] backlight: add TI LMU backlight driver Sebastian Reichel
2017-09-07 11:22 ` Daniel Thompson
2017-07-27 12:03 ` [PATCHv2 0/2] backlight: Add " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727102904.4l6atdtjsas2lhri@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=Milo.Kim@ti.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).