devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
	alexandre.torgue-qxv4g6HH51o@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	icenowy-h8G6r0blFSE@public.gmane.org
Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
Date: Fri, 28 Jul 2017 16:25:08 +0200	[thread overview]
Message-ID: <20170728142508.GA7221@Red> (raw)
In-Reply-To: <20170728135544.GD32230-g2DYL2Zd6BY@public.gmane.org>

On Fri, Jul 28, 2017 at 03:55:44PM +0200, Andrew Lunn wrote:
> On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
> > Hello
> > 
> > The current way to find if the phy is internal is to compare DT phy-mode
> > and emac_variant/internal_phy.
> > But it will negate a possible future SoC where an external PHY use the
> > same phy mode than the internal one.
> > 
> > This patchs series adds a new way to find if the PHY is internal, via its
> > compatible.
> 
> http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144
> 
> Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
> warning. But still, your device tree gives the wrong idea.
> 
> I've probably asked this before: Does the internal PHY use a different
> PHY ID in registers 2 and 3?
> 

yes

reg2: 0x0044
reg3: 0X1500

Regards

  parent reply	other threads:[~2017-07-28 14:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28  9:28 [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Corentin Labbe
     [not found] ` <20170728092818.23419-1-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-28  9:28   ` [PATCH 1/3] dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs Corentin Labbe
2017-07-28  9:28   ` [PATCH 2/3] ARM: sunxi: h3/h5: Add sun8i-h3-ephy compatible Corentin Labbe
2017-07-28  9:44     ` Chen-Yu Tsai
     [not found]       ` <CAGb2v67Lt5whR4=6+SDc=Ooi6zyiHuprW+7zbPh0njnKOCiFFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-28  9:46         ` Icenowy Zheng
2017-07-28  9:28   ` [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Corentin Labbe
     [not found]     ` <20170728092818.23419-4-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-28  9:49       ` Chen-Yu Tsai
     [not found]         ` <CAGb2v64w-KCmYExN7OqvuLj42-pHN-BN5iKpxA+KW84v+RfCDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-28  9:54           ` Corentin Labbe
2017-07-28  9:53   ` [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Chen-Yu Tsai
     [not found]     ` <CAGb2v66=h_5df=B0Us-kvvFg9r_qSUroDzn-xvQLSpD1d8DhBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-28 13:47       ` Andrew Lunn
2017-07-28 13:55   ` Andrew Lunn
     [not found]     ` <20170728135544.GD32230-g2DYL2Zd6BY@public.gmane.org>
2017-07-28 14:25       ` Corentin Labbe [this message]
2017-07-28 14:36         ` Andrew Lunn
     [not found]           ` <20170728143600.GB2132-g2DYL2Zd6BY@public.gmane.org>
2017-07-28 14:44             ` Corentin Labbe
2017-07-28 14:51               ` Andrew Lunn
2017-07-28 17:54               ` Florian Fainelli
     [not found]                 ` <f8fe754c-8b46-a9f6-4020-f7db6c985773-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-29  6:48                   ` Corentin Labbe
2017-07-31 12:19                     ` Chen-Yu Tsai
     [not found]                       ` <CAGb2v6626KDmww5u_-ogMJHgfdxTHQLCnUF4bmcUt35f2JJgLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-31 12:26                         ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728142508.GA7221@Red \
    --to=clabbe.montjoie-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alexandre.torgue-qxv4g6HH51o@public.gmane.org \
    --cc=andrew-g2DYL2Zd6BY@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=icenowy-h8G6r0blFSE@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peppe.cavallaro-qxv4g6HH51o@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).