From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Date: Fri, 28 Jul 2017 16:51:01 +0200 Message-ID: <20170728145101.GC2132@lunn.ch> References: <20170728092818.23419-1-clabbe.montjoie@gmail.com> <20170728135544.GD32230@lunn.ch> <20170728142508.GA7221@Red> <20170728143600.GB2132@lunn.ch> <20170728144424.GB7221@Red> Reply-To: andrew-g2DYL2Zd6BY@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170728144424.GB7221@Red> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Corentin Labbe Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, peppe.cavallaro-qxv4g6HH51o@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org List-Id: devicetree@vger.kernel.org > It is too late when we know the PHY ID. > We need to set a syscon for choosing external/internal PHY. > So we can rely only on DT. The point is, its not a property of the PHY. It is a syscon or a MAC property. Having it as a MAC property would be more generic. Andrew