From: Vignesh R <vigneshr@ti.com>
To: Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Vignesh R <vigneshr@ti.com>
Subject: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write sequence
Date: Tue, 1 Aug 2017 10:24:28 +0530 [thread overview]
Message-ID: <20170801045434.8733-2-vigneshr@ti.com> (raw)
In-Reply-To: <20170801045434.8733-1-vigneshr@ti.com>
As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access
Controller programming sequence, a delay equal to couple QSPI master
clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and
writing data to the flash. Add a new compatible to handle the couple of
cycles of delay required in the indirect write sequence, since this
delay is specific to TI 66AK2G SoC.
[1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 1 +
drivers/mtd/spi-nor/cadence-quadspi.c | 13 +++++++++++++
2 files changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
index f248056da24c..fdd511a83511 100644
--- a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
@@ -2,6 +2,7 @@
Required properties:
- compatible : Should be "cdns,qspi-nor".
+ Should be "ti,k2g-qspi" for TI 66AK2G platform.
- reg : Contains two entries, each of which is a tuple consisting of a
physical address and length. The first entry is the address and
length of the controller register set. The second entry is the
diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
index 53c7d8e0327a..94571590371d 100644
--- a/drivers/mtd/spi-nor/cadence-quadspi.c
+++ b/drivers/mtd/spi-nor/cadence-quadspi.c
@@ -76,6 +76,7 @@ struct cqspi_st {
u32 fifo_depth;
u32 fifo_width;
u32 trigger_address;
+ u32 wr_delay;
struct cqspi_flash_pdata f_pdata[CQSPI_MAX_CHIPSELECT];
};
@@ -608,6 +609,14 @@ static int cqspi_indirect_write_execute(struct spi_nor *nor,
reinit_completion(&cqspi->transfer_complete);
writel(CQSPI_REG_INDIRECTWR_START_MASK,
reg_base + CQSPI_REG_INDIRECTWR);
+ /*
+ * As per 66AK2G02 TRM SPRUHY8F section 11.15.5.3 Indirect Access
+ * Controller programming sequence, couple of cycles of
+ * QSPI_REF_CLK delay is required for the above bit to
+ * be internally synchronized by the QSPI module. Provide 5
+ * cycles of delay.
+ */
+ ndelay(cqspi->wr_delay);
while (remaining > 0) {
write_bytes = remaining > page_size ? page_size : remaining;
@@ -1213,6 +1222,9 @@ static int cqspi_probe(struct platform_device *pdev)
}
cqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);
+ if (of_device_is_compatible(dev->of_node, "ti,k2g-qspi"))
+ cqspi->wr_delay = 5 * DIV_ROUND_UP(NSEC_PER_SEC,
+ cqspi->master_ref_clk_hz);
ret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,
pdev->name, cqspi);
@@ -1285,6 +1297,7 @@ static const struct dev_pm_ops cqspi__dev_pm_ops = {
static const struct of_device_id cqspi_dt_ids[] = {
{.compatible = "cdns,qspi-nor",},
+ {.compatible = "ti,k2g-qspi",},
{ /* end of table */ }
};
--
2.13.3
next prev parent reply other threads:[~2017-08-01 4:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 4:54 [PATCH 0/7] K2G: Add QSPI support Vignesh R
2017-08-01 4:54 ` Vignesh R [this message]
[not found] ` <20170801045434.8733-2-vigneshr-l0cyMroinI0@public.gmane.org>
2017-08-10 0:05 ` [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write sequence Rob Herring
2017-08-10 5:24 ` Vignesh R
2017-08-10 0:08 ` Rob Herring
2017-08-10 5:28 ` Vignesh R
2017-08-01 4:54 ` [PATCH 2/7] mtd: spi-nor: cadence-quadspi: Add support to enable loopback clock circuit Vignesh R
[not found] ` <20170801045434.8733-3-vigneshr-l0cyMroinI0@public.gmane.org>
2017-08-10 0:10 ` Rob Herring
2017-08-10 5:25 ` Vignesh R
[not found] ` <20170801045434.8733-1-vigneshr-l0cyMroinI0@public.gmane.org>
2017-08-01 4:54 ` [PATCH 3/7] mtd: spi-nor: cadence-quadspi: Add runtime PM support Vignesh R
2017-08-01 4:54 ` [PATCH 5/7] ARM: dts: keystone-k2g-evm: Add QSPI node Vignesh R
2017-08-01 4:54 ` [PATCH 4/7] ARM: dts: keystone-k2g: Add QSPI DT entry Vignesh R
2017-08-01 4:54 ` [PATCH 6/7] ARM: dts: keystone-k2g-ice: Add QSPI node Vignesh R
2017-08-01 4:54 ` [PATCH 7/7] ARM: configs: keystone: Enable Cadence QSPI driver Vignesh R
2017-08-01 18:01 ` [PATCH 0/7] K2G: Add QSPI support Santosh Shilimkar
[not found] ` <29c0e8ec-1f9f-cfc9-2d0e-e4d31890b699-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-08-02 5:52 ` Vignesh R
2017-08-02 17:19 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801045434.8733-2-vigneshr@ti.com \
--to=vigneshr@ti.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).