From: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
To: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org,
johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
stefan.wahren-eS4NqCHxEME@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/3] Bluetooth: hci_bcm: Add serdev support
Date: Tue, 1 Aug 2017 10:51:32 +0200 [thread overview]
Message-ID: <20170801085132.onmq5wubrv2av2pu@earth> (raw)
In-Reply-To: <1501576704-26423-3-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
Hi,
On Tue, Aug 01, 2017 at 10:38:24AM +0200, Loic Poulain wrote:
> [...]
> + err = of_property_read_u32(serdev->dev.of_node, "max-speed", &speed);
> + if (!err)
> + bcmdev->hu.oper_speed = speed;
> [...]
I suggest to use device_property_read_u32() here and include
<linux/property.h> instead of <linux/of.h>. This way the
serdev support is not DT specific.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-01 8:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 8:38 [PATCH v2 1/3] dt-bindings: net: bluetooth: Add broadcom-bluetooth Loic Poulain
[not found] ` <1501576704-26423-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-01 8:38 ` [PATCH v2 2/3] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 as serial slave Loic Poulain
[not found] ` <1501576704-26423-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-04 7:24 ` Marcel Holtmann
2017-08-01 8:38 ` [PATCH v2 3/3] Bluetooth: hci_bcm: Add serdev support Loic Poulain
[not found] ` <1501576704-26423-3-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-01 8:51 ` Sebastian Reichel [this message]
2017-08-04 14:36 ` Marcel Holtmann
[not found] ` <696124D4-A5DA-46FA-A0F0-5DC74363BD23-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-04 19:26 ` Stefan Wahren
[not found] ` <444254163.121186.1501874785594-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-08-04 19:37 ` Marcel Holtmann
[not found] ` <51D602E3-B21A-402B-A1F5-6241D55448E9-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-04 19:44 ` Stefan Wahren
[not found] ` <1498038890.121361.1501875841550-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-08-04 19:45 ` Marcel Holtmann
[not found] ` <BB04C3A8-2BFC-44B7-AA84-E0B81F560B8C-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-04 19:50 ` Stefan Wahren
[not found] ` <653244764.121525.1501876203800-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-08-04 20:58 ` Marcel Holtmann
[not found] ` <A997C486-989A-4040-9871-773A858D8410-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-07 22:17 ` Eric Anholt
[not found] ` <87o9rr10qy.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-08-08 4:47 ` Marcel Holtmann
2017-08-22 7:47 ` [PATCH v2 1/3] dt-bindings: net: bluetooth: Add broadcom-bluetooth Maxime Ripard
[not found] ` <20170822074726.e424lflqxn6mb4xd-ZC1Zs529Oq4@public.gmane.org>
2017-08-22 11:01 ` Stefan Wahren
[not found] ` <f2fcf522-cd1e-e748-0ee7-ad28bbf8ae5d-eS4NqCHxEME@public.gmane.org>
2017-08-22 20:27 ` Loic Poulain
[not found] ` <4c23bcb6-1b90-c41e-6e47-7d8315e760ae-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-23 14:12 ` Maxime Ripard
2017-08-23 14:19 ` Marcel Holtmann
[not found] ` <9BD5C644-6B89-496C-B442-F276D7A99102-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-27 9:54 ` Stefan Wahren
[not found] ` <123116901.43777.1503827664160-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-08-27 10:23 ` Marcel Holtmann
[not found] ` <CF7BCF4E-A2BE-4D5D-9F3D-0490E75A0677-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-27 10:40 ` Stefan Wahren
2017-08-31 19:32 ` Frédéric Danis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801085132.onmq5wubrv2av2pu@earth \
--to=sebastian.reichel-zgy8ohtn/8ppycu2f3hruq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox