From: Andrew Jeffery <andrew@aj.id.au>
To: linux@roeck-us.net, linux-hwmon@vger.kernel.org
Cc: Andrew Jeffery <andrew@aj.id.au>,
robh+dt@kernel.org, mark.rutland@arm.com, jdelvare@suse.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
joel@jms.id.au, mspinler@linux.vnet.ibm.com,
msbarth@linux.vnet.ibm.com, openbmc@lists.ozlabs.org
Subject: [PATCH v2 0/4] pmbus: Expand fan support and add MAX31785 driver
Date: Wed, 2 Aug 2017 16:45:37 +0930 [thread overview]
Message-ID: <20170802071541.3121-1-andrew@aj.id.au> (raw)
Hello,
v1[1] spent some time in the OpenBMC kernel tree and it shook out a few issues:
1. The machines I was testing against had pre-prammed the installed-bit in
FAN_CONFIG_1_2
2. There appears to be a hardware issue with some back-to-back writes to the
MAX31785
Point 1. is a policy issue so we should have the ability to specify behaviour
in the devicetree. As such the bindings documentation has been updated to suit.
Point 2, well, it's a little ugly. We're in contact with Maxim to better
understand the nature of the issue. Patch 4 introduces a work-around. I've kept
this separate from the introduction of the driver so it's implementation and
the demonstration of new pmbus core features isn't obscured. The work-around
has proved reliable so-far, across a number of machines.
[1] https://lkml.org/lkml/2017/7/27/116
Changes from v1 to v2:
* Add the use-stored-presence devicetree property describing the hardware as
canonical in terms of fan presence.
* Small optimsation in pmbus_update_fans(): Don't write FAN_CONFIG_x_y unless
the new value is different to the current value
* Update the MAX31785 driver to consume use-stored-presence from the devicetree
* Add the back-to-back write work-around
Changes between RFC v2 to (non-RFC) v1
* Clean up issues identified in comments on the pmbus core changes
* Define and implement bindings for the MAX31785
* Clean up issues identified in comments on the max31785 driver
Andrew Jeffery (4):
dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation
hwmon: pmbus: Add fan control support
pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller
pmbus: max31785: Work around back-to-back writes with FAN_CONFIG_1_2
.../devicetree/bindings/hwmon/pmbus/max31785.txt | 126 ++++
drivers/hwmon/pmbus/Kconfig | 10 +
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/max31785.c | 762 +++++++++++++++++++++
drivers/hwmon/pmbus/pmbus.h | 29 +
drivers/hwmon/pmbus/pmbus_core.c | 224 +++++-
6 files changed, 1137 insertions(+), 15 deletions(-)
create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt
create mode 100644 drivers/hwmon/pmbus/max31785.c
--
2.11.0
next reply other threads:[~2017-08-02 7:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 7:15 Andrew Jeffery [this message]
2017-08-02 7:15 ` [PATCH v2 1/4] dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation Andrew Jeffery
2017-08-10 16:13 ` Rob Herring
2017-08-14 1:55 ` Andrew Jeffery
[not found] ` <1502675753.14932.3.camel-zrmu5oMJ5Fs@public.gmane.org>
2017-09-08 3:58 ` Andrew Jeffery
2017-08-02 7:15 ` [PATCH v2 2/4] hwmon: pmbus: Add fan control support Andrew Jeffery
2017-08-02 7:15 ` [PATCH v2 3/4] pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller Andrew Jeffery
2017-08-02 7:15 ` [PATCH v2 4/4] pmbus: max31785: Work around back-to-back writes with FAN_CONFIG_1_2 Andrew Jeffery
[not found] ` <20170802071541.3121-5-andrew-zrmu5oMJ5Fs@public.gmane.org>
2017-08-29 1:08 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802071541.3121-1-andrew@aj.id.au \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=msbarth@linux.vnet.ibm.com \
--cc=mspinler@linux.vnet.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).