From: Pavel Machek <pavel@ucw.cz>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: linux-leds@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v2 0/4] leds: pca955x: add GPIO support
Date: Wed, 2 Aug 2017 14:48:44 +0200 [thread overview]
Message-ID: <20170802124844.GA3123@amd> (raw)
In-Reply-To: <dad22552-3314-c315-a3c5-89e6718230b0@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
On Wed 2017-08-02 13:57:29, Cédric Le Goater wrote:
> On 08/02/2017 01:33 PM, Pavel Machek wrote:
> > Hi!
> >
> >> The PCA955x family of chips are I2C LED blinkers whose pins not used
> >> to control LEDs can be used as general purpose I/Os (GPIOs).
> >>
> >> The following adds support for device tree and Open Firmware to be
> >> able do define different operation modes for each pin. See bindings
> >> documentation for more details. The pca955x driver is then extended
> >> with a gpio_chip when pins are operating in GPIO mode.
> >>
> >> The driver follows the scheme of the leds-pca9532 driver which behaves
> >> quite similarly.
> >
> > Is there reason not to treat pca955x chip as a GPIO extender, and then
> > use leds-gpio on top?
>
> I would say mostly because there is already a leds-pca955x driver and
> that the primary nature of the chip is being a LED blinker. It also
> supports different blinking rates.
Ok, I guess gpio-led driver can not to blinking, so this makes sense.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-08-02 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 12:09 [PATCH v2 0/4] leds: pca955x: add GPIO support Cédric Le Goater
2017-08-01 12:09 ` [PATCH v2 1/4] leds: pca955x: add device tree support Cédric Le Goater
[not found] ` <1501589349-5681-2-git-send-email-clg-Bxea+6Xhats@public.gmane.org>
2017-08-06 21:42 ` Jacek Anaszewski
2017-08-07 9:03 ` Cédric Le Goater
[not found] ` <1501589349-5681-1-git-send-email-clg-Bxea+6Xhats@public.gmane.org>
2017-08-01 12:09 ` [PATCH v2 2/4] leds: pca955x: use devm_led_classdev_register Cédric Le Goater
2017-08-01 12:09 ` [PATCH v2 3/4] leds: pca955x: add GPIO support Cédric Le Goater
2017-08-06 21:42 ` Jacek Anaszewski
2017-08-07 9:09 ` Cédric Le Goater
2017-08-07 16:45 ` Jacek Anaszewski
2017-08-01 12:09 ` [PATCH v2 4/4] dt-bindings leds: add pca955x Cédric Le Goater
2017-08-02 11:33 ` [PATCH v2 0/4] leds: pca955x: add GPIO support Pavel Machek
2017-08-02 11:57 ` Cédric Le Goater
2017-08-02 12:48 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802124844.GA3123@amd \
--to=pavel@ucw.cz \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).