Re: [RESEND PATCH v4 1/2] dt-bindings: i2c: Add Spreadtrum I2C controller documentation

Baolin Wang
2017-08-03T08:45:47Z

On 3 August 2017 at 16:26, Peter Rosin <peda@axentia.se> wrote:
> On 2017-08-03 09:29, Baolin Wang wrote:
>> Hi Wolfram,
>>
>> On 27 July 2017 at 17:29, Baolin Wang <baolin.wang@linaro.org> wrote:
>>> Hi Wolfram,
>>>
>>> On 24 July 2017 at 14:51, Baolin Wang <baolin.wang@spreadtrum.com> wrote:
>>>> Hi Wolfram,
>>>>
>>>> On 五, 7月 14, 2017 at 05:01:10下午 +0800, Baolin Wang wrote:
>>>>> This patch adds the binding documentation for Spreadtrum I2C
>>>>> controller device.
>>>>>
>>>>> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>>> ---
>>>>> Changes since v3:
>>>>> - Add Ack from RobH.
>>>>>
>>>>> Changes since v2:
>>>>> - Change compatible strings to be SoC specific.
>>>>>
>>>>> Changes since v1:
>>>>> - No updates.
>>>>> ---
>>>>
>>>> Could you apply this patchset if there are no other comments?
>>>> It is a long time since the v4 was send out. Thanks.
>>>
>>> Ping?
>>
>> Since this patchset has waited for a long time, could you pick up this
>> patchset into your branch? Thanks.
>
> Please calm down. You first sent v4 4 weeks ago in the beginning of the
> merge window when everybody are supposedly looking at the integration of
> the work from the previous cycle. You have managed to send remainders
> four times in those few weeks.
>
> Four weeks is not a "long time", and it's not like you didn't get any
> feedback. Part of that feedback was that there was room for improvement.
> Have you looked into that? Or have you been busy sending pings? I'm sure
> Wolfram will pick the series in time for the next merge window if he's
> happy with it, there was that thing about room for improvement...

Sorry for noise. I just afraid Wolfram missed this patchset since I
did not get any comments from V4.

Yes, I've looked at how to improve, one thing is we can change
readb/writeb to readsb/writesb. I will submit one patch to fix this
after Andy's patches which fixing the readsb/writesb issue on x86
platform were merged. Anyway I will be keep patient and wait for
comments. Thanks.

--
Baolin.wang
Best Regards