From: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
To: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc
Date: Thu, 3 Aug 2017 18:29:48 +0200 [thread overview]
Message-ID: <20170803162948.GA28042@botnar.kaiser.cx> (raw)
In-Reply-To: <20170803022007.GI31819@dragon>
Hi Shawn,
Thus wrote Shawn Guo (shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org):
> On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > the addresses used by tscadc and those in its child nodes (adc, tsc).
> > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > drivers will then fail since there's no IORESOURCE_MEM.
> > Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
> Do we need the following Fixes tag?
> Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")
yes, looks like this has never worked correctly.
If you're ok with the fix, I can add the tag in v2.
> @Markus, we didn't the changes when we were submitting?
Both Markus' and Denis' mail addresses bounced...
Best regards,
Martin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-03 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 20:06 [PATCH] ARM: dts: i.MX25: add ranges to tscadc Martin Kaiser
[not found] ` <1501704371-28151-1-git-send-email-martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
2017-08-03 2:20 ` Shawn Guo
2017-08-03 16:29 ` Martin Kaiser [this message]
[not found] ` <20170803162948.GA28042-MFl+cUZDu4MqwiiWPijwwA@public.gmane.org>
2017-08-05 5:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803162948.GA28042@botnar.kaiser.cx \
--to=martin-xxzfdwe/svgezlla646fqq@public.gmane.org \
--cc=denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).