From: Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
To: David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] scripts/dtc: fix '%zx' warning
Date: Tue, 8 Aug 2017 12:28:19 +0100 [thread overview]
Message-ID: <20170808112818.GC20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170726013004.GJ8978-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
On Wed, Jul 26, 2017 at 11:30:04AM +1000, David Gibson wrote:
> On Tue, Jul 25, 2017 at 05:20:09PM +0100, Russell King wrote:
> > dtc uses an incorrect format specifier for printing a uint64_t value.
> > uint64_t may be either 'unsigned long' or 'unsigned long long' depending
> > on the host architecture.
> >
> > Fix this by using %llx and casting to unsigned long long, which ensures
> > that we always have a wide enough variable to print 64 bits of hex.
> >
> > HOSTCC scripts/dtc/checks.o
> > scripts/dtc/checks.c: In function 'check_simple_bus_reg':
> > scripts/dtc/checks.c:876:2: warning: format '%zx' expects argument of type 'size_t', but argument 4 has type 'uint64_t' [-Wformat=]
> > snprintf(unit_addr, sizeof(unit_addr), "%zx", reg);
> > ^
> > scripts/dtc/checks.c:876:2: warning: format '%zx' expects argument of type 'size_t', but argument 4 has type 'uint64_t' [-Wformat=]
> >
> > Fixes: 828d4cdd012c ("dtc: check.c fix compile error")
> > Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
>
> This (embarrassing) error is already fixed in upstream dtc.
It remains unfixed in 4.13-rc4. How do we get this fixed in the
kernel's dtc? From what I can see, sending a patch to fix stuff
doesn't work.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-08 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 16:20 [PATCH] scripts/dtc: fix '%zx' warning Russell King
[not found] ` <E1da2Z7-0008GG-AV-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2017-07-26 1:30 ` David Gibson
[not found] ` <20170726013004.GJ8978-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-08-08 11:28 ` Russell King - ARM Linux [this message]
[not found] ` <20170808112818.GC20805-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-08-09 4:06 ` David Gibson
[not found] ` <20170809040642.GG13670-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-08-31 15:58 ` Rob Herring
[not found] ` <CAL_JsqKiM_T-ftd8NvHmzcRsirRWTe34jZRjZ=3NGSgb4HGncQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-31 16:16 ` Russell King - ARM Linux
[not found] ` <20170831161611.GT20805-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-08-31 17:01 ` Rob Herring
[not found] ` <CAL_Jsq+1gMR2MCEXA6UOiK+4NpxT4k71YGqWzW7hZNCWnRg0hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-01 14:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808112818.GC20805@n2100.armlinux.org.uk \
--to=linux-i+ivw8tiwo2tmtq+vha3yw@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).