From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [patch v2 1/2] mfd: Add Mellanox regmap core driver Date: Tue, 8 Aug 2017 12:31:04 +0100 Message-ID: <20170808113104.kb6kcos22stmdkqm@dell> References: <1501108094-16898-1-git-send-email-vadimp@mellanox.com> <1501108094-16898-2-git-send-email-vadimp@mellanox.com> <20170807155836.uqa2nezqqheg6so6@dell> <20170808070211.ikxbzkygymlolavv@dell> <20170808074523.GA12854@amd> <20170808081711.GE12854@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org To: Vadim Pasternak Cc: Pavel Machek , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "j.anaszewski@samsung.com" , "rpurdie@rpsys.net" , "linux-leds@vger.kernel.org" , "jiri@resnulli.us" , "jacek.anaszewski@gmail.com" List-Id: devicetree@vger.kernel.org On Tue, 08 Aug 2017, Vadim Pasternak wrote: > > > > -----Original Message----- > > From: Pavel Machek [mailto:pavel@ucw.cz] > > Sent: Tuesday, August 08, 2017 11:17 AM > > To: Vadim Pasternak > > Cc: Lee Jones ; robh+dt@kernel.org; > > devicetree@vger.kernel.org; j.anaszewski@samsung.com; > > rpurdie@rpsys.net; linux-leds@vger.kernel.org; jiri@resnulli.us; > > jacek.anaszewski@gmail.com > > Subject: Re: [patch v2 1/2] mfd: Add Mellanox regmap core driver > > > > Hi! > > > > > > > And such code can't be placed under drivers/platform/x86/. > > > > > > > > So aim for drivers/platform/mlx ...? > > > > > > > > > > So you suggest to move drivers/platform/x86/mlxcpld-hotplug.c to > > > drivers/platform/mellanox/mlxcpld-hotplug.c and extend thr driver with > > > DTS support (mlxreg_core_dev_enable/mlxreg_core_dev_disable)? > > > > If this leads to less code duplication -- yes, by all means do that. > > OK. > So, I will remove from mlxreg-core IC related part and send the patches for your > review. > In parallel I'll start to work with platform maintainers for moving mlxcpld-hotplug > and further extension for DTS support. After this is ready, I'll extend mlxreg-core > with IC activation. > > Is sounds OK with you? This sounds very reasonable to me, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog