devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Chris Paterson <chris.paterson2@renesas.com>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH  0/3] Add SMP support
Date: Wed, 9 Aug 2017 10:35:54 +0200	[thread overview]
Message-ID: <20170809083554.GI2705@verge.net.au> (raw)
In-Reply-To: <1502189793-59679-1-git-send-email-biju.das@bp.renesas.com>

On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote:
> This series aims to add SMP support for r8a7743 SoC.
> 
> This series has been tested against Linux-next tag 20170727
> and renesas-dev branch.

It seems that these patches are targeted at the renesas tree.
The best practice in that case is to base patches on the latest
devel branch. Please consider doing so in future.

The patches themselves seem good to me, however, I would like to enquire
about testing. In particular, have you tested CPU hotplug and suspend to
RAM with these patches (and without in the case of the latter)?

I am cautious about any regressions that may creep in
when going from UP to SMP.

> 
> Biju Das (3):
>   dt-bindings: apmu: Document r8a7743 support
>   ARM: dts: r8a7743: Add APMU node and second CPU core
>   ARM: dts: r8a7743: Add OPP table for frequency scaling
> 
>  .../devicetree/bindings/power/renesas,apmu.txt     |  3 ++-
>  arch/arm/boot/dts/r8a7743.dtsi                     | 25 ++++++++++++++++++++++
>  2 files changed, 27 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2017-08-09  8:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 10:56 [PATCH 0/3] Add SMP support Biju Das
2017-08-08 10:56 ` [PATCH 1/3] dt-bindings: apmu: Document r8a7743 support Biju Das
     [not found] ` <1502189793-59679-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-08-08 10:56   ` [PATCH 2/3] ARM: dts: r8a7743: Add APMU node and second CPU core Biju Das
2017-08-08 10:56 ` [PATCH 3/3] ARM: dts: r8a7743: Add OPP table for frequency scaling Biju Das
2017-08-09  8:35 ` Simon Horman [this message]
2017-08-10  9:18   ` [PATCH 0/3] Add SMP support Biju Das
2017-08-10 11:19   ` Biju Das
2017-08-11  9:37   ` Biju Das
2017-08-17  8:33     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809083554.GI2705@verge.net.au \
    --to=horms@verge.net.au \
    --cc=biju.das@bp.renesas.com \
    --cc=chris.paterson2@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).