From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: robh+dt@kernel.org, frowand.list@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, hch@lst.de,
m.szyprowski@samsung.com, stefan.wahren@i2se.com,
afaerber@suse.de, hverkuil@xs4all.nl, johan@kernel.org
Subject: Re: [PATCH 1/2] of: Fix DMA mask generation
Date: Fri, 11 Aug 2017 19:56:41 +0200 [thread overview]
Message-ID: <20170811175641.GA1921@lst.de> (raw)
In-Reply-To: <0819179085df6c41c70e83a2c5c138b95c0386b3.1502468875.git.robin.murphy@arm.com>
On Fri, Aug 11, 2017 at 05:29:56PM +0100, Robin Murphy wrote:
> Historically, DMA masks have suffered some ambiguity between whether
> they represent the range of physical memory a device can access, or the
> address bits a device is capable of driving, particularly since on many
> platforms the two are equivalent. Whilst there are some stragglers left
> (dma_max_pfn(), I'm looking at you...), the majority of DMA code has
> been cleaned up to follow the latter definition, not least since it is
> the only one which makes sense once IOMMUs are involved.
I think it always was supposed to be the latter, but that doesn't mean
that everyone got the message :)
> Either of these patches alone should be sufficient to un-break RPi3,
> and they apply independently, so I'm quite happy for one to go in as a
> fix now and the other to wait for 4.14.
This one is something I'm comfortable feeding to Linus for 4.13
if I get a few ACKs from people familar with the OF code and intended
meaning of the ranges in the device tree.
next prev parent reply other threads:[~2017-08-11 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 16:29 [PATCH 1/2] of: Fix DMA mask generation Robin Murphy
2017-08-11 16:29 ` [PATCH 2/2] of: Restrict DMA configuration Robin Murphy
[not found] ` <82633e62b64e28dc18bc466319065b92faf2414f.1502468875.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-08-11 18:01 ` Christoph Hellwig
2017-08-14 20:08 ` Rob Herring
[not found] ` <CAL_JsqKW7nhkCDu4eEDCgdC87b0MLH1UFO8LvaH22BcJMBsY7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-15 10:18 ` Robin Murphy
[not found] ` <6819c6ae-e898-3293-d8b0-7a80108d7628-5wv7dgnIgG8@public.gmane.org>
2017-08-15 14:19 ` Rob Herring
2017-08-25 14:54 ` Christoph Hellwig
2017-08-11 17:56 ` Christoph Hellwig [this message]
[not found] ` <0819179085df6c41c70e83a2c5c138b95c0386b3.1502468875.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-08-14 21:09 ` [PATCH 1/2] of: Fix DMA mask generation Rob Herring
2017-08-17 8:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811175641.GA1921@lst.de \
--to=hch@lst.de \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).