* [PATCH v3 2/5] iio: srf08: add device tree table
@ 2017-08-16 19:33 Andreas Klinger
2017-08-18 6:59 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Klinger @ 2017-08-16 19:33 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, linux-iio
Cc: wsa, robh+dt, mark.rutland, linux-i2c, devicetree, linux-kernel
Added MODULE_DEVICE_TABLE for device tree bindings.
It used to work without it by using the i2c_device_id table, but adding the
table makes everything clear and documented.
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
drivers/iio/proximity/srf08.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
index 49316cbf7c60..3f19536f215f 100644
--- a/drivers/iio/proximity/srf08.c
+++ b/drivers/iio/proximity/srf08.c
@@ -378,6 +378,13 @@ static int srf08_probe(struct i2c_client *client,
return devm_iio_device_register(&client->dev, indio_dev);
}
+static const struct of_device_id of_srf08_match[] = {
+ { .compatible = "devantech,srf08", 0},
+ {},
+};
+
+MODULE_DEVICE_TABLE(of, of_srf08_match);
+
static const struct i2c_device_id srf08_id[] = {
{ "srf08", 0 },
{ }
@@ -387,6 +394,7 @@ MODULE_DEVICE_TABLE(i2c, srf08_id);
static struct i2c_driver srf08_driver = {
.driver = {
.name = "srf08",
+ .of_match_table = of_srf08_match,
},
.probe = srf08_probe,
.id_table = srf08_id,
--
2.1.4
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 2/5] iio: srf08: add device tree table
2017-08-16 19:33 [PATCH v3 2/5] iio: srf08: add device tree table Andreas Klinger
@ 2017-08-18 6:59 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-08-18 6:59 UTC (permalink / raw)
To: Andreas Klinger
Cc: knaack.h, lars, pmeerw, linux-iio, wsa, robh+dt, mark.rutland,
linux-i2c, devicetree, linux-kernel
On Wed, 16 Aug 2017 21:33:47 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> Added MODULE_DEVICE_TABLE for device tree bindings.
>
> It used to work without it by using the i2c_device_id table, but adding the
> table makes everything clear and documented.
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/iio/proximity/srf08.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index 49316cbf7c60..3f19536f215f 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -378,6 +378,13 @@ static int srf08_probe(struct i2c_client *client,
> return devm_iio_device_register(&client->dev, indio_dev);
> }
>
> +static const struct of_device_id of_srf08_match[] = {
> + { .compatible = "devantech,srf08", 0},
> + {},
> +};
> +
> +MODULE_DEVICE_TABLE(of, of_srf08_match);
> +
> static const struct i2c_device_id srf08_id[] = {
> { "srf08", 0 },
> { }
> @@ -387,6 +394,7 @@ MODULE_DEVICE_TABLE(i2c, srf08_id);
> static struct i2c_driver srf08_driver = {
> .driver = {
> .name = "srf08",
> + .of_match_table = of_srf08_match,
> },
> .probe = srf08_probe,
> .id_table = srf08_id,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-18 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 19:33 [PATCH v3 2/5] iio: srf08: add device tree table Andreas Klinger
2017-08-18 6:59 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).