From: Tom Rini <trini@konsulko.com>
To: Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
Nishanth Menon <nm@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Jason Kridner <jkridner@beagleboard.org>,
Drew Fustini <drew@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: TI: Enable __symbols__ in dtb files for some platforms
Date: Wed, 16 Aug 2017 20:33:55 -0400 [thread overview]
Message-ID: <20170817003355.GR20467@bill-the-cat> (raw)
In-Reply-To: <5994CDD1.9050708@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3263 bytes --]
On Wed, Aug 16, 2017 at 03:57:21PM -0700, Frank Rowand wrote:
> On 08/16/17 15:33, Frank Rowand wrote:
> > On 08/16/17 14:59, Tom Rini wrote:
> >> Build the dtb file for these platfroms with __symbol__ information
> >> included. This will reduce the size of the dtb (and resident memory
> >
> > typo: reduce the size should be increase the size
> >
> >
> >> usage) in exchange for allowing more types of overlays to be applied to
> >> the dtb file prior to passing it to Linux and additional functionality
> >> within the kernel when OF_OVERLAY is enabled.
> >>
> >> Cc: Jason Kridner <jkridner@beagleboard.org>
> >> Cc: Drew Fustini <drew@beagleboard.org>
> >> Cc: Robert Nelson <robertcnelson@gmail.com>
> >> Cc: Lokesh Vutla <lokeshvutla@ti.com>
> >> Cc: Frank Rowand <frowand.list@gmail.com>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> Cc: Russell King <linux@armlinux.org.uk>
> >> Cc: devicetree@vger.kernel.org
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-off-by: Tom Rini <trini@konsulko.com>
> >> ---
> >> This patch takes the path that Rob encouraged in my previous patch of
> >> enabling __symbols__ in some platforms now (that can use it) and see if
> >> a critical mass evolves that pushes towards -@ being default for all
> >> dtbs. I would suggest that the dra76 series be respun to include a hunk
> >> like this at least as well, and if there's another Beagle X15 patch,
> >> that too. Russell, per some of our conversations, something like would
> >> also be needed as part of using overlays to solve some of the problems
> >> with Hummingboard, etc.
> >> ---
> >> arch/arm/boot/dts/Makefile | 14 ++++++++++++++
> >> 1 file changed, 14 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index 4b17f35dc9a7..6f98422ca00e 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -1063,3 +1063,17 @@ dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dts
> >>
> >> always := $(dtb-y)
> >> clean-files := *.dtb
> >> +
> >> +# enable creation of __symbols__ node
> >> +DTC_FLAGS_am335x-bone += -@
> >> +DTC_FLAGS_am335x-boneblack += -@
> >> +DTC_FLAGS_am335x-boneblack-wireless += -@
> >> +DTC_FLAGS_am335x-boneblue += -@
> >> +DTC_FLAGS_am335x-bonegreen += -@
> >> +DTC_FLAGS_am335x-bonegreen-wireless += -@
> >> +DTC_FLAGS_am57xx-beagle-x15 += -@
> >> +DTC_FLAGS_am57xx-beagle-x15-revb1 += -@
> >> +DTC_FLAGS_dra7-evm += -@
> >> +DTC_FLAGS_dra72-evm += -@
> >> +DTC_FLAGS_dra72-evm-revc += -@
> >> +DTC_FLAGS_dra71-evm += -@
> >>
> >
> > I would prefer that instead of "-@", a configurable value be used.
>
> I stated that poorly. It was intended conceptually, not literally.
>
> One possible concrete implementation would be to use something other
> than DTC_FLAGS, for example DTC_FLAGS_EXTRA, then have the build
> system choose whether to fold DTC_FLAGS_EXTRA into DTC_FLAGS, based
> on some sort of configurable value.
So you would have to pass in a flag, and then set a CONFIG option for
"please use this flag I just explicitly set" ?
--
Tom
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-08-17 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 21:59 [PATCH] ARM: dts: TI: Enable __symbols__ in dtb files for some platforms Tom Rini
2017-08-16 22:33 ` Frank Rowand
2017-08-16 22:57 ` Frank Rowand
2017-08-17 0:33 ` Tom Rini [this message]
2017-08-17 6:15 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817003355.GR20467@bill-the-cat \
--to=trini@konsulko.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=frowand.list@gmail.com \
--cc=jkridner@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lokeshvutla@ti.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).