[PATCH 0/3] Add SMP support

[PATCH 0/3] Add SMP support

[Biju Das]

This series aims to add SMP support for r8a7743 SoC.

This series has been tested against Linux-next tag 20170727
and renesas-dev branch.

Biju Das (3):
  dt-bindings: apmu: Document r8a7743 support
  ARM: dts: r8a7743: Add APMU node and second CPU core
  ARM: dts: r8a7743: Add OPP table for frequency scaling

 .../devicetree/bindings/power/renesas,apmu.txt     |  3 ++-
 arch/arm/boot/dts/r8a7743.dtsi                     | 25 ++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/3] dt-bindings: apmu: Document r8a7743 support

[Biju Das]

Document APMU and SMP enable method for RZ/G1M
(also known as r8a7743) SoC.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 Documentation/devicetree/bindings/power/renesas,apmu.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/renesas,apmu.txt b/Documentation/devicetree/bindings/power/renesas,apmu.txt
index 84404c9..af21502 100644
--- a/Documentation/devicetree/bindings/power/renesas,apmu.txt
+++ b/Documentation/devicetree/bindings/power/renesas,apmu.txt
@@ -1,12 +1,13 @@
 DT bindings for the Renesas Advanced Power Management Unit
 
-Renesas R-Car line of SoCs utilize one or more APMU hardware units
+Renesas R-Car and RZ/G1 SoCs utilize one or more APMU hardware units
 for CPU core power domain control including SMP boot and CPU Hotplug.
 
 Required properties:
 
 - compatible: Should be "renesas,<soctype>-apmu", "renesas,apmu" as fallback.
 	      Examples with soctypes are:
+		- "renesas,r8a7743-apmu" (RZ/G1M)
 		- "renesas,r8a7790-apmu" (R-Car H2)
 		- "renesas,r8a7791-apmu" (R-Car M2-W)
 		- "renesas,r8a7792-apmu" (R-Car V2H)
-- 
1.9.1

[PATCH 2/3] ARM: dts: r8a7743: Add APMU node and second CPU core

[Biju Das]

Add DT nodes for the Advanced Power Management Unit (APMU) and the
second CPU core.  Use the enable-method to point out that the APMU
should be used for SMP support.

Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
 arch/arm/boot/dts/r8a7743.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index f62e858..77da319 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -21,6 +21,7 @@
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
+		enable-method = "renesas,apmu";
 
 		cpu0: cpu@0 {
 			device_type = "cpu";
@@ -32,6 +33,15 @@
 			next-level-cache = <&L2_CA15>;
 		};
 
+		cpu1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a15";
+			reg = <1>;
+			clock-frequency = <1500000000>;
+			power-domains = <&sysc R8A7743_PD_CA15_CPU1>;
+			next-level-cache = <&L2_CA15>;
+		};
+
 		L2_CA15: cache-controller-0 {
 			compatible = "cache";
 			cache-unified;
@@ -48,6 +58,12 @@
 		#size-cells = <2>;
 		ranges;
 
+		apmu@e6152000 {
+			compatible = "renesas,r8a7743-apmu", "renesas,apmu";
+			reg = <0 0xe6152000 0 0x188>;
+			cpus = <&cpu0 &cpu1>;
+		};
+
 		gic: interrupt-controller@f1001000 {
 			compatible = "arm,gic-400";
 			#interrupt-cells = <3>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] ARM: dts: r8a7743: Add OPP table for frequency scaling

[Biju Das]

Add needed information inside CPU0 for the generic cpufreq-cpu0 driver.

- clock-latency = 300 us
Approximate worst-case latency to do clock transition for every
OPPs. Using an arbitrary safe value similar to r8a7791(R-Car M2) Soc.

- operating-points = < kHz - uV >
List of 6 operating points. All of them are using the same voltage
since DVS is not supported in RZ/G1 Soc.

Note:This also fixes the below errors seen on kernel logs
[    0.876877] cpu cpu0: dev_pm_opp_get_opp_count: OPP table not found (-19)
[    0.883727] cpu cpu1: cpufreq_init: failed to get clk: -2

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/r8a7743.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 77da319..8c46f62 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -29,8 +29,17 @@
 			reg = <0>;
 			clock-frequency = <1500000000>;
 			clocks = <&cpg CPG_CORE R8A7743_CLK_Z>;
+			clock-latency = <300000>; /* 300 us */
 			power-domains = <&sysc R8A7743_PD_CA15_CPU0>;
 			next-level-cache = <&L2_CA15>;
+
+			/* kHz - uV - OPPs unknown yet */
+			operating-points = <1500000 1000000>,
+					   <1312500 1000000>,
+					   <1125000 1000000>,
+					   < 937500 1000000>,
+					   < 750000 1000000>,
+					   < 375000 1000000>;
 		};
 
 		cpu1: cpu@1 {
-- 
1.9.1

Re: [PATCH 0/3] Add SMP support

[Simon Horman]

On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote:
> This series aims to add SMP support for r8a7743 SoC.
> 
> This series has been tested against Linux-next tag 20170727
> and renesas-dev branch.

It seems that these patches are targeted at the renesas tree.
The best practice in that case is to base patches on the latest
devel branch. Please consider doing so in future.

The patches themselves seem good to me, however, I would like to enquire
about testing. In particular, have you tested CPU hotplug and suspend to
RAM with these patches (and without in the case of the latter)?

I am cautious about any regressions that may creep in
when going from UP to SMP.

> 
> Biju Das (3):
>   dt-bindings: apmu: Document r8a7743 support
>   ARM: dts: r8a7743: Add APMU node and second CPU core
>   ARM: dts: r8a7743: Add OPP table for frequency scaling
> 
>  .../devicetree/bindings/power/renesas,apmu.txt     |  3 ++-
>  arch/arm/boot/dts/r8a7743.dtsi                     | 25 ++++++++++++++++++++++
>  2 files changed, 27 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.1
> 

RE: [PATCH 0/3] Add SMP support

[Biju Das]

> -----Original Message-----
> From: Simon Horman [mailto:horms@verge.net.au]
> Sent: 09 August 2017 09:36
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>;
> Russell King <linux@armlinux.org.uk>; Chris Paterson
> <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 0/3] Add SMP support
>
> On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote:
> > This series aims to add SMP support for r8a7743 SoC.
> >
> > This series has been tested against Linux-next tag 20170727 and
> > renesas-dev branch.
>
> It seems that these patches are targeted at the renesas tree.
> The best practice in that case is to base patches on the latest devel branch.
> Please consider doing so in future.
>
> The patches themselves seem good to me, however, I would like to enquire
> about testing. In particular, have you tested CPU hotplug and suspend to RAM
> with these patches (and without in the case of the latter)?

I have tested CPU hotplug with this patch and it works ok.

Currently iWave platform doesn't support STR I guess. But we should check the changes on other M2 platforms to prove that
things don't break.

[>]
> I am cautious about any regressions that may creep in when going from UP to
> SMP.

> >
> > Biju Das (3):
> >   dt-bindings: apmu: Document r8a7743 support
> >   ARM: dts: r8a7743: Add APMU node and second CPU core
> >   ARM: dts: r8a7743: Add OPP table for frequency scaling
> >
> >  .../devicetree/bindings/power/renesas,apmu.txt     |  3 ++-
> >  arch/arm/boot/dts/r8a7743.dtsi                     | 25 ++++++++++++++++++++++
> >  2 files changed, 27 insertions(+), 1 deletion(-)
> >
> > --
> > 1.9.1
> >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 0/3] Add SMP support

[Biju Das]

> -----Original Message-----
> From: Biju Das
> Sent: 10 August 2017 10:17
> To: 'Simon Horman' <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Mark Rutland
> <mark.rutland-5wv7dgnIgG8@public.gmane.org>; Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>;
> Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>; Chris Paterson
> <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-renesas-
> soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Subject: RE: [PATCH 0/3] Add SMP support
>
>
> > -----Original Message-----
> > From: Simon Horman [mailto:horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org]
> > Sent: 09 August 2017 09:36
> > To: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Mark Rutland
> > <mark.rutland-5wv7dgnIgG8@public.gmane.org>; Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>;
> Russell
> > King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>; Chris Paterson
> > <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > linux-renesas- soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> > Subject: Re: [PATCH 0/3] Add SMP support
> >
> > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote:
> > > This series aims to add SMP support for r8a7743 SoC.
> > >
> > > This series has been tested against Linux-next tag 20170727 and
> > > renesas-dev branch.
> >
> > It seems that these patches are targeted at the renesas tree.
> > The best practice in that case is to base patches on the latest devel branch.
> > Please consider doing so in future.
> >
> > The patches themselves seem good to me, however, I would like to
> > enquire about testing. In particular, have you tested CPU hotplug and
> > suspend to RAM with these patches (and without in the case of the latter)?
>
> I have tested CPU hotplug with this patch and it works ok.
>
> Currently iWave platform doesn't support STR I guess. But we should check the
> changes on other M2 platforms to prove that things don't break.

I have tested STR on RZ-G1M SK(r8a7743) platform using gpio-key as wake up source.
It works fine with and without the patch . It is tested against renesas-developer branch.

Also I have tested STR on R-Car M2 board.it works fine with gpio-key as wake up source.

> [>]
> > I am cautious about any regressions that may creep in when going from
> > UP to SMP.
>
> > >
> > > Biju Das (3):
> > >   dt-bindings: apmu: Document r8a7743 support
> > >   ARM: dts: r8a7743: Add APMU node and second CPU core
> > >   ARM: dts: r8a7743: Add OPP table for frequency scaling
> > >
> > >  .../devicetree/bindings/power/renesas,apmu.txt     |  3 ++-
> > >  arch/arm/boot/dts/r8a7743.dtsi                     | 25
> ++++++++++++++++++++++
> > >  2 files changed, 27 insertions(+), 1 deletion(-)
> > >
> > > --
> > > 1.9.1
> > >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/3] Add SMP support

[Biju Das]

Hello,


> -----Original Message-----
> From: Biju Das
> Sent: 10 August 2017 12:19
> To: 'Simon Horman' <horms@verge.net.au>
> Cc: 'Rob Herring' <robh+dt@kernel.org>; 'Mark Rutland'
> <mark.rutland@arm.com>; 'Magnus Damm' <magnus.damm@gmail.com>;
> 'Russell King' <linux@armlinux.org.uk>; Chris Paterson
> <Chris.Paterson2@renesas.com>; 'devicetree@vger.kernel.org'
> <devicetree@vger.kernel.org>; 'linux-renesas-soc@vger.kernel.org' <linux-
> renesas-soc@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-
> arm-kernel@lists.infradead.org>
> Subject: RE: [PATCH 0/3] Add SMP support
>
>
>
> > -----Original Message-----
> > From: Biju Das
> > Sent: 10 August 2017 10:17
> > To: 'Simon Horman' <horms@verge.net.au>
> > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> > <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>;
> Russell
> > King <linux@armlinux.org.uk>; Chris Paterson
> > <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org;
> > linux-renesas- soc@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org
> > Subject: RE: [PATCH 0/3] Add SMP support
> >
> >
> > > -----Original Message-----
> > > From: Simon Horman [mailto:horms@verge.net.au]
> > > Sent: 09 August 2017 09:36
> > > To: Biju Das <biju.das@bp.renesas.com>
> > > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> > > <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>;
> > Russell
> > > King <linux@armlinux.org.uk>; Chris Paterson
> > > <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org;
> > > linux-renesas- soc@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org
> > > Subject: Re: [PATCH 0/3] Add SMP support
> > >
> > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote:
> > > > This series aims to add SMP support for r8a7743 SoC.
> > > >
> > > > This series has been tested against Linux-next tag 20170727 and
> > > > renesas-dev branch.
> > >
> > > It seems that these patches are targeted at the renesas tree.
> > > The best practice in that case is to base patches on the latest devel branch.
> > > Please consider doing so in future.
> > >
> > > The patches themselves seem good to me, however, I would like to
> > > enquire about testing. In particular, have you tested CPU hotplug
> > > and suspend to RAM with these patches (and without in the case of the
> latter)?
> >
> > I have tested CPU hotplug with this patch and it works ok.
> >
> > Currently iWave platform doesn't support STR I guess. But we should
> > check the changes on other M2 platforms to prove that things don't break.

I have tested STR on iWave RZ-G1M platform as well. I  used ttySC0 as wake up
Source(echo enabled > /sys/class/tty/ttySC0/power/wakeup)

It works fine with and without the patch .

It is tested against renesas-developer branch tag 20170809-v4.13-rc4.

> I have tested STR on RZ-G1M SK(r8a7743) platform using gpio-key as wake up
> source.
> It works fine with and without the patch . It is tested against renesas-developer
> branch.
>
> Also I have tested STR on R-Car M2 board.it works fine with gpio-key as wake
> up source.
>
> > [>]
> > > I am cautious about any regressions that may creep in when going
> > > from UP to SMP.
> >
> > > >
> > > > Biju Das (3):
> > > >   dt-bindings: apmu: Document r8a7743 support
> > > >   ARM: dts: r8a7743: Add APMU node and second CPU core
> > > >   ARM: dts: r8a7743: Add OPP table for frequency scaling
> > > >
> > > >  .../devicetree/bindings/power/renesas,apmu.txt     |  3 ++-
> > > >  arch/arm/boot/dts/r8a7743.dtsi                     | 25
> > ++++++++++++++++++++++
> > > >  2 files changed, 27 insertions(+), 1 deletion(-)
> > > >
> > > > --
> > > > 1.9.1
> > > >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 0/3] Add SMP support

[Simon Horman]

On Fri, Aug 11, 2017 at 09:37:45AM +0000, Biju Das wrote:
> Hello,
> 
> 
> > -----Original Message-----
> > From: Biju Das
> > Sent: 10 August 2017 12:19
> > To: 'Simon Horman' <horms@verge.net.au>
> > Cc: 'Rob Herring' <robh+dt@kernel.org>; 'Mark Rutland'
> > <mark.rutland@arm.com>; 'Magnus Damm' <magnus.damm@gmail.com>;
> > 'Russell King' <linux@armlinux.org.uk>; Chris Paterson
> > <Chris.Paterson2@renesas.com>; 'devicetree@vger.kernel.org'
> > <devicetree@vger.kernel.org>; 'linux-renesas-soc@vger.kernel.org' <linux-
> > renesas-soc@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-
> > arm-kernel@lists.infradead.org>
> > Subject: RE: [PATCH 0/3] Add SMP support
> >
> >
> >
> > > -----Original Message-----
> > > From: Biju Das
> > > Sent: 10 August 2017 10:17
> > > To: 'Simon Horman' <horms@verge.net.au>
> > > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> > > <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>;
> > Russell
> > > King <linux@armlinux.org.uk>; Chris Paterson
> > > <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org;
> > > linux-renesas- soc@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org
> > > Subject: RE: [PATCH 0/3] Add SMP support
> > >
> > >
> > > > -----Original Message-----
> > > > From: Simon Horman [mailto:horms@verge.net.au]
> > > > Sent: 09 August 2017 09:36
> > > > To: Biju Das <biju.das@bp.renesas.com>
> > > > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> > > > <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>;
> > > Russell
> > > > King <linux@armlinux.org.uk>; Chris Paterson
> > > > <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org;
> > > > linux-renesas- soc@vger.kernel.org;
> > > > linux-arm-kernel@lists.infradead.org
> > > > Subject: Re: [PATCH 0/3] Add SMP support
> > > >
> > > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote:
> > > > > This series aims to add SMP support for r8a7743 SoC.
> > > > >
> > > > > This series has been tested against Linux-next tag 20170727 and
> > > > > renesas-dev branch.
> > > >
> > > > It seems that these patches are targeted at the renesas tree.
> > > > The best practice in that case is to base patches on the latest devel branch.
> > > > Please consider doing so in future.
> > > >
> > > > The patches themselves seem good to me, however, I would like to
> > > > enquire about testing. In particular, have you tested CPU hotplug
> > > > and suspend to RAM with these patches (and without in the case of the
> > latter)?
> > >
> > > I have tested CPU hotplug with this patch and it works ok.
> > >
> > > Currently iWave platform doesn't support STR I guess. But we should
> > > check the changes on other M2 platforms to prove that things don't break.
> 
> I have tested STR on iWave RZ-G1M platform as well. I  used ttySC0 as wake up
> Source(echo enabled > /sys/class/tty/ttySC0/power/wakeup)
> 
> It works fine with and without the patch .
> 
> It is tested against renesas-developer branch tag 20170809-v4.13-rc4.
> 
> > I have tested STR on RZ-G1M SK(r8a7743) platform using gpio-key as wake up
> > source.
> > It works fine with and without the patch . It is tested against renesas-developer
> > branch.
> >
> > Also I have tested STR on R-Car M2 board.it works fine with gpio-key as wake
> > up source.
> >
> > > [>]
> > > > I am cautious about any regressions that may creep in when going
> > > > from UP to SMP.

Thanks for testing, I have applied this series.