* [PATCH] arm64: dts: ls1088a: Add USB support
@ 2017-08-17 2:52 yinbo.zhu-3arQi8VN3Tc
[not found] ` <1502938358-23522-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: yinbo.zhu-3arQi8VN3Tc @ 2017-08-17 2:52 UTC (permalink / raw)
To: yinbo.zhu-3arQi8VN3Tc,
linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon
Cc: Shawn Guo, Harninder Rai, Raghav Dogra, Ashish Kumar,
Yuantian Tang, open list:, moderated list:, open list
From: "yinbo.zhu" <yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
Fix the issue that usb is not detected on ls1088ardb
Signed-off-by: yinbo.zhu <yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
Signed-off-by: Ran Wang <ran.wang_1-3arQi8VN3Tc@public.gmane.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18 ++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
index e9276a5..949cd67 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
@@ -145,6 +145,14 @@
status = "okay";
};
+&usb0 {
+ status = "okay";
+};
+
+&usb1 {
+ status = "okay";
+};
+
&esdhc {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 3a3be87..0dbff29 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -458,6 +458,24 @@
status = "disabled";
};
+ usb0: usb3@3100000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x3100000 0x0 0x10000>;
+ interrupts = <0 80 0x4>; /* Level high type */
+ dr_mode = "host";
+ configure-gfladj;
+ snps,dis_rxdet_inp3_quirk;
+ };
+
+ usb1: usb3@3110000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x3110000 0x0 0x10000>;
+ interrupts = <0 81 0x4>; /* Level high type */
+ dr_mode = "host";
+ configure-gfladj;
+ snps,dis_rxdet_inp3_quirk;
+ };
+
sata: sata@3200000 {
compatible = "fsl,ls1088a-ahci";
reg = <0x0 0x3200000 0x0 0x10000>,
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1502938358-23522-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH] arm64: dts: ls1088a: Add USB support [not found] ` <1502938358-23522-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org> @ 2017-08-17 14:02 ` Shawn Guo 2017-08-18 7:48 ` Yinbo Zhu 0 siblings, 1 reply; 6+ messages in thread From: Shawn Guo @ 2017-08-17 14:02 UTC (permalink / raw) To: yinbo.zhu-3arQi8VN3Tc Cc: linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Harninder Rai, Yuantian Tang, open list:, Ashish Kumar, open list, Raghav Dogra, moderated list: On Thu, Aug 17, 2017 at 10:52:38AM +0800, yinbo.zhu-3arQi8VN3Tc@public.gmane.org wrote: > From: "yinbo.zhu" <yinbo.zhu-3arQi8VN3Tc@public.gmane.org> > > Fix the issue that usb is not detected on ls1088ardb > > Signed-off-by: yinbo.zhu <yinbo.zhu-3arQi8VN3Tc@public.gmane.org> > Signed-off-by: Ran Wang <ran.wang_1-3arQi8VN3Tc@public.gmane.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18 ++++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > index e9276a5..949cd67 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > @@ -145,6 +145,14 @@ > status = "okay"; > }; > > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > + > &esdhc { > status = "okay"; > }; Sort the labelled node alphabetically. > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 3a3be87..0dbff29 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -458,6 +458,24 @@ > status = "disabled"; > }; > > + usb0: usb3@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; /* Level high type */ Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment. > + dr_mode = "host"; > + configure-gfladj; What is this? I do not see it in upstream kernel. > + snps,dis_rxdet_inp3_quirk; You probably need a "disabled" status. Shawn > + }; > + > + usb1: usb3@3110000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; /* Level high type */ > + dr_mode = "host"; > + configure-gfladj; > + snps,dis_rxdet_inp3_quirk; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1088a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: ls1088a: Add USB support 2017-08-17 14:02 ` Shawn Guo @ 2017-08-18 7:48 ` Yinbo Zhu [not found] ` <VI1PR04MB1262662395B8CD06BAF074CFE9800-mr6QIVyDiCGbtYzA8xQqo89NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Yinbo Zhu @ 2017-08-18 7:48 UTC (permalink / raw) To: Shawn Guo Cc: linux-devel@gforge.freescale.net, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Harninder Rai, Andy Tang, open list:, Ashish Kumar, open list, Raghav Dogra, moderated list: -----Original Message----- From: Shawn Guo [mailto:shawnguo@kernel.org] Sent: Thursday, August 17, 2017 10:03 PM To: Yinbo Zhu <yinbo.zhu@nxp.com> Cc: linux-devel@gforge.freescale.net; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>; Harninder Rai <harninder.rai@nxp.com>; Andy Tang <andy.tang@nxp.com>; open list: <devicetree@vger.kernel.org>; Ashish Kumar <ashish.kumar@nxp.com>; open list <linux-kernel@vger.kernel.org>; Raghav Dogra <raghav.dogra@nxp.com>; moderated list: <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support On Thu, Aug 17, 2017 at 10:52:38AM +0800, yinbo.zhu@nxp.com wrote: > From: "yinbo.zhu" <yinbo.zhu@nxp.com> > > Fix the issue that usb is not detected on ls1088ardb > > Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18 ++++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > index e9276a5..949cd67 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > @@ -145,6 +145,14 @@ > status = "okay"; > }; > > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > + > &esdhc { > status = "okay"; > }; Sort the labelled node alphabetically. > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 3a3be87..0dbff29 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -458,6 +458,24 @@ > status = "disabled"; > }; > > + usb0: usb3@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; /* Level high type */ Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment. > + dr_mode = "host"; > + configure-gfladj; What is this? I do not see it in upstream kernel. > + snps,dis_rxdet_inp3_quirk; You probably need a "disabled" status. Shawn Hi Shawn, About your description " You probably need a "disabled" status." Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it? In fact, if remove the property , 1088ardb usb will doesn't detect. Yinbo > + }; > + > + usb1: usb3@3110000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; /* Level high type */ > + dr_mode = "host"; > + configure-gfladj; > + snps,dis_rxdet_inp3_quirk; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1088a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <VI1PR04MB1262662395B8CD06BAF074CFE9800-mr6QIVyDiCGbtYzA8xQqo89NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH] arm64: dts: ls1088a: Add USB support [not found] ` <VI1PR04MB1262662395B8CD06BAF074CFE9800-mr6QIVyDiCGbtYzA8xQqo89NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-08-18 8:03 ` Shawn Guo 0 siblings, 0 replies; 6+ messages in thread From: Shawn Guo @ 2017-08-18 8:03 UTC (permalink / raw) To: Yinbo Zhu Cc: Mark Rutland, Harninder Rai, Andy Tang, open list:, Catalin Marinas, Will Deacon, Ashish Kumar, open list, Rob Herring, linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org, Raghav Dogra, moderated list: On Fri, Aug 18, 2017 at 07:48:19AM +0000, Yinbo Zhu wrote: > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > index 3a3be87..0dbff29 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > @@ -458,6 +458,24 @@ > > status = "disabled"; > > }; > > > > + usb0: usb3@3100000 { > > + compatible = "snps,dwc3"; > > + reg = <0x0 0x3100000 0x0 0x10000>; > > + interrupts = <0 80 0x4>; /* Level high type */ > > Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment. > > > + dr_mode = "host"; > > + configure-gfladj; > > What is this? I do not see it in upstream kernel. > > > + snps,dis_rxdet_inp3_quirk; > > You probably need a "disabled" status. > > Shawn > > Hi Shawn, > > About your description " You probably need a "disabled" status." > Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it? > In fact, if remove the property , 1088ardb usb will doesn't detect. No, that's not what I meant. I meant the USB device should be disabled by default in <soc>.dtsi by having the following line. status = "disabled"; And then if your board has the pin-out of this USB device, you have the line below to turn on the support. status = "okay"; Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: ls1088a: Add USB support
@ 2017-08-18 8:14 yinbo.zhu
[not found] ` <1503044085-5024-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: yinbo.zhu @ 2017-08-18 8:14 UTC (permalink / raw)
To: yinbo.zhu, linux-devel, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon
Cc: Shawn Guo, Harninder Rai, Ashish Kumar, Yuantian Tang, open list:,
moderated list:, open list
From: "yinbo.zhu" <yinbo.zhu@nxp.com>
Fix the issue that usb is not detected on ls1088ardb
Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 20 ++++++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
index 213abb7..6c3c3bc 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
@@ -118,6 +118,14 @@
status = "okay";
};
+&usb0 {
+ status = "okay";
+};
+
+&usb1 {
+ status = "okay";
+};
+
&esdhc {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index c144d06..c23fede 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -359,6 +359,26 @@
status = "disabled";
};
+ usb0: usb3@3100000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x3100000 0x0 0x10000>;
+ interrupts = <0 80 IRQ_TYPE_LEVEL_HIGH>;
+ dr_mode = "host";
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,dis_rxdet_inp3_quirk;
+ status = "disabled";
+ };
+
+ usb1: usb3@3110000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x3110000 0x0 0x10000>;
+ interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
+ dr_mode = "host";
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,dis_rxdet_inp3_quirk;
+ status = "disabled";
+ };
+
sata: sata@3200000 {
compatible = "fsl,ls1088a-ahci";
reg = <0x0 0x3200000 0x0 0x10000>,
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1503044085-5024-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH] arm64: dts: ls1088a: Add USB support [not found] ` <1503044085-5024-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org> @ 2017-08-18 13:02 ` Shawn Guo 0 siblings, 0 replies; 6+ messages in thread From: Shawn Guo @ 2017-08-18 13:02 UTC (permalink / raw) To: yinbo.zhu-3arQi8VN3Tc Cc: linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Harninder Rai, Ashish Kumar, Yuantian Tang, open list:, moderated list:, open list On Fri, Aug 18, 2017 at 04:14:45PM +0800, yinbo.zhu-3arQi8VN3Tc@public.gmane.org wrote: > From: "yinbo.zhu" <yinbo.zhu-3arQi8VN3Tc@public.gmane.org> > > Fix the issue that usb is not detected on ls1088ardb > > Signed-off-by: yinbo.zhu <yinbo.zhu-3arQi8VN3Tc@public.gmane.org> > Signed-off-by: Ran Wang <ran.wang_1-3arQi8VN3Tc@public.gmane.org> You are sending an updated patch. Please have the version number in subject prefix ... > --- ... and a change history here. There are a lot of good examples on the list. Please have a check. > arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 8 ++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 20 ++++++++++++++++++++ > 2 files changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > index 213abb7..6c3c3bc 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > @@ -118,6 +118,14 @@ > status = "okay"; > }; > > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > + > &esdhc { > status = "okay"; > }; I had already put this on previous version - please sort these labelled nodes alphabetically. That said, &usb should go after &sata. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-18 13:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17 2:52 [PATCH] arm64: dts: ls1088a: Add USB support yinbo.zhu-3arQi8VN3Tc
[not found] ` <1502938358-23522-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
2017-08-17 14:02 ` Shawn Guo
2017-08-18 7:48 ` Yinbo Zhu
[not found] ` <VI1PR04MB1262662395B8CD06BAF074CFE9800-mr6QIVyDiCGbtYzA8xQqo89NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-18 8:03 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2017-08-18 8:14 yinbo.zhu
[not found] ` <1503044085-5024-1-git-send-email-yinbo.zhu-3arQi8VN3Tc@public.gmane.org>
2017-08-18 13:02 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).