From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Date: Fri, 18 Aug 2017 10:56:13 +0530 Message-ID: <20170818052613.GE3053@localhost> References: <1501583880-32072-1-git-send-email-anup.patel@broadcom.com> <1501583880-32072-16-git-send-email-anup.patel@broadcom.com> <20170817080142.GC3053@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Anup Patel Cc: Rob Herring , Mark Rutland , Dan Williams , Florian Fainelli , Scott Branden , Ray Jui , Linux Kernel , Linux ARM Kernel , Device Tree , dmaengine@vger.kernel.org, BCM Kernel Feedback List-Id: devicetree@vger.kernel.org On Fri, Aug 18, 2017 at 10:33:54AM +0530, Anup Patel wrote: > On Thu, Aug 17, 2017 at 1:31 PM, Vinod Koul wrote: > > On Tue, Aug 01, 2017 at 04:07:59PM +0530, Anup Patel wrote: > > why fail, debugfs should be an optional thingy, why would you want to fail here? > > Yes, we are handling the case when debugfs is not available > and skipping debugfs gracefully. > > If debugfs is available then failure of debugfs_create_dir() > should be reported. reported yes, bailing out on that err no.. -- ~Vinod