From: Brian Norris <briannorris@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: David Wu <david.wu@rock-chips.com>,
heiko@sntech.de, boris.brezillon@free-electrons.com,
robh+dt@kernel.org, catalin.marinas@arm.com,
dianders@chromium.org, mark.rutland@arm.com,
huangtao@rock-chips.com, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value of pwm_config
Date: Fri, 18 Aug 2017 09:28:31 -0700 [thread overview]
Message-ID: <20170818162830.GA115593@google.com> (raw)
In-Reply-To: <20170818153255.GC18307@ulmo>
On Fri, Aug 18, 2017 at 05:32:55PM +0200, Thierry Reding wrote:
> I don't understand what the "judge" is supposed to be, but I've applied
> this to for-4.14/drivers anyway. Thanks.
Probably just an artifact of non-native English.
Judging by context, David probably meant more like "Remove the check for
the return value". I believe I've seen other non-native English speakers
use "judge" in a way similar to "check" or "test" in the context of
comparisons and error checking. (A search through my mailbox for "judge"
confirms this.)
Regards,
Brian
next prev parent reply other threads:[~2017-08-18 16:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 15:38 [PATCH v3 0/7] Add rk3328 pwm support David Wu
2017-08-08 15:38 ` [PATCH v3 1/7] pwm: rockchip: Add APB and function both clocks support David Wu
[not found] ` <1502206715-24174-2-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 15:31 ` Thierry Reding
2017-08-08 15:38 ` [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value of pwm_config David Wu
2017-08-18 15:32 ` Thierry Reding
2017-08-18 16:28 ` Brian Norris [this message]
[not found] ` <20170818162830.GA115593-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-08-21 11:29 ` David.Wu
2017-08-08 15:38 ` [PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config() David Wu
[not found] ` <1502206715-24174-5-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 15:40 ` Thierry Reding
2017-08-08 15:41 ` [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP David Wu
2017-08-18 15:43 ` Thierry Reding
2017-08-18 15:44 ` Thierry Reding
2017-08-08 15:42 ` [PATCH v3 6/7] pwm: rockchip: Add rk3328 pwm support David Wu
[not found] ` <1502206967-24366-1-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 15:45 ` Thierry Reding
2017-08-08 15:43 ` [PATCH v3 7/7] arm64: dts: rockchip: Add pwm nodes for rk3328 David Wu
2017-08-18 23:06 ` Heiko Stuebner
2017-08-14 2:46 ` [PATCH v3 0/7] Add rk3328 pwm support David.Wu
[not found] ` <1502206715-24174-1-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-08 15:38 ` [PATCH v3 3/7] pwm: rockchip: Use pwm_apply instead of the pwm_enable David Wu
[not found] ` <1502206715-24174-4-git-send-email-david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-18 15:36 ` Thierry Reding
2017-08-16 10:49 ` [PATCH v3 0/7] Add rk3328 pwm support David.Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818162830.GA115593@google.com \
--to=briannorris@chromium.org \
--cc=boris.brezillon@free-electrons.com \
--cc=catalin.marinas@arm.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).