devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry
Date: Tue, 22 Aug 2017 22:12:15 +0200	[thread overview]
Message-ID: <20170822201215.wbpioc7vbse4ajja@flea.home> (raw)
In-Reply-To: <20170822061742.40869-3-icenowy-h8G6r0blFSE@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote:
> +&reg_vcc5v0 {
> +	gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
> +	enable-active-high;
> +};

Same thing here, you're not using that regulator anywhere. You don't
even use any of the regulators in sunxi-common-regulators.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2017-08-22 20:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22  6:17 [PATCH 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Icenowy Zheng
2017-08-22  6:17 ` [PATCH 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra Icenowy Zheng
     [not found]   ` <20170822061742.40869-2-icenowy-h8G6r0blFSE@public.gmane.org>
2017-08-22 20:10     ` Maxime Ripard
     [not found]       ` <20170822201043.vdweyevkxvjbzrwt-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-08-23  0:58         ` Icenowy Zheng
     [not found] ` <20170822061742.40869-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-08-22  6:17   ` [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry Icenowy Zheng
     [not found]     ` <20170822061742.40869-3-icenowy-h8G6r0blFSE@public.gmane.org>
2017-08-22 20:12       ` Maxime Ripard [this message]
     [not found]         ` <20170822201215.wbpioc7vbse4ajja-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-08-23  5:46           ` Icenowy Zheng
     [not found]             ` <D377CF9E-AE08-4AA4-AAD4-C9047C8007E9-h8G6r0blFSE@public.gmane.org>
2017-08-23 14:31               ` Maxime Ripard
2017-08-22 20:05   ` [PATCH 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Maxime Ripard
     [not found]     ` <20170822200521.nadkb4335mcc5ah2-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-08-23  0:56       ` Icenowy Zheng
2017-08-23 11:56       ` icenowy-h8G6r0blFSE
     [not found]         ` <ea10374b49489d2250fd804e1fdbf204-h8G6r0blFSE@public.gmane.org>
2017-08-23 14:35           ` Maxime Ripard
     [not found]             ` <20170823143532.owocqyq3tehsahhg-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-08-23 15:13               ` icenowy-h8G6r0blFSE
     [not found]                 ` <9554c7524c8608e1eceafe762a487c11-h8G6r0blFSE@public.gmane.org>
2017-08-24  6:07                   ` Maxime Ripard
     [not found]                     ` <20170824060709.ejlmhzfhr7pwt3tx-ZC1Zs529Oq4@public.gmane.org>
2017-08-24  6:25                       ` icenowy-h8G6r0blFSE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822201215.wbpioc7vbse4ajja@flea.home \
    --to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=icenowy-h8G6r0blFSE@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).