From: Lee Jones <lee.jones@linaro.org>
To: Abhisit Sangjan <s.abhisit@gmail.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
jmondi <jacopo@jmondi.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] mfd: Add support for TI LMP92001
Date: Wed, 23 Aug 2017 14:21:49 +0100 [thread overview]
Message-ID: <20170823132149.svvvhtvrxv3fxhax@dell> (raw)
In-Reply-To: <CAMV_pUbBCkX6NME1c4NG-e48c0Vcs48N8JDYaDQqqypC0VjmDw@mail.gmail.com>
On Wed, 23 Aug 2017, Abhisit Sangjan wrote:
> > > From: Abhisit Sangjan <s.abhisit@gmail.com>
> > >
> > > TI LMP92001 Analog System Monitor and Controller
[...]
> > > Signed-off-by: Abhisit Sangjan <s.abhisit@gmail.com>
> > > ---
> > > Documentation/ABI/testing/sysfs-bus-iio-lmp920001 | 92 ++++
> > > .../devicetree/bindings/gpio/gpio-lmp92001.txt | 22 +
> > > .../bindings/iio/adc/ti-lmp92001-adc.txt | 21 +
> > > .../bindings/iio/dac/ti-lmp92001-dac.txt | 35 ++
> > > drivers/gpio/Kconfig | 7 +
> > > drivers/gpio/Makefile | 1 +
> > > drivers/gpio/gpio-lmp92001.c | 209 +++++++++
> > > drivers/iio/adc/Kconfig | 10 +
> > > drivers/iio/adc/Makefile | 1 +
> > > drivers/iio/adc/lmp92001-adc.c | 500
> > +++++++++++++++++++++
> > > drivers/iio/dac/Kconfig | 9 +
> > > drivers/iio/dac/Makefile | 1 +
> > > drivers/iio/dac/lmp92001-dac.c | 390
> > ++++++++++++++++
> > > drivers/mfd/Kconfig | 12 +
> > > drivers/mfd/Makefile | 4 +
> > > drivers/mfd/lmp92001-core.c | 308 +++++++++++++
> > > drivers/mfd/lmp92001-debug.c | 67 +++
> > > drivers/mfd/lmp92001-i2c.c | 215 +++++++++
> > > include/linux/mfd/lmp92001/core.h | 119 +++++
> > > include/linux/mfd/lmp92001/debug.h | 28 ++
> > > 20 files changed, 2051 insertions(+)
> > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lmp920001
> > > create mode 100644 Documentation/devicetree/
> > bindings/gpio/gpio-lmp92001.txt
> > > create mode 100644 Documentation/devicetree/
> > bindings/iio/adc/ti-lmp92001-adc.txt
> > > create mode 100644 Documentation/devicetree/
> > bindings/iio/dac/ti-lmp92001-dac.txt
> > > create mode 100644 drivers/gpio/gpio-lmp92001.c
> > > create mode 100644 drivers/iio/adc/lmp92001-adc.c
> > > create mode 100644 drivers/iio/dac/lmp92001-dac.c
> > > create mode 100644 drivers/mfd/lmp92001-core.c
> > > create mode 100644 drivers/mfd/lmp92001-debug.c
> > > create mode 100644 drivers/mfd/lmp92001-i2c.c
> > > create mode 100644 include/linux/mfd/lmp92001/core.h
> > > create mode 100644 include/linux/mfd/lmp92001/debug.h
[...]
> > > +struct lmp92001_gpio {
> > > + struct lmp92001 *lmp92001;
> > > + struct gpio_chip gpio_chip;
> > > +};
> > > +
> > > +static int lmp92001_gpio_get_direction(struct gpio_chip *chip,
> > unsigned offset)
> >
> > unsigned vs unsigned int
> >
>
> I am follow the function prototype, it is unsigned.
>
> struct gpio_chip {
> ...
> int (*get_direction)(struct gpio_chip *chip,
> unsigned offset);
> ...
> };
[...]
> > > +#ifdef CONFIG_DEBUG_FS
> > > +static void lmp92001_gpio_dbg_show(struct seq_file *s, struct gpio_chip
> > *chip)
> > > +{
> > > + struct lmp92001_gpio *lmp92001_gpio = gpiochip_get_data(chip);
> > > + struct lmp92001 *lmp92001 = lmp92001_gpio->lmp92001;
> > > + int i, gpio;
> > > + unsigned int cgpo;
> > > + const char *label, *dir, *logic;
> > > +
> > > + for (i = 0; i < chip->ngpio; i++) {
> > > + gpio = i + chip->base;
> > > +
> > > + label = gpiochip_is_requested(chip, i);
> > > + if (!label)
> > > + continue;
> > > +
> > > + regmap_read(lmp92001->regmap, LMP92001_CGPO, &cgpo);
> >
> > retval is not checked here (and elsewhere)
> >
>
> This function is return void.
Please clip your responses!
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-08-23 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 6:26 [PATCH] mfd: Add support for TI LMP92001 s.abhisit-Re5JQEeQqe8AvxtiuMwx3w
2017-08-22 7:36 ` Lee Jones
2017-08-22 14:27 ` Abhisit Sangjan
[not found] ` <1503383171-15515-1-git-send-email-s.abhisit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-22 7:37 ` Peter Meerwald-Stadler
[not found] ` <CAMV_pUbBCkX6NME1c4NG-e48c0Vcs48N8JDYaDQqqypC0VjmDw@mail.gmail.com>
2017-08-23 13:21 ` Lee Jones [this message]
2017-08-22 23:36 ` kbuild test robot
2017-08-22 14:03 ` Jonathan Cameron
2017-08-22 14:30 ` Abhisit Sangjan
2017-08-22 16:23 ` Lee Jones
2017-08-30 7:23 ` Abhisit Sangjan
2017-08-25 18:35 ` Rob Herring
2017-08-30 7:58 ` Abhisit Sangjan
2017-09-05 20:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823132149.svvvhtvrxv3fxhax@dell \
--to=lee.jones@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=s.abhisit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).