[PATCH v5 0/2] ZII RAVE platform driver

[PATCH v5 0/2] ZII RAVE platform driver

[Andrey Smirnov]

Greg,

I am not sure if you are the right person to send these to, if you are
not, please let me know who would be the appropriate recepient and sorry for the noise.

Thanks!


The orginal conver letter text follows:

Hi everyone,

This patch series is v4 of the driver for supervisory processor found
on RAVE series of devices from ZII. Supervisory processor is a PIC
microcontroller connected to various electrical subsystems on RAVE
devices whose firmware implements protocol to command/qery them.

Changes since [v4]:

    - Replaced usage of DEVICE_ATTR with DEVICE_ATTR_RW

    - Fixed a number of warnings produces by sparse tool

    - Incorporated event more feedback from Andy Shevchenko

    - Collected Reviewed-by from Andy

Changes since [v3]:

    - Re-collected lost Acked-by from Rob

    - Incorporated further feedback from Andy Shevchenko

    - Dropped useless change (stray newline) to drivers/mfd/Makefile

Changes since [v2]:

    - Fixed swapped command codes in rave_sp_common_get_boot_source()
      and rave_sp_common_set_boot_source() revealed by further testing
      of the code

    - Incorporated feedback from Andy Shevchenko

Changes since [v1]:

    - Updated wording in DT-bindings as per Rob's request.

    - Collected Rob's Acked-by for patch 2/2

NOTE:

 * The driver for "zii,rave-sp-watchdog" exists, but I haven't
   submitted it yet, becuase I wanted to make sure that API exposed by
   this MFD is acceptable and doesn't need drastic changes.

 * This driver is dependent on crc_ccitt_false() introduced in
   2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next'

Feedback is greatly appreciated!

Thanks,
Andrey Smirnov

[v4] lkml.kernel.org/r/20170725184450.13171-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
[v3] lkml.kernel.org/r/20170724150915.4824-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
[v2] lkml.kernel.org/r/20170718175604.11735-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
[v1] lkml.kernel.org/r/20170710170449.4544-1-andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org


Andrey Smirnov (2):
  platform: Add driver for RAVE Supervisory Processor
  dt-bindings: mfd: Add bindings for ZII RAVE devices

 .../devicetree/bindings/mfd/zii,rave-sp.txt        |   39 +
 drivers/platform/Kconfig                           |    2 +
 drivers/platform/Makefile                          |    1 +
 drivers/platform/rave/Kconfig                      |   26 +
 drivers/platform/rave/Makefile                     |    1 +
 drivers/platform/rave/rave-sp.c                    | 1127 ++++++++++++++++++++
 include/linux/rave-sp.h                            |   54 +
 7 files changed, 1250 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
 create mode 100644 drivers/platform/rave/Kconfig
 create mode 100644 drivers/platform/rave/Makefile
 create mode 100644 drivers/platform/rave/rave-sp.c
 create mode 100644 include/linux/rave-sp.h

-- 
2.13.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v5 2/2] dt-bindings: mfd: Add bindings for ZII RAVE devices

[Andrey Smirnov]

Cc: cphealy@gmail.com
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Acked-by: Rob Herring <robh+dt@kernel.org>
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 .../devicetree/bindings/mfd/zii,rave-sp.txt        | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/zii,rave-sp.txt

diff --git a/Documentation/devicetree/bindings/mfd/zii,rave-sp.txt b/Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
new file mode 100644
index 000000000000..088eff9ddb78
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
@@ -0,0 +1,39 @@
+Zodiac Inflight Innovations RAVE Supervisory Processor
+
+RAVE Supervisory Processor communicates with SoC over UART. It is
+expected that its Device Tree node is specified as a child of a node
+corresponding to UART controller used for communication.
+
+Required parent device properties:
+
+ - compatible: Should be one of:
+	- "zii,rave-sp-niu"
+	- "zii,rave-sp-mezz"
+	- "zii,rave-sp-esb"
+	- "zii,rave-sp-rdu1"
+	- "zii,rave-sp-rdu2"
+
+ - current-speed: Should be set to baud rate SP device is using
+
+RAVE SP consists of the following sub-devices:
+
+Device				 Description
+------				 -----------
+rave-sp-wdt			: Watchdog
+rave-sp-nvmem			: Interface to onborad EEPROM
+rave-sp-backlight		: Display backlight
+rave-sp-hwmon			: Interface to onboard hardware sensors
+rave-sp-leds			: Interface to onboard LEDs
+rave-sp-input			: Interface to onboard power button
+
+Example of usage:
+
+	rdu {
+		compatible = "zii,rave-sp-rdu2";
+		current-speed = <1000000>;
+
+		watchdog {
+			compatible = "zii,rave-sp-watchdog";
+		};
+	};
+
-- 
2.13.3

Re: [PATCH v5 2/2] dt-bindings: mfd: Add bindings for ZII RAVE devices

[Greg Kroah-Hartman]

On Fri, Jul 28, 2017 at 07:27:04AM -0700, Andrey Smirnov wrote:
> Cc: cphealy@gmail.com
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Acked-by: Rob Herring <robh+dt@kernel.org>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  .../devicetree/bindings/mfd/zii,rave-sp.txt        | 39 ++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/zii,rave-sp.txt

I can't take patches without any changelog text in them :(

Re: [PATCH v5 2/2] dt-bindings: mfd: Add bindings for ZII RAVE devices

[Andrey Smirnov]

On Mon, Aug 28, 2017 at 8:51 AM, Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
> On Fri, Jul 28, 2017 at 07:27:04AM -0700, Andrey Smirnov wrote:
>> Cc: cphealy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
>> Cc: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> Cc: Nikita Yushchenko <nikita.yoush-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Acked-by: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Acked-for-MFD-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  .../devicetree/bindings/mfd/zii,rave-sp.txt        | 39 ++++++++++++++++++++++
>>  1 file changed, 39 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
>
> I can't take patches without any changelog text in them :(

OK, will fix in v6.

Thanks,
Andrey Smirnov
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/2] ZII RAVE platform driver

[Greg Kroah-Hartman]

On Fri, Jul 28, 2017 at 07:27:02AM -0700, Andrey Smirnov wrote:
> Greg,
> 
> I am not sure if you are the right person to send these to, if you are
> not, please let me know who would be the appropriate recepient and sorry for the noise.

Why not the platform driver maintainer(s)?  Doesn't
scripts/get_maintainer.pl give you an idea for who to send them to?

thanks,

greg k-h

Re: [PATCH v5 0/2] ZII RAVE platform driver

[Andrey Smirnov]

On Fri, Jul 28, 2017 at 4:30 PM, Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
> On Fri, Jul 28, 2017 at 07:27:02AM -0700, Andrey Smirnov wrote:
>> Greg,
>>
>> I am not sure if you are the right person to send these to, if you are
>> not, please let me know who would be the appropriate recepient and sorry for the noise.
>
> Why not the platform driver maintainer(s)?  Doesn't
> scripts/get_maintainer.pl give you an idea for who to send them to?

Unfortunately I wasn't able to find anyone in MAINTAINERS and running
scripts/get_maintainer.pl on the patch returns only:

scripts/get_maintainer.pl
v5-0001-platform-Add-driver-for-RAVE-Supervisory-Processo.patch
Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
(commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,added_lines:1/1=100%,added_lines:26/26=100%,added_lines:1127/1127=100%,added_lines:54/54=100%)
Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (commit_signer:1/1=100%)
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)

hence me reaching out to you.

Thanks,
Andrey Smirnov
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/2] ZII RAVE platform driver

[Andrey Smirnov]

On Fri, Jul 28, 2017 at 5:07 PM, Andrey Smirnov
<andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Fri, Jul 28, 2017 at 4:30 PM, Greg Kroah-Hartman
> <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
>> On Fri, Jul 28, 2017 at 07:27:02AM -0700, Andrey Smirnov wrote:
>>> Greg,
>>>
>>> I am not sure if you are the right person to send these to, if you are
>>> not, please let me know who would be the appropriate recepient and sorry for the noise.
>>
>> Why not the platform driver maintainer(s)?  Doesn't
>> scripts/get_maintainer.pl give you an idea for who to send them to?
>
> Unfortunately I wasn't able to find anyone in MAINTAINERS and running
> scripts/get_maintainer.pl on the patch returns only:
>
> scripts/get_maintainer.pl
> v5-0001-platform-Add-driver-for-RAVE-Supervisory-Processo.patch
> Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,added_lines:1/1=100%,added_lines:26/26=100%,added_lines:1127/1127=100%,added_lines:54/54=100%)
> Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (commit_signer:1/1=100%)
> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
>
> hence me reaching out to you.

Greg, did you have any chance to consider this? I have a v6 with a fix
for build break reported by kbuild test robot, and I want to avoid
spamming the mailing list too much and send it to an appropriate
person.

Thanks,
Andrey Smirnov
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/2] ZII RAVE platform driver

[Greg Kroah-Hartman]

On Wed, Aug 02, 2017 at 01:31:51PM -0700, Andrey Smirnov wrote:
> On Fri, Jul 28, 2017 at 5:07 PM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
> > On Fri, Jul 28, 2017 at 4:30 PM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> >> On Fri, Jul 28, 2017 at 07:27:02AM -0700, Andrey Smirnov wrote:
> >>> Greg,
> >>>
> >>> I am not sure if you are the right person to send these to, if you are
> >>> not, please let me know who would be the appropriate recepient and sorry for the noise.
> >>
> >> Why not the platform driver maintainer(s)?  Doesn't
> >> scripts/get_maintainer.pl give you an idea for who to send them to?
> >
> > Unfortunately I wasn't able to find anyone in MAINTAINERS and running
> > scripts/get_maintainer.pl on the patch returns only:
> >
> > scripts/get_maintainer.pl
> > v5-0001-platform-Add-driver-for-RAVE-Supervisory-Processo.patch
> > Andrey Smirnov <andrew.smirnov@gmail.com>
> > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,added_lines:1/1=100%,added_lines:26/26=100%,added_lines:1127/1127=100%,added_lines:54/54=100%)
> > Andy Shevchenko <andy.shevchenko@gmail.com> (commit_signer:1/1=100%)
> > linux-kernel@vger.kernel.org (open list)
> >
> > hence me reaching out to you.
> 
> Greg, did you have any chance to consider this? I have a v6 with a fix
> for build break reported by kbuild test robot, and I want to avoid
> spamming the mailing list too much and send it to an appropriate
> person.

$ mdfrm -c ~/mail/todo/
944 messages in /home/gregkh/mail/todo/

Please be patient if you are waiting for a review from me, my queue is
kind of big...

greg k-h

Re: [PATCH v5 0/2] ZII RAVE platform driver

[Greg Kroah-Hartman]

On Wed, Aug 02, 2017 at 04:03:34PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 02, 2017 at 01:31:51PM -0700, Andrey Smirnov wrote:
> > On Fri, Jul 28, 2017 at 5:07 PM, Andrey Smirnov
> > <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > > On Fri, Jul 28, 2017 at 4:30 PM, Greg Kroah-Hartman
> > > <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
> > >> On Fri, Jul 28, 2017 at 07:27:02AM -0700, Andrey Smirnov wrote:
> > >>> Greg,
> > >>>
> > >>> I am not sure if you are the right person to send these to, if you are
> > >>> not, please let me know who would be the appropriate recepient and sorry for the noise.
> > >>
> > >> Why not the platform driver maintainer(s)?  Doesn't
> > >> scripts/get_maintainer.pl give you an idea for who to send them to?
> > >
> > > Unfortunately I wasn't able to find anyone in MAINTAINERS and running
> > > scripts/get_maintainer.pl on the patch returns only:
> > >
> > > scripts/get_maintainer.pl
> > > v5-0001-platform-Add-driver-for-RAVE-Supervisory-Processo.patch
> > > Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,added_lines:1/1=100%,added_lines:26/26=100%,added_lines:1127/1127=100%,added_lines:54/54=100%)
> > > Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (commit_signer:1/1=100%)
> > > linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
> > >
> > > hence me reaching out to you.
> > 
> > Greg, did you have any chance to consider this? I have a v6 with a fix
> > for build break reported by kbuild test robot, and I want to avoid
> > spamming the mailing list too much and send it to an appropriate
> > person.

As I can't do anything with v5, please send v6, never wait for me...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html