From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 17/17] ARM: dts: Add missing hwmod related properties for dra7 Date: Mon, 28 Aug 2017 14:37:53 -0700 Message-ID: <20170828213753.GP6008@atomide.com> References: <20170828211918.11573-1-tony@atomide.com> <20170828211918.11573-18-tony@atomide.com> <8c0ecbf6-26fb-1998-6bb5-0a74d9daa2ab@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <8c0ecbf6-26fb-1998-6bb5-0a74d9daa2ab-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nishanth Menon Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J . Wysocki" , Tero Kristo List-Id: devicetree@vger.kernel.org * Nishanth Menon [170828 14:35]: > On 08/28/2017 04:19 PM, Tony Lindgren wrote: > > On dra7 we're missing the smartreflex and hdq nodes with their > > related "ti,hwmods" property that the SoC interconnect code needs. > > > > Note that this will only show up as a bug with "doesn't have > > mpu register target base" boot errors when the legacy platform > > data is removed. > > > > Note that the related driver also needs to be updated to probe > > using device tree and get the platform data passed to it using > > auxdata with arch/arm/mach-omap2/pdata-quirks.c. > > > > Let's also update the related binding documentation while at it. ... > > @@ -1489,6 +1497,18 @@ > > }; > > }; > > + smartreflex_core: smartreflex4a0dd000 { > > + compatible = "ti,dra7-smartreflex-core"; > > + ti,hwmods = "smartreflex_core"; > > + reg = <0x4a0dd000 0x80>; > > + }; > > + > > + smartreflex_mpu: smartreflex@4a0d9000 { > > + compatible = "ti,dra7-smartreflex-mpu"; > > + ti,hwmods = "smartreflex_mpu"; > > + reg = <0x4a0d9000 0x80>; > > + }; > > > Have you checked TRM for these? > http://www.ti.com/lit/ug/sprui30d/sprui30d.pdf > > These are disabled on the SoC and marked as reserved. Then why do we still have legacy hwmod data for them? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html