From: David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>
To: icenowy-h8G6r0blFSE@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
David Disseldorp <ddiss-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH] arm: sun8i: nanopi-neo: Enable USB OTG
Date: Tue, 29 Aug 2017 01:41:40 +0200 [thread overview]
Message-ID: <20170829014140.469b1bf7@suse.de> (raw)
In-Reply-To: <46910aa6a3f08e1628a5a23fb7751a61-h8G6r0blFSE@public.gmane.org>
On Mon, 28 Aug 2017 10:37:56 +0800, icenowy-h8G6r0blFSE@public.gmane.org wrote:
> 在 2017-08-28 08:12，David Disseldorp 写道：
> > From: David Disseldorp <ddiss-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> >
> > The NanoPi NEO features a MicroUSB port that can work in both host mode
> > and peripheral mode. Switching is handled via GPIO PG12.
>
> How's the Vbus of the OTG handled?
I don't know. Unlike the NanoPi NEO2[2], the NanoPi NEO schematics[1]
don't show a regulator connected to the Vbus pin. I've tested this
change with USB device mode only.
> > Signed-off-by: David Disseldorp <ddiss-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> > ---
> > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 27
> > +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
> > b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
> > index 78f6c24952dd..5abf430ac5a6 100644
> > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
> > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
> > @@ -47,9 +47,36 @@
> > compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
> > };
> >
> > +&ehci0 {
> > + status = "okay";
> > +};
> > +
> > +&ehci3 {
> > + status = "okay";
> > +};
>
> Why do you also enable ehci/ohci3 here?
> I think they're already enabled in sun8i-h3-nanopi.dtsi .
You're right. I'll drop the duplication here.
Cheers, David
1. NanoPi NEO schematics
http://wiki.friendlyarm.com/wiki/images/1/1c/NanoPi-NEO-V1.2-1608-Schematic.pdf
2. NanoPi NEO2 schematics
http://wiki.friendlyarm.com/wiki/images/a/a1/Schematic_NanoPi_NEO2-v1.0_1701.pdf
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-08-28 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 0:12 [PATCH] arm: sun8i: nanopi-neo: Enable USB OTG David Disseldorp
[not found] ` <20170828001251.8440-1-ddiss-l3A5Bk7waGM@public.gmane.org>
2017-08-28 2:37 ` icenowy-h8G6r0blFSE
[not found] ` <46910aa6a3f08e1628a5a23fb7751a61-h8G6r0blFSE@public.gmane.org>
2017-08-28 23:41 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829014140.469b1bf7@suse.de \
--to=ddiss-l3a5bk7wagm@public.gmane.org \
--cc=ddiss-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-h8G6r0blFSE@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).