Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for omap4

[Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2905 bytes --]

Hi,

On Mon, Aug 28, 2017 at 02:19:15PM -0700, Tony Lindgren wrote:
> On omap4 we're missing the PowerVR SGX GPU node with it's related
> "ti,hwmods" property that the SoC interconnect code needs.
> 
> Note that this will only show up as a bug with "doesn't have
> mpu register target base" boot errors when the legacy platform
> data is removed.
> 
> Cc: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---

I think OMAP3 & OMAP5 should also be documented and getting a
node in this series?

-- Sebastian

>  .../devicetree/bindings/gpu/ti-powervr-sgx.txt     | 34 ++++++++++++++++++++++
>  arch/arm/boot/dts/omap4.dtsi                       |  7 +++++
>  2 files changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpu/ti-powervr-sgx.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpu/ti-powervr-sgx.txt b/Documentation/devicetree/bindings/gpu/ti-powervr-sgx.txt
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/ti-powervr-sgx.txt
> @@ -0,0 +1,34 @@
> +Texas Instruments PowevVR SGX binding
> +
> +SGX can be used for graphics acceleration on Texas Instruments SoCs.
> +
> +Note that the SGX binding is currently only used by the SoC interconnect
> +code to idle the module on init and no open source driver is available
> +for SGX. Please update this documentation if that changes.
> +
> +Required properties:
> +
> +compatible: Shall be one of the following:
> +	    "ti,omap4-gpu"
> +
> +reg: Shall contain the device instance IO range
> +
> +interrupts: Shall contain the device instance interrupt
> +
> +
> +Optional properties:
> +
> +reg-names: Shall contain the IO range names if multiple IO
> +	   ranges are used by the SoC
> +
> +ti,hwmods: Shall contain the TI interconnect module name if needed
> +	   by the SoC
> +
> +
> +Example:
> +	gpu: gpu@56000000 {
> +		compatible = "ti,omap4-gpu";
> +		reg = <0x56000000 0x10000>;
> +		interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +		ti,hwmods = "gpu";
> +	};
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -1086,6 +1086,13 @@
>  			status = "disabled";
>  		};
>  
> +		gpu: gpu@56000000 {
> +			compatible = "ti,omap4-gpu";
> +			reg = <0x56000000 0x10000>;
> +			interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			ti,hwmods = "gpu";
> +		};
> +
>  		dss: dss@58000000 {
>  			compatible = "ti,omap4-dss";
>  			reg = <0x58000000 0x80>;
> -- 
> 2.14.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]