From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Sebastian Reichel
<sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4
Date: Tue, 29 Aug 2017 07:20:30 -0700 [thread overview]
Message-ID: <20170829142029.GS6008@atomide.com> (raw)
In-Reply-To: <20170829091825.aye2ulcurnhs24uw@earth>
* Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> [170829 02:18]:
> Hi,
>
> On Mon, Aug 28, 2017 at 02:19:09PM -0700, Tony Lindgren wrote:
> > On omap4 we're missing the hsi node with it's related "ti,hwmods"
> > property that the SoC interconnect code needs.
> >
> > Note that this will only show up as a bug with "doesn't have
> > mpu register target base" boot errors when the legacy platform
> > data is removed.
> >
> > Let's also update the binding accrodingly while at it.
> >
> > Cc: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> > ---
> > Documentation/devicetree/bindings/hsi/omap-ssi.txt | 6 +++++-
> > arch/arm/boot/dts/omap4.dtsi | 9 +++++++++
> > 2 files changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/hsi/omap-ssi.txt b/Documentation/devicetree/bindings/hsi/omap-ssi.txt
> > --- a/Documentation/devicetree/bindings/hsi/omap-ssi.txt
> > +++ b/Documentation/devicetree/bindings/hsi/omap-ssi.txt
> > @@ -4,7 +4,7 @@ OMAP Synchronous Serial Interface (SSI) controller implements a legacy
> > variant of MIPI's High Speed Synchronous Serial Interface (HSI).
> >
> > Required properties:
> > -- compatible: Should include "ti,omap3-ssi".
> > +- compatible: Should include "ti,omap3-ssi" or "ti,omap4-hsi"
> > - reg-names: Contains the values "sys" and "gdd" (in this order).
> > - reg: Contains a matching register specifier for each entry
> > in reg-names.
> > @@ -38,6 +38,10 @@ Required Port sub-node properties:
> > property. If it's missing the port will not be
> > enabled.
> >
> > +Optional properties:
> > +- ti,hwmods: Shall contain TI interconnect module name if needed
> > + by the SoC
> > +
> > Example for Nokia N900:
> >
> > ssi-controller@48058000 {
> > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> > --- a/arch/arm/boot/dts/omap4.dtsi
> > +++ b/arch/arm/boot/dts/omap4.dtsi
> > @@ -632,6 +632,15 @@
> > dma-names = "tx", "rx";
> > };
> >
> > + hsi: hsi@4a058000 {
> > + compatible = "ti,omap4-hsi";
> > + reg = <0x4a058000 0x4000>;
> > + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> > + ti,hwmods = "hsi";
> > + };
> > +
>
> This does not follow the binding, which expects one subnode per
> port and splits memory areas + interrupts accordingly. Fortunately
> HSI is properly documented in the public OMAP4 TRM (in opposit to
> SSI, which is missing completly in OMAP3 TRM). I think the node
> should look like this:
OK sure let's add the subnodes too :)
> hsi: hsi@4a058000 {
> compatible = "ti,omap4-hsi";
> ti,hwmods = "hsi";
>
> reg = <0x4a058000 0x5000>,
> <0x4a058000 0x1000>;
> reg-names = "sys", "gdd";
The module size is 0x4000 in the hardware. Then there's the L4
interconnect registers at 0x5c000 0x1000:
reg = <0x4a058000 0x4000>,
<0x4a05c000 0x1000>;
reg-names = "sys", "gdd";
Hmm, what's the "gdd" name for? Probably it would be be to use "ta"
there for "target agent" as that's generic and available for every
module.
> clocks = <&hsi_fck>;
> clock-names = "hsi_fck";
>
> interrupts = <71>;
> interrupt-names = "gdd_mpu";
And the interrupts need to be mapped for omap4. I'll post
v2 with the subnodes.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-29 14:20 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 21:19 [PATCH 00/17] Fix missing device tree hwmods and IO ranges omap variants Tony Lindgren
[not found] ` <20170828211918.11573-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-28 21:19 ` [PATCH 01/17] ARM: dts: Add missing dma hwmods property for omap3 Tony Lindgren
2017-08-28 21:19 ` [PATCH 02/17] ARM: dts: Configure pmu without interrupt for omap4430 Tony Lindgren
2017-08-28 21:19 ` [PATCH 03/17] ARM: dts: Add missing properties for omap4 control modules Tony Lindgren
2017-08-28 21:19 ` [PATCH 04/17] ARM: dts: Add missing hwmods property for omap4 dma Tony Lindgren
2017-08-28 21:19 ` [PATCH 05/17] ARM: dts: Add missing smartreflex node and binding for omap4 Tony Lindgren
2017-08-28 21:19 ` [PATCH 06/17] ARM: dts: Add missing slimbus " Tony Lindgren
2017-08-28 21:19 ` [PATCH 07/17] ARM: dts: Add missing onewire node " Tony Lindgren
2017-08-28 21:19 ` [PATCH 08/17] ARM: dts: Add missing hsi " Tony Lindgren
[not found] ` <20170828211918.11573-9-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 9:18 ` Sebastian Reichel
2017-08-29 14:20 ` Tony Lindgren [this message]
2017-08-28 21:19 ` [PATCH 09/17] ARM: dts: Add missing iss node and binding " Tony Lindgren
[not found] ` <20170828211918.11573-10-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 12:37 ` Laurent Pinchart
2017-08-29 14:22 ` Tony Lindgren
2017-08-28 21:19 ` [PATCH 10/17] ARM: dts: Add missing wdt3 node " Tony Lindgren
2017-08-28 21:19 ` [PATCH 11/17] ARM: dts: Add missing mcasp " Tony Lindgren
[not found] ` <20170828211918.11573-12-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-09-04 6:55 ` Peter Ujfalusi
2017-08-28 21:19 ` [PATCH 12/17] ARM: dts: Add missing aess node and binding " Tony Lindgren
2017-08-28 21:19 ` [PATCH 13/17] ARM: dts: Add missing fdif " Tony Lindgren
[not found] ` <20170828211918.11573-14-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 12:48 ` Laurent Pinchart
2017-08-29 14:29 ` Tony Lindgren
[not found] ` <20170829142941.GU6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 17:13 ` Laurent Pinchart
2017-08-29 19:01 ` Tony Lindgren
2017-08-28 21:19 ` [PATCH 14/17] ARM: dts: Add missing gpu " Tony Lindgren
[not found] ` <20170828211918.11573-15-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 9:00 ` Sebastian Reichel
2017-08-29 11:35 ` Tomi Valkeinen
[not found] ` <201708291135.v7TBZCHH020827-mYkuYio3Bc71T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2017-08-29 12:10 ` Sebastian Reichel
2017-08-29 12:24 ` Tomi Valkeinen
[not found] ` <e0c6447f-5a0f-b43a-7087-5ee37af2a1c1-l0cyMroinI0@public.gmane.org>
2017-08-29 14:34 ` Tony Lindgren
[not found] ` <20170829143453.GV6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 15:57 ` Tony Lindgren
[not found] ` <20170829155738.GB6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 16:26 ` Tony Lindgren
2017-08-29 12:27 ` Tomi Valkeinen
[not found] ` <5efc9078-5886-5826-834e-facd67ddfbe5-l0cyMroinI0@public.gmane.org>
2017-08-29 14:37 ` Tony Lindgren
2017-08-29 14:42 ` Tony Lindgren
[not found] ` <20170829144205.GX6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-29 15:31 ` Adam Ford
[not found] ` <CAHCN7xK7Vy8Hw1OV3AQb4vAo3n=6qfE_8xunL1MXQaTLY0Yy4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-29 15:35 ` Tony Lindgren
2017-08-28 21:19 ` [PATCH 15/17] ARM: dts: Add missing dma hwmod property for omap5 Tony Lindgren
2017-08-28 21:19 ` [PATCH 16/17] ARM: dts: Add missing hwmod related nodes for am33xx Tony Lindgren
2017-08-28 21:19 ` [PATCH 17/17] ARM: dts: Add missing hwmod related properties for dra7 Tony Lindgren
[not found] ` <20170828211918.11573-18-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-28 21:34 ` Nishanth Menon
[not found] ` <8c0ecbf6-26fb-1998-6bb5-0a74d9daa2ab-l0cyMroinI0@public.gmane.org>
2017-08-28 21:37 ` Tony Lindgren
[not found] ` <20170828213753.GP6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-28 21:52 ` Nishanth Menon
[not found] ` <fd064c10-2051-1579-bde1-60c3fed2b4a0-l0cyMroinI0@public.gmane.org>
2017-08-28 22:27 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2017-08-30 15:19 [PATCHv2 00/17] Fix missing device tree hwmods and IO ranges omap variants Tony Lindgren
[not found] ` <20170830151953.30856-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-30 15:19 ` [PATCH 08/17] ARM: dts: Add missing hsi node for omap4 Tony Lindgren
[not found] ` <20170830151953.30856-9-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-08-30 19:37 ` Sebastian Reichel
2017-08-30 20:25 ` Tony Lindgren
[not found] ` <20170830202519.GI6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-01 15:25 ` Sebastian Reichel
2017-10-01 16:47 ` Tony Lindgren
2017-09-11 21:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829142029.GS6008@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).