devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Chris Paterson <chris.paterson2@renesas.com>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH ] ARM: dts: iwg22d-sodimm: Add Ethernet AVB support
Date: Thu, 31 Aug 2017 10:45:34 +0200	[thread overview]
Message-ID: <20170831084534.GF29946@verge.net.au> (raw)
In-Reply-To: <1504106234-41450-1-git-send-email-biju.das@bp.renesas.com>

On Wed, Aug 30, 2017 at 04:17:14PM +0100, Biju Das wrote:
> Define the iWave RainboW-G22D board dependent part of the Ethernet
> AVB device node.
> 
> On some older versions of the platform (before R4.0) the phy address
> may be 1 or 3. The address is fixed to 3 for R4.0 onwards (which
> will be the first mainstream release), hence using 3 in the dts.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
> This patch is tested against renesas-dev tag 20170830-v4.13-rc7
> 
>  arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> index 442a5cb..aac84c6 100644
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -17,9 +17,11 @@
>  
>  	aliases {
>  		serial0 = &scif4;
> +		ethernet0 = &avb;
>  	};
>  
>  	chosen {
> +		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
>  		stdout-path = "serial0:115200n8";
>  	};
>  };
> @@ -29,6 +31,11 @@
>  		groups = "scif4_data_b";
>  		function = "scif4";
>  	};
> +
> +	avb_pins: avb {
> +		groups = "avb_mdio", "avb_gmii";
> +		function = "avb";
> +	};
>  };
>  
>  &scif4 {
> @@ -37,3 +44,22 @@
>  
>  	status = "okay";
>  };
> +
> +&avb {
> +	pinctrl-0 = <&avb_pins>;
> +	pinctrl-names = "default";
> +
> +	phy-handle = <&phy3>;
> +	phy-mode = "gmii";
> +	renesas,no-ether-link;
> +	status = "okay";
> +
> +	phy3: ethernet-phy@3 {
> +	/*
> +	 * On some older versions of the platform (before R4.0) the phy address
> +	 * may be 1 or 3. The address is fixed to 3 for R4.0 onwards.
> +	 */
> +		reg = <3>;
> +		micrel,led-mode = <1>;

Does the phy have an interrupt?

> +	};
> +};
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-08-31  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 15:17 [PATCH ] ARM: dts: iwg22d-sodimm: Add Ethernet AVB support Biju Das
2017-08-31  8:45 ` Simon Horman [this message]
     [not found]   ` <20170831084534.GF29946-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-08-31  9:24     ` Biju Das
2017-08-31  9:32       ` Chris Paterson
     [not found]         ` <TY1PR06MB07029D315FC6EE500D1EEA55B79D0-/PRLmSCtZ14u2TXDOttQZW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-01  8:49           ` Simon Horman
2017-09-01  9:30             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831084534.GF29946@verge.net.au \
    --to=horms@verge.net.au \
    --cc=biju.das@bp.renesas.com \
    --cc=chris.paterson2@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).