devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] arm64: Realtek RTD1295 watchdog
@ 2017-09-04 23:15 Andreas Färber
  2017-09-04 23:16 ` [PATCH v2 1/3] dt-bindings: watchdog: Add Realtek RTD1295 Andreas Färber
  2017-09-04 23:16 ` [PATCH v2 3/3] arm64: dts: realtek: Add watchdog node for RTD1295 Andreas Färber
  0 siblings, 2 replies; 5+ messages in thread
From: Andreas Färber @ 2017-09-04 23:15 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Roc He,
	蒋丽琴, Andreas Färber,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Hello,

This series adds the watchdog for the Realtek RTD1295 SoC.

v2 does minor cleanups.

The implementation is based on register offsets seen in the vendor DT,
as well as older mach-rtk119x code published by QNAP.

The DT node depends on my RTD1295 clk series.

More experimental patches at:
https://github.com/afaerber/linux/commits/rtd1295-next

Have a lot of fun!

Cheers,
Andreas

v1 -> v2:
* Prepared remove (Guenther)
* Set timeout field (Guenther)
* Cleanups (Guenther, Andreas)

Cc: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Roc He <hepeng-qoVzM6YEWSw@public.gmane.org>
Cc: 蒋丽琴 <jiang.liqin-31gW8twSeR21Z/+hSey0Gg@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Andreas Färber (3):
  dt-bindings: watchdog: Add Realtek RTD1295
  watchdog: Add Realtek RTD1295
  arm64: dts: realtek: Add watchdog node for RTD1295

 .../bindings/watchdog/realtek,rtd119x.txt          |  17 +++
 arch/arm64/boot/dts/realtek/rtd1295.dtsi           |   6 +
 drivers/watchdog/Kconfig                           |  10 ++
 drivers/watchdog/Makefile                          |   1 +
 drivers/watchdog/rtd119x_wdt.c                     | 168 +++++++++++++++++++++
 5 files changed, 202 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
 create mode 100644 drivers/watchdog/rtd119x_wdt.c

-- 
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/3] dt-bindings: watchdog: Add Realtek RTD1295
  2017-09-04 23:15 [PATCH v2 0/3] arm64: Realtek RTD1295 watchdog Andreas Färber
@ 2017-09-04 23:16 ` Andreas Färber
  2017-09-10 15:17   ` Guenter Roeck
  2017-09-04 23:16 ` [PATCH v2 3/3] arm64: dts: realtek: Add watchdog node for RTD1295 Andreas Färber
  1 sibling, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2017-09-04 23:16 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, linux-watchdog, linux-arm-kernel
  Cc: linux-kernel, Roc He, 蒋丽琴,
	Andreas Färber, Rob Herring, Mark Rutland, devicetree

Add a binding for the Realtek RTD1295 watchdog.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v1 -> v2: Unchanged
 
 .../devicetree/bindings/watchdog/realtek,rtd119x.txt    | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt

diff --git a/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
new file mode 100644
index 000000000000..05653054bd5b
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
@@ -0,0 +1,17 @@
+Realtek RTD1295 Watchdog
+========================
+
+Required properties:
+
+- compatible :  Should be "realtek,rtd1295-watchdog"
+- reg        :  Specifies the physical base address and size of registers
+- clocks     :  Specifies one clock input
+
+
+Example:
+
+	watchdog@98007680 {
+		compatible = "realtek,rtd1295-watchdog";
+		reg = <0x98007680 0x100>;
+		clocks = <&osc27M>;
+	};
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 3/3] arm64: dts: realtek: Add watchdog node for RTD1295
  2017-09-04 23:15 [PATCH v2 0/3] arm64: Realtek RTD1295 watchdog Andreas Färber
  2017-09-04 23:16 ` [PATCH v2 1/3] dt-bindings: watchdog: Add Realtek RTD1295 Andreas Färber
@ 2017-09-04 23:16 ` Andreas Färber
       [not found]   ` <20170904231602.29787-4-afaerber-l3A5Bk7waGM@public.gmane.org>
  1 sibling, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2017-09-04 23:16 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, linux-watchdog, linux-arm-kernel
  Cc: Mark Rutland, devicetree, Roc He, 蒋丽琴,
	Catalin Marinas, Will Deacon, linux-kernel, Rob Herring,
	Andreas Färber

Add the watchdog node to the RTD1295 Device Tree.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 Depends on the pending clock nodes patch.
 
 v1 -> v2: Unchanged
 
 arch/arm64/boot/dts/realtek/rtd1295.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/realtek/rtd1295.dtsi b/arch/arm64/boot/dts/realtek/rtd1295.dtsi
index fbbd6456079e..f39ab63f879d 100644
--- a/arch/arm64/boot/dts/realtek/rtd1295.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd1295.dtsi
@@ -123,6 +123,12 @@
 			#interrupt-cells = <1>;
 		};
 
+		watchdog@98007680 {
+			compatible = "realtek,rtd1295-watchdog";
+			reg = <0x98007680 0x100>;
+			clocks = <&osc27M>;
+		};
+
 		uart0: serial@98007800 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x98007800 0x400>;
-- 
2.13.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: watchdog: Add Realtek RTD1295
  2017-09-04 23:16 ` [PATCH v2 1/3] dt-bindings: watchdog: Add Realtek RTD1295 Andreas Färber
@ 2017-09-10 15:17   ` Guenter Roeck
  0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2017-09-10 15:17 UTC (permalink / raw)
  To: Andreas Färber, Wim Van Sebroeck, linux-watchdog,
	linux-arm-kernel
  Cc: linux-kernel, Roc He, 蒋丽琴, Rob Herring,
	Mark Rutland, devicetree

On 09/04/2017 04:16 PM, Andreas Färber wrote:
> Add a binding for the Realtek RTD1295 watchdog.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   v1 -> v2: Unchanged
>   
>   .../devicetree/bindings/watchdog/realtek,rtd119x.txt    | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
> new file mode 100644
> index 000000000000..05653054bd5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/realtek,rtd119x.txt
> @@ -0,0 +1,17 @@
> +Realtek RTD1295 Watchdog
> +========================
> +
> +Required properties:
> +
> +- compatible :  Should be "realtek,rtd1295-watchdog"
> +- reg        :  Specifies the physical base address and size of registers
> +- clocks     :  Specifies one clock input
> +
> +
> +Example:
> +
> +	watchdog@98007680 {
> +		compatible = "realtek,rtd1295-watchdog";
> +		reg = <0x98007680 0x100>;
> +		clocks = <&osc27M>;
> +	};
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 3/3] arm64: dts: realtek: Add watchdog node for RTD1295
       [not found]   ` <20170904231602.29787-4-afaerber-l3A5Bk7waGM@public.gmane.org>
@ 2017-09-10 15:18     ` Guenter Roeck
  0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2017-09-10 15:18 UTC (permalink / raw)
  To: Andreas Färber, Wim Van Sebroeck,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Roc He,
	蒋丽琴, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA

On 09/04/2017 04:16 PM, Andreas Färber wrote:
> Add the watchdog node to the RTD1295 Device Tree.
> 
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>

Acked-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>

> ---
>   Depends on the pending clock nodes patch.
>   
>   v1 -> v2: Unchanged
>   
>   arch/arm64/boot/dts/realtek/rtd1295.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/realtek/rtd1295.dtsi b/arch/arm64/boot/dts/realtek/rtd1295.dtsi
> index fbbd6456079e..f39ab63f879d 100644
> --- a/arch/arm64/boot/dts/realtek/rtd1295.dtsi
> +++ b/arch/arm64/boot/dts/realtek/rtd1295.dtsi
> @@ -123,6 +123,12 @@
>   			#interrupt-cells = <1>;
>   		};
>   
> +		watchdog@98007680 {
> +			compatible = "realtek,rtd1295-watchdog";
> +			reg = <0x98007680 0x100>;
> +			clocks = <&osc27M>;
> +		};
> +
>   		uart0: serial@98007800 {
>   			compatible = "snps,dw-apb-uart";
>   			reg = <0x98007800 0x400>;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-09-10 15:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-04 23:15 [PATCH v2 0/3] arm64: Realtek RTD1295 watchdog Andreas Färber
2017-09-04 23:16 ` [PATCH v2 1/3] dt-bindings: watchdog: Add Realtek RTD1295 Andreas Färber
2017-09-10 15:17   ` Guenter Roeck
2017-09-04 23:16 ` [PATCH v2 3/3] arm64: dts: realtek: Add watchdog node for RTD1295 Andreas Färber
     [not found]   ` <20170904231602.29787-4-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-09-10 15:18     ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).