From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v5] arm64: allwinner: h5: add support for NanoPi NEO Plus2 Date: Tue, 5 Sep 2017 13:04:52 +0200 Message-ID: <20170905110452.fa6l6x3jrrdod7b7@flea> References: <20170824231716.2623-1-antony@phenome.org> <20170830125057.38529-1-antony@phenome.org> <20170831145859.rief3fqo36ns23rm@flea> <20170901105313.m26y2re3ulskua43@AntonyAntony.local> <20170904082732.g2q2tjd6qlvhaea7@flea> <20170904142619.zq4x2l2qwtpukdc7@AntonyAntony.local> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6estbauo2z4lk3ai" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170904142619.zq4x2l2qwtpukdc7-sIi4olfLYEDaK4aX9S0K76zUEOm+Xw19@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Antony Antony Cc: Chen-Yu Tsai , Icenowy Zheng , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org --6estbauo2z4lk3ai Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Hi Antony, On Mon, Sep 04, 2017 at 04:26:19PM +0200, Antony Antony wrote: > On Mon, Sep 04, 2017 at 10:27:32AM +0200, Maxime Ripard wrote: > > On Fri, Sep 01, 2017 at 12:53:13PM +0200, Antony Antony wrote: > > > > > +&emac { > > > > > + pinctrl-names = "default"; > > > > > + pinctrl-0 = <&emac_rgmii_pins>; > > > > > + phy-supply = <®_gmac_3v3>; > > > > > + phy-handle = <&ext_rgmii_phy>; > > > > > + phy-mode = "rgmii"; > > > > > + status = "okay"; > > > > > +}; > > > > > + > > > > > +&mdio { > > > > > + ext_rgmii_phy: ethernet-phy@7 { > > > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > > > + reg = <7>; > > > > > + }; > > > > > +}; > > > > > > > > This will not compile. > > > > > > I don't understand you, because, v5 file compiled for me. Here is output > > > from running system, just the relevant part. using dtc -I fs > > > /proc/device-tree > > > > > > ext_rgmii_phy = "/soc/ethernet@1c30000/mdio/ethernet-phy@7"; > > > > > > ethernet@1c30000 { > > > mdio { > > > .. > > > ethernet-phy@7 { > > > compatible = "ethernet-phy-ieee802.3-c22"; > > > phandle = <0x1c>; > > > reg = <0x7>; > > > linux,phandle = <0x1c>; > > > }; > > > }; > > > > > > Is this what you expect? > > > > The bindings have been reverted recently, so if you based your work on > > a version between 4.13-rc1 and 4.13-rc6 it will work, but anything > > more recent will not compile anymore. > > I deleted emc and related node. > I see. I hope stmmac: sun8i come back soon. It works well well on this > board, running 4.13-rc6 Yeah, I hope too. Unfortunately, the DT bindings were still under discussion after it's been merged, so we couldn't guarantee their stability in the future. > > > > > +&usb_otg { > > > > > + dr_mode = "host"; > > > > > + status = "okay"; > > > > > +}; > > > > > + > > > > > +&usbphy { > > > > > + /* USB Type-A ports' VBUS is always on */ > > > > > + usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > > > > > > > > If it has an ID-detect pin, then it's not a host-only USB OTG > > > > controller. dr_mode should be set to otga > > > > > > good point. I don't see an ID-detect connected in the schematic. The > > > previous generation had. > > > > > > I will leave > > > &usb_otg { > > > dr_mode = "host"; > > > status = "okay"; > > > }; > > > > > > &usbphy { > > > /* USB Type-A ports' VBUS is always on */ > > > status = "okay"; > > > }; > > > > Looking at the schematics, it seems that the micro USB isn't even > > wired to a bus but is only used to power the board. If so, you can > > even remove the usb_otg node. > > Yes, the Micro USB data pins are not connected. However, it there is a > second USB A port connected to the processor. If I remove &usb_otg node, in > 4.13-rc6, the second port goes to disabled. Ok, someone got creative :) Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --6estbauo2z4lk3ai--