From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se, robh@kernel.org,
hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org
Subject: [PATCH v8 03/21] v4l: async: Use more intuitive names for internal functions
Date: Tue, 5 Sep 2017 16:05:35 +0300 [thread overview]
Message-ID: <20170905130553.1332-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170905130553.1332-1-sakari.ailus@linux.intel.com>
Rename internal functions to make the names of the functions better
describe what they do.
Old name New name
v4l2_async_test_notify v4l2_async_match_notify
v4l2_async_belongs v4l2_async_find_match
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/v4l2-core/v4l2-async.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index f50a82767863..3d81ff6a496f 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -65,8 +65,8 @@ static LIST_HEAD(subdev_list);
static LIST_HEAD(notifier_list);
static DEFINE_MUTEX(list_lock);
-static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *notifier,
- struct v4l2_subdev *sd)
+static struct v4l2_async_subdev *v4l2_async_find_match(
+ struct v4l2_async_notifier *notifier, struct v4l2_subdev *sd)
{
bool (*match)(struct v4l2_subdev *, struct v4l2_async_subdev *);
struct v4l2_async_subdev *asd;
@@ -100,9 +100,9 @@ static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *
return NULL;
}
-static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
- struct v4l2_subdev *sd,
- struct v4l2_async_subdev *asd)
+static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,
+ struct v4l2_subdev *sd,
+ struct v4l2_async_subdev *asd)
{
int ret;
@@ -180,11 +180,11 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) {
int ret;
- asd = v4l2_async_belongs(notifier, sd);
+ asd = v4l2_async_find_match(notifier, sd);
if (!asd)
continue;
- ret = v4l2_async_test_notify(notifier, sd, asd);
+ ret = v4l2_async_match_notify(notifier, sd, asd);
if (ret < 0) {
mutex_unlock(&list_lock);
return ret;
@@ -241,9 +241,10 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd)
INIT_LIST_HEAD(&sd->async_list);
list_for_each_entry(notifier, ¬ifier_list, list) {
- struct v4l2_async_subdev *asd = v4l2_async_belongs(notifier, sd);
+ struct v4l2_async_subdev *asd = v4l2_async_find_match(notifier,
+ sd);
if (asd) {
- int ret = v4l2_async_test_notify(notifier, sd, asd);
+ int ret = v4l2_async_match_notify(notifier, sd, asd);
mutex_unlock(&list_lock);
return ret;
}
--
2.11.0
next prev parent reply other threads:[~2017-09-05 13:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 13:05 [PATCH v8 00/21] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 02/21] v4l: async: Remove re-probing support Sakari Ailus
2017-09-06 7:00 ` Hans Verkuil
2017-09-05 13:05 ` Sakari Ailus [this message]
2017-09-06 7:01 ` [PATCH v8 03/21] v4l: async: Use more intuitive names for internal functions Hans Verkuil
2017-09-08 12:40 ` Pavel Machek
2017-09-05 13:05 ` [PATCH v8 05/21] docs-rst: v4l: Include Qualcomm CAMSS in documentation build Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 06/21] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
[not found] ` <20170905130553.1332-7-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 7:41 ` Hans Verkuil
[not found] ` <dd3a2e55-8de0-c30e-04a7-cb26b519689c-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-07 7:34 ` Sakari Ailus
2017-09-07 8:51 ` Hans Verkuil
2017-09-07 9:58 ` Sakari Ailus
[not found] ` <20170907095850.m7mlag3tofwbj2jc-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-09-07 12:03 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 09/21] omap3isp: Fix check for our own sub-devices Sakari Ailus
[not found] ` <20170905130553.1332-10-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 7:45 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 12/21] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
[not found] ` <20170905130553.1332-13-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 7:50 ` Hans Verkuil
2017-09-07 7:51 ` Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 16/21] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
[not found] ` <20170905130553.1332-17-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 8:48 ` Hans Verkuil
[not found] ` <20170905130553.1332-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-05 13:05 ` [PATCH v8 01/21] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
[not found] ` <20170905130553.1332-2-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-08 12:39 ` Pavel Machek
2017-09-05 13:05 ` [PATCH v8 04/21] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 07/21] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
[not found] ` <20170905130553.1332-8-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 7:42 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 08/21] rcar-vin: " Sakari Ailus
[not found] ` <20170905130553.1332-9-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 7:44 ` Hans Verkuil
[not found] ` <a51aea1f-0a00-7a7b-8197-e0f5a0443a05-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-07 8:09 ` Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 10/21] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-09-06 7:45 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 11/21] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 13/21] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
[not found] ` <20170905130553.1332-14-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 7:51 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 14/21] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
[not found] ` <20170905130553.1332-15-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06 8:46 ` Hans Verkuil
2017-09-07 8:32 ` Sakari Ailus
[not found] ` <20170907083209.3xtaxwhrfmgrtpfz-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-09-07 12:02 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 15/21] dt: bindings: Add a binding for flash devices associated to a sensor Sakari Ailus
2017-09-06 8:47 ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 17/21] v4l: fwnode: Add convenience function for parsing generic references Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 18/21] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 19/21] smiapp: Add support for flash and lens devices Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 20/21] dt: bindings: smiapp: Document lens-focus and flash properties Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 21/21] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905130553.1332-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).