From: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
To: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Antony Pavlov
<antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alban Bedel <albeu-GANU6spQydw@public.gmane.org>,
John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH] MIPS: ath79: support devicetree selection
Date: Wed, 6 Sep 2017 13:14:35 +0200 [thread overview]
Message-ID: <20170906111435.GA1856@linux-mips.org> (raw)
In-Reply-To: <b78cb3ef8df8531efdb7b011743ad3f38978015d.1503070362.git.rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> Allow to choose devicetrees from Kconfig.
>
> Signed-off-by: Rocco Folino <rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/mips/ath79/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++
> arch/mips/boot/dts/qca/Makefile | 10 +++++-----
> 2 files changed, 49 insertions(+), 5 deletions(-)
>
> diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> index dfc60209dc63..b43d116187af 100644
> --- a/arch/mips/ath79/Kconfig
> +++ b/arch/mips/ath79/Kconfig
> @@ -1,5 +1,49 @@
> if ATH79
>
> +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> +
> +config DTB_ATH_DPT_MODULE
> + bool "DPTechnics DPT-Module"
> + select SOC_933X
There is no symbol SOC_933X. Did you mean SOC_AR933X?
Anyway, your patch does more than the changelog ("Allow to choose
devicetrees from Kconfig") says, so please either fix the changelog
or split that into multiple patches with proper changelogs.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-06 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 15:32 [PATCH] MIPS: ath79: support devicetree selection Rocco Folino
[not found] ` <b78cb3ef8df8531efdb7b011743ad3f38978015d.1503070362.git.rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-06 11:14 ` Ralf Baechle [this message]
[not found] ` <20170906111435.GA1856-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2017-09-06 12:01 ` Rocco Folino
2017-09-06 12:20 ` Alban
2017-09-06 12:32 ` Rocco Folino
2017-09-06 13:35 ` Alban
2017-09-06 13:59 ` Rocco Folino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906111435.GA1856@linux-mips.org \
--to=ralf-6z/3iimg2c8g8few9mqtra@public.gmane.org \
--cc=albeu-GANU6spQydw@public.gmane.org \
--cc=antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rocco.folino-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).