From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,
robh@kernel.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
sre@kernel.org
Subject: Re: as3645a flash userland interface
Date: Tue, 12 Sep 2017 13:40:51 +0200 [thread overview]
Message-ID: <20170912114051.GA1655@amd> (raw)
In-Reply-To: <20170912104720.ifyouc5pa5et6gzk@valkosipuli.retiisi.org.uk>
[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]
Hi!
> On Tue, Sep 12, 2017 at 12:36:28PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > There were some changes to as3645a flash controller. Before we have
> > stable interface we have to keep forever I want to ask:
> >
> > What directory are the flash controls in?
> >
> > /sys/class/leds/led-controller:flash ?
> >
> > Could we arrange for something less generic, like
> >
> > /sys/class/leds/main-camera:flash ?
> >
> > Thanks,
>
> The LEDs are called as3645a:flash and as3645a:indicator currently, based on
> the name of the LED controller's device node. There are no patches related
> to this set though; these have already been merged.
>
> The label should be a "human readable string describing the device" (from
> ePAPR, please excuse me for not having a newer spec), and the led common
> bindings define it as:
>
> - label : The label for this LED. If omitted, the label is taken from the node
> name (excluding the unit address). It has to uniquely identify
> a device, i.e. no other LED class device can be assigned the same
> label.
Ok, can we set the label to "main_camera" for N9 and n950 cases?
"as3645a:flash" is really wrong name for a LED. Information that
as3645 is already present elsewhere in /sys. Information where the LED
is and what it does is not.
I'd like to have torch application that just writes
/sys/class/leds/main_camera:white:flash/brightness . It should not
need to know hardware details of differnet phones.
> I don't think that you should be looking to use this to associate it with
> the camera as such. The association information with the sensor is
> available to the kernel but there's no interface that could meaningfully
> expose it to the user right now.
Yeah, I'm not looking for sensor association. I'm looking for
reasonable userland interface.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-12 11:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 8:42 [PATCH v11 00/24] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 03/24] v4l: async: Use more intuitive names for internal functions Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 06/24] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 07/24] rcar-vin: " Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 08/24] omap3isp: Fix check for our own sub-devices Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 10/24] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 11/24] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
[not found] ` <20170912084236.1154-12-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-12 9:39 ` Hans Verkuil
[not found] ` <20170912084236.1154-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-12 8:42 ` [PATCH v11 01/24] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 02/24] v4l: async: Remove re-probing support Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 04/24] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 05/24] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 09/24] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 12/24] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 13/24] v4l: async: Allow async notifier register call succeed with no subdevs Sakari Ailus
2017-09-12 9:38 ` Hans Verkuil
2017-09-12 8:42 ` [PATCH v11 14/24] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 20/24] dt: bindings: smiapp: Document lens-focus and flash-leds properties Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 21/24] smiapp: Add support for flash and lens devices Sakari Ailus
[not found] ` <20170912084236.1154-22-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-12 10:31 ` Pavel Machek
2017-09-12 8:42 ` [PATCH v11 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
[not found] ` <20170912084236.1154-25-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-12 10:36 ` as3645a flash userland interface Pavel Machek
2017-09-12 10:47 ` Sakari Ailus
2017-09-12 11:40 ` Pavel Machek [this message]
2017-09-12 12:04 ` Sakari Ailus
2017-09-12 18:53 ` Jacek Anaszewski
2017-09-12 21:55 ` Pavel Machek
2017-09-13 17:53 ` Jacek Anaszewski
[not found] ` <CGME20170914092415epcas2p26c049a698851778673034c16afb290b9@epcas2p2.samsung.com>
[not found] ` <21824758-28a1-7007-6db5-86a900025d14-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-14 9:24 ` Sylwester Nawrocki
[not found] ` <4bf12e8e-beff-0199-cdee-4a52ebe7cdaf-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-09-14 10:07 ` Pavel Machek
2017-09-14 10:28 ` Sakari Ailus
2017-09-14 11:01 ` Sylwester Nawrocki
[not found] ` <1f34a891-edb1-251c-86a8-ba4a90c485d3-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-09-14 11:53 ` Pavel Machek
2017-09-14 13:16 ` Sylwester Nawrocki
[not found] ` <7b679cb3-ce58-e1d1-60bf-995896bf46eb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 9:12 ` Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 15/24] dt: bindings: Add a binding for flash LED devices associated to a sensor Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 16/24] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 17/24] v4l: fwnode: Add a helper function for parsing generic references Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 18/24] v4l: fwnode: Add a helper function to obtain device / interger references Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 19/24] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 22/24] ov5670: Add support for flash and lens devices Sakari Ailus
2017-09-12 8:42 ` [PATCH v11 23/24] ov13858: " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912114051.GA1655@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacek.anaszewski@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).