From: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references
Date: Tue, 12 Sep 2017 16:41:52 +0300 [thread overview]
Message-ID: <20170912134200.19556-19-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170912134200.19556-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Add function v4l2_fwnode_reference_count() for counting external
references and v4l2_fwnode_reference_parse() for parsing them as async
sub-devices.
This can be done on e.g. flash or lens async sub-devices that are not part
of but are associated with a sensor.
struct v4l2_async_notifier.max_subdevs field is added to contain the
maximum number of sub-devices in a notifier to reflect the memory
allocated for the subdevs array.
Signed-off-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/media/v4l2-core/v4l2-fwnode.c | 69 +++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index 44ee35f6aad5..a32473f95be1 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -498,6 +498,75 @@ int v4l2_async_notifier_parse_fwnode_endpoints_by_port(
}
EXPORT_SYMBOL_GPL(v4l2_async_notifier_parse_fwnode_endpoints_by_port);
+/*
+ * v4l2_fwnode_reference_parse - parse references for async sub-devices
+ * @dev: the device node the properties of which are parsed for references
+ * @notifier: the async notifier where the async subdevs will be added
+ * @prop: the name of the property
+ *
+ * Return: 0 on success
+ * -ENOENT if no entries were found
+ * -ENOMEM if memory allocation failed
+ * -EINVAL if property parsing failed
+ */
+static int v4l2_fwnode_reference_parse(
+ struct device *dev, struct v4l2_async_notifier *notifier,
+ const char *prop)
+{
+ struct fwnode_reference_args args;
+ unsigned int index;
+ int ret;
+
+ for (index = 0;
+ !(ret = fwnode_property_get_reference_args(
+ dev_fwnode(dev), prop, NULL, 0, index, &args));
+ index++)
+ fwnode_handle_put(args.fwnode);
+
+ if (!index)
+ return -ENOENT;
+
+ /*
+ * To-do: handle -ENODATA when "device property: Align return
+ * codes of acpi_fwnode_get_reference_with_args" is merged.
+ */
+ if (ret != -ENOENT && ret != -ENODATA)
+ return ret;
+
+ ret = v4l2_async_notifier_realloc(notifier,
+ notifier->num_subdevs + index);
+ if (ret)
+ return ret;
+
+ for (index = 0; !fwnode_property_get_reference_args(
+ dev_fwnode(dev), prop, NULL, 0, index, &args);
+ index++) {
+ struct v4l2_async_subdev *asd;
+
+ if (WARN_ON(notifier->num_subdevs >= notifier->max_subdevs)) {
+ ret = -EINVAL;
+ goto error;
+ }
+
+ asd = kzalloc(sizeof(*asd), GFP_KERNEL);
+ if (!asd) {
+ ret = -ENOMEM;
+ goto error;
+ }
+
+ notifier->subdevs[notifier->num_subdevs] = asd;
+ asd->match.fwnode.fwnode = args.fwnode;
+ asd->match_type = V4L2_ASYNC_MATCH_FWNODE;
+ notifier->num_subdevs++;
+ }
+
+ return 0;
+
+error:
+ fwnode_handle_put(args.fwnode);
+ return ret;
+}
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>");
MODULE_AUTHOR("Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>");
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-12 13:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 13:41 [PATCH v12 00/30] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 03/26] v4l: async: Use more intuitive names for internal functions Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 04/26] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 05/26] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 06/26] v4l: fwnode: Support generic parsing of graph endpoints, per port Sakari Ailus
2017-09-13 7:01 ` Hans Verkuil
2017-09-13 7:06 ` Hans Verkuil
[not found] ` <a6cdf6cb-6abc-ac3b-274d-e8b43e2ac2c6-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-13 8:18 ` Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 08/26] rcar-vin: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 09/26] omap3isp: Fix check for our own sub-devices Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 10/26] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 12/26] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 14/26] v4l: async: Allow async notifier register call succeed with no subdevs Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 15/26] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
[not found] ` <20170912134200.19556-16-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-13 7:17 ` Hans Verkuil
[not found] ` <575bf15b-62d2-3a51-d550-d462578471f7-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-13 8:29 ` Sakari Ailus
[not found] ` <20170913082901.fbxxphn7s3ljn3mc-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-09-13 9:25 ` Hans Verkuil
[not found] ` <20170912134200.19556-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-12 13:41 ` [PATCH v12 01/26] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 02/26] v4l: async: Remove re-probing support Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 07/26] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 11/26] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 13/26] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 16/26] dt: bindings: Add a binding for flash LED devices associated to a sensor Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 17/26] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-09-12 13:41 ` Sakari Ailus [this message]
[not found] ` <20170912134200.19556-19-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-13 7:27 ` [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references Hans Verkuil
[not found] ` <020b9c86-dd73-3516-4a0e-827db9680b55-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-13 9:24 ` Sakari Ailus
[not found] ` <20170913092430.cbdgerkhiuxakbxv-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-09-13 9:28 ` Hans Verkuil
2017-09-13 10:07 ` Sakari Ailus
2017-09-13 10:32 ` Hans Verkuil
2017-09-15 14:05 ` Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 19/26] v4l: fwnode: Add a helper function to obtain device / interger references Sakari Ailus
[not found] ` <20170912134200.19556-20-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-13 7:57 ` Hans Verkuil
2017-09-13 10:04 ` Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 22/26] smiapp: Add support for flash and lens devices Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 24/26] ov5670: " Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 25/26] ov13858: " Sakari Ailus
2017-09-12 13:42 ` [PATCH v12 26/26] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 20/26] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 21/26] dt: bindings: smiapp: Document lens-focus and flash-leds properties Sakari Ailus
2017-09-12 13:41 ` [PATCH v12 23/26] et8ek8: Add support for flash and lens devices Sakari Ailus
[not found] ` <20170912134200.19556-24-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-13 7:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912134200.19556-19-sakari.ailus@linux.intel.com \
--to=sakari.ailus-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).