* [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver
@ 2017-09-01 6:58 Florian Eckert
2017-09-01 6:58 ` [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
2017-09-01 14:24 ` [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Guenter Roeck
0 siblings, 2 replies; 13+ messages in thread
From: Florian Eckert @ 2017-09-01 6:58 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree, linux-kernel, linux-hwmon,
linux, jdelvare
Add the lantiq cpu temperature sensor support for xrx200.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
v2:
- remove default in Makefile
- fix spelling
- removing first read delay, because temperature value is not read during boot
anymore
- change calculation, compiler should to the optimization
- remove unnecessary initialization
- use new devm_hwmon_device_register_with_info API
- use module_platform_driver function
v3:
- sort includes in alphabetic order
- add missing linux/bitops.h include
- fix alignment
- fix switch case indentation
- use octal file permission instead of S_IRUGO
- set hwmon device name to "ltq_cputemp"
- enable temperature chip before hwmon registration
- remove release function registrate ltq_cputemp_disable()
with devm_add_action
- remove init_ltq_cputemp and clean_ltq_cputemp not used
overlooked it on v2
drivers/hwmon/Kconfig | 7 ++
drivers/hwmon/Makefile | 1 +
drivers/hwmon/ltq-cputemp.c | 163 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 171 insertions(+)
create mode 100644 drivers/hwmon/ltq-cputemp.c
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 5ef2814345ef..218332f0e913 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -790,6 +790,13 @@ config SENSORS_LTC4261
This driver can also be built as a module. If so, the module will
be called ltc4261.
+config SENSORS_LTQ_CPUTEMP
+ bool "Lantiq cpu temperature sensor driver"
+ depends on LANTIQ
+ help
+ If you say yes here you get support for the temperature
+ sensor inside your CPU.
+
config SENSORS_MAX1111
tristate "Maxim MAX1111 Serial 8-bit ADC chip and compatibles"
depends on SPI_MASTER
diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index d4641a9f16c1..c84d9784be98 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -110,6 +110,7 @@ obj-$(CONFIG_SENSORS_LTC4222) += ltc4222.o
obj-$(CONFIG_SENSORS_LTC4245) += ltc4245.o
obj-$(CONFIG_SENSORS_LTC4260) += ltc4260.o
obj-$(CONFIG_SENSORS_LTC4261) += ltc4261.o
+obj-$(CONFIG_SENSORS_LTQ_CPUTEMP) += ltq-cputemp.o
obj-$(CONFIG_SENSORS_MAX1111) += max1111.o
obj-$(CONFIG_SENSORS_MAX16065) += max16065.o
obj-$(CONFIG_SENSORS_MAX1619) += max1619.o
diff --git a/drivers/hwmon/ltq-cputemp.c b/drivers/hwmon/ltq-cputemp.c
new file mode 100644
index 000000000000..1d33f94594c1
--- /dev/null
+++ b/drivers/hwmon/ltq-cputemp.c
@@ -0,0 +1,163 @@
+/* Lantiq cpu temperature sensor driver
+ *
+ * Copyright (C) 2017 Florian Eckert <fe@dev.tdt.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version
+ *
+ * This program is distributed in the hope that it will be useful
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>
+ */
+
+#include <linux/bitops.h>
+#include <linux/delay.h>
+#include <linux/hwmon.h>
+#include <linux/hwmon-sysfs.h>
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+
+#include <lantiq_soc.h>
+
+/* gphy1 configuration register contains cpu temperature */
+#define CGU_GPHY1_CR 0x0040
+#define CGU_TEMP_PD BIT(19)
+
+static void ltq_cputemp_enable(void)
+{
+ ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) | CGU_TEMP_PD, CGU_GPHY1_CR);
+}
+
+static void ltq_cputemp_disable(void *data)
+{
+ ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) & ~CGU_TEMP_PD, CGU_GPHY1_CR);
+}
+
+static int ltq_read(struct device *dev, enum hwmon_sensor_types type,
+ u32 attr, int channel, long *temp)
+{
+ int value;
+
+ switch (attr) {
+ case hwmon_temp_input:
+ /* get the temperature including one decimal place */
+ value = (ltq_cgu_r32(CGU_GPHY1_CR) >> 9) & 0x01FF;
+ value = value * 5;
+ /* range -38 to +154 °C, register value zero is -38.0 °C */
+ value -= 380;
+ /* scale temp to millidegree */
+ value = value * 100;
+ break;
+ default:
+ return -EOPNOTSUPP;
+ }
+
+ *temp = value;
+ return 0;
+}
+
+static umode_t ltq_is_visible(const void *_data, enum hwmon_sensor_types type,
+ u32 attr, int channel)
+{
+ if (type != hwmon_temp)
+ return 0;
+
+ switch (attr) {
+ case hwmon_temp_input:
+ return 0444;
+ default:
+ return 0;
+ }
+}
+
+static const u32 ltq_chip_config[] = {
+ HWMON_C_REGISTER_TZ,
+ 0
+};
+
+static const struct hwmon_channel_info ltq_chip = {
+ .type = hwmon_chip,
+ .config = ltq_chip_config,
+};
+
+static const u32 ltq_temp_config[] = {
+ HWMON_T_INPUT,
+ 0
+};
+
+static const struct hwmon_channel_info ltq_temp = {
+ .type = hwmon_temp,
+ .config = ltq_temp_config,
+};
+
+static const struct hwmon_channel_info *ltq_info[] = {
+ <q_chip,
+ <q_temp,
+ NULL
+};
+
+static const struct hwmon_ops ltq_hwmon_ops = {
+ .is_visible = ltq_is_visible,
+ .read = ltq_read,
+};
+
+static const struct hwmon_chip_info ltq_chip_info = {
+ .ops = <q_hwmon_ops,
+ .info = ltq_info,
+};
+
+static int ltq_cputemp_probe(struct platform_device *pdev)
+{
+ struct device *hwmon_dev;
+ int err = 0;
+
+ /* available on vr9 v1.2 SoCs only */
+ if (ltq_soc_type() != SOC_TYPE_VR9_2)
+ return -ENODEV;
+
+ err = devm_add_action(&pdev->dev, ltq_cputemp_disable, NULL);
+ if (err)
+ return err;
+
+ ltq_cputemp_enable();
+
+ hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev,
+ "ltq_cputemp",
+ NULL,
+ <q_chip_info,
+ NULL);
+
+ if (IS_ERR(hwmon_dev)) {
+ dev_err(&pdev->dev, "Failed to register as hwmon device");
+ return PTR_ERR(hwmon_dev);
+ }
+
+ return 0;
+}
+
+const struct of_device_id ltq_cputemp_match[] = {
+ { .compatible = "lantiq,cputemp" },
+ {},
+};
+MODULE_DEVICE_TABLE(of, ltq_cputemp_match);
+
+static struct platform_driver ltq_cputemp_driver = {
+ .probe = ltq_cputemp_probe,
+ .driver = {
+ .name = "ltq-cputemp",
+ .of_match_table = ltq_cputemp_match,
+ },
+};
+
+module_platform_driver(ltq_cputemp_driver);
+
+MODULE_AUTHOR("Florian Eckert <fe@dev.tdt.de>");
+MODULE_DESCRIPTION("Lantiq cpu temperature sensor driver");
+MODULE_LICENSE("GPL");
--
2.11.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
2017-09-01 6:58 [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Florian Eckert
@ 2017-09-01 6:58 ` Florian Eckert
2017-09-01 14:26 ` Guenter Roeck
2017-09-01 14:24 ` [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Guenter Roeck
1 sibling, 1 reply; 13+ messages in thread
From: Florian Eckert @ 2017-09-01 6:58 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree, linux-kernel, linux-hwmon,
linux, jdelvare
Document the devicetree bindings for the ltq-cputemp
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
1 file changed, 10 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
new file mode 100644
index 000000000000..33fd00a987c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
@@ -0,0 +1,10 @@
+Lantiq cpu temperatur sensor
+
+Requires node properties:
+- compatible value :
+ "lantiq,cputemp"
+
+Example:
+ cputemp@0 {
+ compatible = "lantiq,cputemp";
+ };
--
2.11.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
2017-09-01 6:58 ` [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
@ 2017-09-01 14:26 ` Guenter Roeck
2017-09-12 16:20 ` Rob Herring
0 siblings, 1 reply; 13+ messages in thread
From: Guenter Roeck @ 2017-09-01 14:26 UTC (permalink / raw)
To: Florian Eckert
Cc: robh+dt, mark.rutland, devicetree, linux-kernel, linux-hwmon,
jdelvare
On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:
> Document the devicetree bindings for the ltq-cputemp
>
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
I see nothing special with the bindings, and they are in line with other lantiq
bindings, so I am taking the risk of accepting this patch (and the matching
driver) without waiting for explicit approval from Rob. Rob, scream at me if
that is not ok.
Thanks,
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> new file mode 100644
> index 000000000000..33fd00a987c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> @@ -0,0 +1,10 @@
> +Lantiq cpu temperatur sensor
> +
> +Requires node properties:
> +- compatible value :
> + "lantiq,cputemp"
> +
> +Example:
> + cputemp@0 {
> + compatible = "lantiq,cputemp";
> + };
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
2017-09-01 14:26 ` Guenter Roeck
@ 2017-09-12 16:20 ` Rob Herring
2017-09-13 5:36 ` Florian Eckert
2017-09-13 14:12 ` Guenter Roeck
0 siblings, 2 replies; 13+ messages in thread
From: Rob Herring @ 2017-09-12 16:20 UTC (permalink / raw)
To: Guenter Roeck
Cc: Florian Eckert, mark.rutland, devicetree, linux-kernel,
linux-hwmon, jdelvare
On Fri, Sep 01, 2017 at 07:26:22AM -0700, Guenter Roeck wrote:
> On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:
> > Document the devicetree bindings for the ltq-cputemp
> >
> > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
>
> I see nothing special with the bindings, and they are in line with other lantiq
> bindings, so I am taking the risk of accepting this patch (and the matching
> driver) without waiting for explicit approval from Rob. Rob, scream at me if
> that is not ok.
Perhaps the existing one was not well reviewed.
>
> Thanks,
> Guenter
>
> > ---
> > Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > new file mode 100644
> > index 000000000000..33fd00a987c7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > @@ -0,0 +1,10 @@
> > +Lantiq cpu temperatur sensor
s/temperatur/temperature/
> > +
> > +Requires node properties:
> > +- compatible value :
> > + "lantiq,cputemp"
Kind of non-specific. How is this device even accessed without any other
property?
> > +
> > +Example:
> > + cputemp@0 {
unit-address without reg property is not valid.
> > + compatible = "lantiq,cputemp";
> > + };
> > --
> > 2.11.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
2017-09-12 16:20 ` Rob Herring
@ 2017-09-13 5:36 ` Florian Eckert
[not found] ` <a5a2e95a1fb671eb59459542af122d6e-W9Oo8bkYgz6ELgA04lAiVw@public.gmane.org>
2017-09-13 14:12 ` Guenter Roeck
1 sibling, 1 reply; 13+ messages in thread
From: Florian Eckert @ 2017-09-13 5:36 UTC (permalink / raw)
To: Rob Herring
Cc: Guenter Roeck, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-hwmon-u79uwXL29TY76Z2rM5mHXA, jdelvare-IBi9RG/b67k
Hello Rob
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
>> > @@ -0,0 +1,10 @@
>> > +Lantiq cpu temperatur sensor
>
> s/temperatur/temperature/
Will update this in a follow up page based on the old one. So no v4?
>
>> > +
>> > +Requires node properties:
>> > +- compatible value :
>> > + "lantiq,cputemp"
>
> Kind of non-specific. How is this device even accessed without any
> other
> property?
It does not need any further properties. If this is set in the device
tree then the driver is loaded.
After loading the temperature could be read from "/sys/class/hwmon".
Let me know what should i do to get this fixed?
Thanks for feedback
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
2017-09-12 16:20 ` Rob Herring
2017-09-13 5:36 ` Florian Eckert
@ 2017-09-13 14:12 ` Guenter Roeck
1 sibling, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2017-09-13 14:12 UTC (permalink / raw)
To: Rob Herring
Cc: Florian Eckert, mark.rutland, devicetree, linux-kernel,
linux-hwmon, jdelvare
On Tue, Sep 12, 2017 at 11:20:08AM -0500, Rob Herring wrote:
> On Fri, Sep 01, 2017 at 07:26:22AM -0700, Guenter Roeck wrote:
> > On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:
> > > Document the devicetree bindings for the ltq-cputemp
> > >
> > > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> >
> > I see nothing special with the bindings, and they are in line with other lantiq
> > bindings, so I am taking the risk of accepting this patch (and the matching
> > driver) without waiting for explicit approval from Rob. Rob, scream at me if
> > that is not ok.
>
> Perhaps the existing one was not well reviewed.
>
Bummer. Should teach me to never accept DT patches without your review.
I owe you a beer or two.
Guenter
> >
> > Thanks,
> > Guenter
> >
> > > ---
> > > Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > > new file mode 100644
> > > index 000000000000..33fd00a987c7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> > > @@ -0,0 +1,10 @@
> > > +Lantiq cpu temperatur sensor
>
> s/temperatur/temperature/
>
> > > +
> > > +Requires node properties:
> > > +- compatible value :
> > > + "lantiq,cputemp"
>
> Kind of non-specific. How is this device even accessed without any other
> property?
>
> > > +
> > > +Example:
> > > + cputemp@0 {
>
> unit-address without reg property is not valid.
>
> > > + compatible = "lantiq,cputemp";
> > > + };
> > > --
> > > 2.11.0
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver
2017-09-01 6:58 [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Florian Eckert
2017-09-01 6:58 ` [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
@ 2017-09-01 14:24 ` Guenter Roeck
1 sibling, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2017-09-01 14:24 UTC (permalink / raw)
To: Florian Eckert
Cc: robh+dt, mark.rutland, devicetree, linux-kernel, linux-hwmon,
jdelvare
On Fri, Sep 01, 2017 at 08:58:17AM +0200, Florian Eckert wrote:
> Add the lantiq cpu temperature sensor support for xrx200.
>
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> v2:
> - remove default in Makefile
> - fix spelling
> - removing first read delay, because temperature value is not read during boot
> anymore
> - change calculation, compiler should to the optimization
> - remove unnecessary initialization
> - use new devm_hwmon_device_register_with_info API
> - use module_platform_driver function
>
> v3:
> - sort includes in alphabetic order
> - add missing linux/bitops.h include
> - fix alignment
> - fix switch case indentation
> - use octal file permission instead of S_IRUGO
> - set hwmon device name to "ltq_cputemp"
> - enable temperature chip before hwmon registration
> - remove release function registrate ltq_cputemp_disable()
> with devm_add_action
> - remove init_ltq_cputemp and clean_ltq_cputemp not used
> overlooked it on v2
>
> drivers/hwmon/Kconfig | 7 ++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/ltq-cputemp.c | 163 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 171 insertions(+)
> create mode 100644 drivers/hwmon/ltq-cputemp.c
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 5ef2814345ef..218332f0e913 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -790,6 +790,13 @@ config SENSORS_LTC4261
> This driver can also be built as a module. If so, the module will
> be called ltc4261.
>
> +config SENSORS_LTQ_CPUTEMP
> + bool "Lantiq cpu temperature sensor driver"
> + depends on LANTIQ
> + help
> + If you say yes here you get support for the temperature
> + sensor inside your CPU.
> +
> config SENSORS_MAX1111
> tristate "Maxim MAX1111 Serial 8-bit ADC chip and compatibles"
> depends on SPI_MASTER
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index d4641a9f16c1..c84d9784be98 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -110,6 +110,7 @@ obj-$(CONFIG_SENSORS_LTC4222) += ltc4222.o
> obj-$(CONFIG_SENSORS_LTC4245) += ltc4245.o
> obj-$(CONFIG_SENSORS_LTC4260) += ltc4260.o
> obj-$(CONFIG_SENSORS_LTC4261) += ltc4261.o
> +obj-$(CONFIG_SENSORS_LTQ_CPUTEMP) += ltq-cputemp.o
> obj-$(CONFIG_SENSORS_MAX1111) += max1111.o
> obj-$(CONFIG_SENSORS_MAX16065) += max16065.o
> obj-$(CONFIG_SENSORS_MAX1619) += max1619.o
> diff --git a/drivers/hwmon/ltq-cputemp.c b/drivers/hwmon/ltq-cputemp.c
> new file mode 100644
> index 000000000000..1d33f94594c1
> --- /dev/null
> +++ b/drivers/hwmon/ltq-cputemp.c
> @@ -0,0 +1,163 @@
> +/* Lantiq cpu temperature sensor driver
> + *
> + * Copyright (C) 2017 Florian Eckert <fe@dev.tdt.de>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version
> + *
> + * This program is distributed in the hope that it will be useful
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see <http://www.gnu.org/licenses/>
> + */
> +
> +#include <linux/bitops.h>
> +#include <linux/delay.h>
> +#include <linux/hwmon.h>
> +#include <linux/hwmon-sysfs.h>
> +#include <linux/init.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +
> +#include <lantiq_soc.h>
> +
> +/* gphy1 configuration register contains cpu temperature */
> +#define CGU_GPHY1_CR 0x0040
> +#define CGU_TEMP_PD BIT(19)
> +
> +static void ltq_cputemp_enable(void)
> +{
> + ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) | CGU_TEMP_PD, CGU_GPHY1_CR);
> +}
> +
> +static void ltq_cputemp_disable(void *data)
> +{
> + ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) & ~CGU_TEMP_PD, CGU_GPHY1_CR);
> +}
> +
> +static int ltq_read(struct device *dev, enum hwmon_sensor_types type,
> + u32 attr, int channel, long *temp)
> +{
> + int value;
> +
> + switch (attr) {
> + case hwmon_temp_input:
> + /* get the temperature including one decimal place */
> + value = (ltq_cgu_r32(CGU_GPHY1_CR) >> 9) & 0x01FF;
> + value = value * 5;
> + /* range -38 to +154 °C, register value zero is -38.0 °C */
> + value -= 380;
> + /* scale temp to millidegree */
> + value = value * 100;
> + break;
> + default:
> + return -EOPNOTSUPP;
> + }
> +
> + *temp = value;
> + return 0;
> +}
> +
> +static umode_t ltq_is_visible(const void *_data, enum hwmon_sensor_types type,
> + u32 attr, int channel)
> +{
> + if (type != hwmon_temp)
> + return 0;
> +
> + switch (attr) {
> + case hwmon_temp_input:
> + return 0444;
> + default:
> + return 0;
> + }
> +}
> +
> +static const u32 ltq_chip_config[] = {
> + HWMON_C_REGISTER_TZ,
> + 0
> +};
> +
> +static const struct hwmon_channel_info ltq_chip = {
> + .type = hwmon_chip,
> + .config = ltq_chip_config,
> +};
> +
> +static const u32 ltq_temp_config[] = {
> + HWMON_T_INPUT,
> + 0
> +};
> +
> +static const struct hwmon_channel_info ltq_temp = {
> + .type = hwmon_temp,
> + .config = ltq_temp_config,
> +};
> +
> +static const struct hwmon_channel_info *ltq_info[] = {
> + <q_chip,
> + <q_temp,
> + NULL
> +};
> +
> +static const struct hwmon_ops ltq_hwmon_ops = {
> + .is_visible = ltq_is_visible,
> + .read = ltq_read,
> +};
> +
> +static const struct hwmon_chip_info ltq_chip_info = {
> + .ops = <q_hwmon_ops,
> + .info = ltq_info,
> +};
> +
> +static int ltq_cputemp_probe(struct platform_device *pdev)
> +{
> + struct device *hwmon_dev;
> + int err = 0;
> +
> + /* available on vr9 v1.2 SoCs only */
> + if (ltq_soc_type() != SOC_TYPE_VR9_2)
> + return -ENODEV;
> +
> + err = devm_add_action(&pdev->dev, ltq_cputemp_disable, NULL);
> + if (err)
> + return err;
> +
> + ltq_cputemp_enable();
> +
> + hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev,
> + "ltq_cputemp",
> + NULL,
> + <q_chip_info,
> + NULL);
> +
> + if (IS_ERR(hwmon_dev)) {
> + dev_err(&pdev->dev, "Failed to register as hwmon device");
> + return PTR_ERR(hwmon_dev);
> + }
> +
> + return 0;
> +}
> +
> +const struct of_device_id ltq_cputemp_match[] = {
> + { .compatible = "lantiq,cputemp" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, ltq_cputemp_match);
> +
> +static struct platform_driver ltq_cputemp_driver = {
> + .probe = ltq_cputemp_probe,
> + .driver = {
> + .name = "ltq-cputemp",
> + .of_match_table = ltq_cputemp_match,
> + },
> +};
> +
> +module_platform_driver(ltq_cputemp_driver);
> +
> +MODULE_AUTHOR("Florian Eckert <fe@dev.tdt.de>");
> +MODULE_DESCRIPTION("Lantiq cpu temperature sensor driver");
> +MODULE_LICENSE("GPL");
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-09-20 2:53 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 6:58 [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Florian Eckert
2017-09-01 6:58 ` [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
2017-09-01 14:26 ` Guenter Roeck
2017-09-12 16:20 ` Rob Herring
2017-09-13 5:36 ` Florian Eckert
[not found] ` <a5a2e95a1fb671eb59459542af122d6e-W9Oo8bkYgz6ELgA04lAiVw@public.gmane.org>
2017-09-13 14:12 ` Guenter Roeck
2017-09-13 14:42 ` Florian Eckert
2017-09-13 15:12 ` Guenter Roeck
2017-09-13 15:25 ` Rob Herring
2017-09-14 7:06 ` Florian Eckert
[not found] ` <b6c6310ff0fde9d0df29a57fcd229591-W9Oo8bkYgz6ELgA04lAiVw@public.gmane.org>
2017-09-20 2:53 ` Rob Herring
2017-09-13 14:12 ` Guenter Roeck
2017-09-01 14:24 ` [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).