From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/11] soc: renesas: rcar-sysc: add R8A77970 support
Date: Fri, 15 Sep 2017 09:25:05 +0200 [thread overview]
Message-ID: <20170915072504.GA3924@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXLbg2WwtWvG+zBa5MOT3qXr2Fv-U4AJ0=eLfE2VG1LKg@mail.gmail.com>
On Wed, Sep 13, 2017 at 10:36:23AM +0200, Geert Uytterhoeven wrote:
> Hi Sergei,
>
> On Tue, Sep 12, 2017 at 10:37 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Add support for R-Car V3M (R8A77970) SoC power areas to the R-Car SYSC
> > driver.
> >
> > Based on the original (and large) patch by Daisuke Matsushita
> > <daisuke.matsushita.ns@hitachi.com>.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> > --- /dev/null
> > +++ renesas/drivers/soc/renesas/r8a77970-sysc.c
> > @@ -0,0 +1,39 @@
>
> > +#include <linux/bug.h>
>
> I think this include is no longer needed since commit c7acec713d14c6ce
> ("kernel.h: handle pointers to arrays better in container_of()").
>
> > +static const struct rcar_sysc_area r8a77970_areas[] __initconst = {
>
> > + { "a3ir", 0x180, 0, R8A77970_PD_A3IR, R8A77970_PD_ALWAYS_ON },
> > + { "a2ir0", 0x400, 0, R8A77970_PD_A2IR0, R8A77970_PD_ALWAYS_ON },
> > + { "a2ir1", 0x400, 1, R8A77970_PD_A2IR1, R8A77970_PD_A2IR0 },
> > + { "a2ir2", 0x400, 2, R8A77970_PD_A2IR2, R8A77970_PD_A2IR0 },
> > + { "a2ir3", 0x400, 3, R8A77970_PD_A2IR3, R8A77970_PD_A2IR0 },
> > + { "a2sc0", 0x400, 4, R8A77970_PD_A2SC0, R8A77970_PD_ALWAYS_ON },
> > + { "a2sc1", 0x400, 5, R8A77970_PD_A2SC1, R8A77970_PD_A2SC0 },
>
> According to Figure 9.2(b) "Power domain structure (R-Car V3M)" and Table 9.4
> "Power domains", all of A2IR[0-3] and A2SC[01] are direct children of A3IR.
>
> BTW, the bit indices "4" resp. "5" for A2SC[01] don't match Section 9.2.5
> "Power Control Registers for A2IR" (which uses "0" resp. "1"), but I assume
> that's just a typo in the datasheet, as those would conflict with A2IR[01], and
> the would conflict with the documentation for other R-Car Gen3 SoCs.
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Sergei,
please address Geert's review and repost when you are ready.
I believe patches 1-3 of this series have been applied.
I have marked patches 4 (this one) onwards as "Changes Requested"
indicating that I expect all those patches to be reposted when you are ready.
next prev parent reply other threads:[~2017-09-15 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 20:37 [PATCH 04/11] soc: renesas: rcar-sysc: add R8A77970 support Sergei Shtylyov
2017-09-13 8:36 ` Geert Uytterhoeven
2017-09-15 7:25 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-12 20:37 Sergei Shtylyov
2017-09-12 20:37 Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915072504.GA3924@verge.net.au \
--to=horms@verge.net.au \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vladimir.barinov@cogentembedded.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).