devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
To: Yoshihiro Shimoda
	<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: Geert Uytterhoeven
	<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-Renesas
	<linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB
Date: Fri, 15 Sep 2017 09:35:01 +0200	[thread overview]
Message-ID: <20170915073501.GD3924@verge.net.au> (raw)
In-Reply-To: <TY1PR06MB0992906ACD39FA3D176CDFE6D86E0-/PRLmSCtZ16WJvbLRFYGcG0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

On Wed, Sep 13, 2017 at 11:58:47PM +0000, Yoshihiro Shimoda wrote:
> Hi Geert-san,
> 
> > From: Geert Uytterhoeven
> > Sent: Wednesday, September 13, 2017 11:55 PM
> > 
> > Hi Shimoda-san,
> > 
> > On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> > > This patch enables EthernetAVB for R-Car D3 draak board.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> > 
> > Thanks for your patch!
> > 
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > 
> > > @@ -37,6 +39,14 @@
> > >  };
> > >
> > >  &pfc {
> > > +       avb0_pins: avb {
> > > +               mux {
> > > +                       groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
> > > +                                "avb0_mii";
> > > +                       function = "avb0";
> > 
> > This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc:
> > r8a77995: Add EthernetAVB pins, groups and functions", so it may change?
> 
> Oops, I fotgot to submit v2 PFC patch yesterday...
> Yes, it is changed like other gen3 SoCs. I submitted it now. 
> 
> > And we will probably have to add driver-strengths later, to avoid a
> > dependency on bootloader setup?
> 
> Yes, I will do so, if needed.
> 
> > Apart from that:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> 
> Thank you for your review!

Thanks. I have marked this as "Deferred" pending acceptance of the PFC
patch. Please repost or ping me, f.e. via a reply-to-all to this email,
once that dependency is resolved.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-09-15  7:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 12:18 [PATCH 0/2] arm64: dts: renesas: r8a77995 and draak: add support EthernetAVB Yoshihiro Shimoda
2017-09-13 12:18 ` [PATCH 1/2] arm64: dts: renesas: r8a77995: Add EthernetAVB device node Yoshihiro Shimoda
     [not found]   ` <1505305119-4257-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-09-13 14:47     ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdVysY9hjPbhb8d7+hFk1XrYfp4YCh5+ueiUXhWSk9J5+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-15  7:32         ` Simon Horman
     [not found] ` <1505305119-4257-1-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-09-13 12:18   ` [PATCH 2/2] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB Yoshihiro Shimoda
2017-09-13 14:54     ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdX3q=foc1hkcqTc3WQYxCh1x+bc8fu9+YcqVAx9bp4qaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-13 23:58         ` Yoshihiro Shimoda
     [not found]           ` <TY1PR06MB0992906ACD39FA3D176CDFE6D86E0-/PRLmSCtZ16WJvbLRFYGcG0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-15  7:35             ` Simon Horman [this message]
2017-09-21 10:37               ` Yoshihiro Shimoda
2017-09-25  7:07                 ` Simon Horman
     [not found]                   ` <20170925070742.GC1019-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-09-27  2:03                     ` Yoshihiro Shimoda
     [not found]                       ` <TY1PR06MB0992BB60AFD2AC0E24032FE2D8780-/PRLmSCtZ16WJvbLRFYGcG0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-27  7:18                         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915073501.GD3924@verge.net.au \
    --to=horms-/r6kz+ddxgppr4jqbcensq@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).