devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
@ 2017-09-14 14:18 Vladimir Barinov
  2017-09-14 14:55 ` Geert Uytterhoeven
  2017-09-15 11:15 ` Simon Horman
  0 siblings, 2 replies; 5+ messages in thread
From: Vladimir Barinov @ 2017-09-14 14:18 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
supported board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 2:
- added own compatible value "shimafuji,kingfisher"

 Documentation/devicetree/bindings/arm/shmobile.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index ae75cb3..89bd3a6 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -85,6 +85,8 @@ Boards:
     compatible = "renesas,lager", "renesas,r8a7790"
   - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
     compatible = "renesas,m3ulcb", "renesas,r8a7796";
+  - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
+    compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
   - Marzen (R0P7779A00010S)
     compatible = "renesas,marzen", "renesas,r8a7779"
   - Porter (M2-LCDP)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
  2017-09-14 14:18 [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Vladimir Barinov
@ 2017-09-14 14:55 ` Geert Uytterhoeven
       [not found]   ` <CAMuHMdXtp0w071eAes0Khpi4jHkkgpZ36vbnReGsNWZ-73qa0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2017-09-15 11:15 ` Simon Horman
  1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-09-14 14:55 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree@vger.kernel.org,
	Linux-Renesas

Hi Vladimir,

On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
> supported board.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
> Changes in version 2:
> - added own compatible value "shimafuji,kingfisher"

Thanks for the update!

> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -85,6 +85,8 @@ Boards:
>      compatible = "renesas,lager", "renesas,r8a7790"
>    - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
>      compatible = "renesas,m3ulcb", "renesas,r8a7796";
> +  - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
> +    compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
>    - Marzen (R0P7779A00010S)
>      compatible = "renesas,marzen", "renesas,r8a7779"
>    - Porter (M2-LCDP)

As Kingfisher is an extension board, I meant to have a separate entry for it,
not tied to M3ULCB or H3ULCB:

  - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
    compatible = "shimafuji,kingfisher"

That way you don't need to list it twice (the board part number is the same
for M3ULCB Kingfisher and H3ULCB Kingfisher anyway).
Do you agree?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
       [not found]   ` <CAMuHMdXtp0w071eAes0Khpi4jHkkgpZ36vbnReGsNWZ-73qa0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2017-09-14 15:00     ` Vladimir Barinov
       [not found]       ` <0bbc8962-c7f3-3889-1add-9984fa8cea88-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Barinov @ 2017-09-14 15:00 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-Renesas

Hi Geert,

On 14.09.2017 17:55, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
>> supported board.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>> ---
>> Changes in version 2:
>> - added own compatible value "shimafuji,kingfisher"
> Thanks for the update!
>
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -85,6 +85,8 @@ Boards:
>>       compatible = "renesas,lager", "renesas,r8a7790"
>>     - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
>>       compatible = "renesas,m3ulcb", "renesas,r8a7796";
>> +  - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
>> +    compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
>>     - Marzen (R0P7779A00010S)
>>       compatible = "renesas,marzen", "renesas,r8a7779"
>>     - Porter (M2-LCDP)
> As Kingfisher is an extension board, I meant to have a separate entry for it,
> not tied to M3ULCB or H3ULCB:
>
>    - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
>      compatible = "shimafuji,kingfisher"
>
> That way you don't need to list it twice (the board part number is the same
> for M3ULCB Kingfisher and H3ULCB Kingfisher anyway).
> Do you agree?
Sorry for misunderstanding.

Do you mean to add such entry:

   - Kingfisher (SBEV-RCAR-KF-M03)
     compatible = "shimafuji,kingfisher"


-- 
Regards,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
       [not found]       ` <0bbc8962-c7f3-3889-1add-9984fa8cea88-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
@ 2017-09-14 15:19         ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-09-14 15:19 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-Renesas

Hi Vladimir,

On Thu, Sep 14, 2017 at 5:00 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> On 14.09.2017 17:55, Geert Uytterhoeven wrote:
>> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
>> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>>> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
>>> supported board.
>>>
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>>> ---
>>> Changes in version 2:
>>> - added own compatible value "shimafuji,kingfisher"
>>
>> Thanks for the update!
>>
>>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>>> @@ -85,6 +85,8 @@ Boards:
>>>       compatible = "renesas,lager", "renesas,r8a7790"
>>>     - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
>>>       compatible = "renesas,m3ulcb", "renesas,r8a7796";
>>> +  - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
>>> +    compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
>>> "renesas,r8a7796";
>>>     - Marzen (R0P7779A00010S)
>>>       compatible = "renesas,marzen", "renesas,r8a7779"
>>>     - Porter (M2-LCDP)
>>
>> As Kingfisher is an extension board, I meant to have a separate entry for
>> it,
>> not tied to M3ULCB or H3ULCB:
>>
>>    - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)

Sorry, bogus "M3ULCB" above.

>>      compatible = "shimafuji,kingfisher"
>>
>> That way you don't need to list it twice (the board part number is the
>> same
>> for M3ULCB Kingfisher and H3ULCB Kingfisher anyway).
>> Do you agree?
>
> Sorry for misunderstanding.
>
> Do you mean to add such entry:
>
>   - Kingfisher (SBEV-RCAR-KF-M03)
>     compatible = "shimafuji,kingfisher"

Exactly.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
  2017-09-14 14:18 [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Vladimir Barinov
  2017-09-14 14:55 ` Geert Uytterhoeven
@ 2017-09-15 11:15 ` Simon Horman
  1 sibling, 0 replies; 5+ messages in thread
From: Simon Horman @ 2017-09-15 11:15 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Magnus Damm, Rob Herring, Mark Rutland, Catalin Marinas,
	Will Deacon, devicetree, linux-renesas-soc

On Thu, Sep 14, 2017 at 05:18:40PM +0300, Vladimir Barinov wrote:
> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
> supported board.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
> Changes in version 2:
> - added own compatible value "shimafuji,kingfisher"
> 
>  Documentation/devicetree/bindings/arm/shmobile.txt | 1 +
>  1 file changed, 1 insertion(+)

I would refer if the patch subject was something like:

ARM: shmobile: Document M3ULCB Kingfisher board DT bindings

> 
> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> index ae75cb3..89bd3a6 100644
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -85,6 +85,8 @@ Boards:
>      compatible = "renesas,lager", "renesas,r8a7790"
>    - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
>      compatible = "renesas,m3ulcb", "renesas,r8a7796";
> +  - M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
> +    compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
>    - Marzen (R0P7779A00010S)
>      compatible = "renesas,marzen", "renesas,r8a7779"
>    - Porter (M2-LCDP)
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-09-15 11:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 14:18 [PATCH v2 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Vladimir Barinov
2017-09-14 14:55 ` Geert Uytterhoeven
     [not found]   ` <CAMuHMdXtp0w071eAes0Khpi4jHkkgpZ36vbnReGsNWZ-73qa0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-14 15:00     ` Vladimir Barinov
     [not found]       ` <0bbc8962-c7f3-3889-1add-9984fa8cea88-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-14 15:19         ` Geert Uytterhoeven
2017-09-15 11:15 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).