public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Quentin Schulz
	<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v4 2/6] iio: adc: sun4i-gpadc-iio: rename A33-specified registers to contain A33
Date: Mon, 18 Sep 2017 09:29:48 +0100	[thread overview]
Message-ID: <20170918082948.2bl5e44tzsufdj7n@dell> (raw)
In-Reply-To: <20170914145251.21784-3-icenowy-h8G6r0blFSE@public.gmane.org>

On Thu, 14 Sep 2017, Icenowy Zheng wrote:

> As the H3 SoC, which is also in sun8i line, has totally different
> register map for the thermal sensor (a cut down version of GPADC), we
> should rename A23/A33-specified registers to contain A33, in order to
> prevent obfuscation with H3 registers. Currently these registers are
> only prefixed "SUN8I", not "SUN8I_A33".
> 
> Add "_A33" after "SUN8I" on the register names.
> 
> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> Reviewed-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> ---
> Changes in v4:
> - Change A23 to A33, as the driver never supports A23.
> 
>  drivers/iio/adc/sun4i-gpadc-iio.c | 2 +-

>  include/linux/mfd/sun4i-gpadc.h   | 6 +++---

Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2017-09-18  8:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14 14:52 [PATCH v4 0/6] IIO-based thermal sensor driver for Allwinner H3 SoC Icenowy Zheng
     [not found] ` <20170914145251.21784-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-09-14 14:52   ` [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device tree binding for H3 Icenowy Zheng
2017-09-16 22:12     ` Jonathan Cameron
     [not found]     ` <20170914145251.21784-2-icenowy-h8G6r0blFSE@public.gmane.org>
2017-09-18  7:33       ` Maxime Ripard
     [not found]         ` <20170918073336.j7finend3g76chsu-ZC1Zs529Oq4@public.gmane.org>
2017-09-18  7:36           ` Icenowy Zheng
     [not found]             ` <310CE549-B8CE-4C0C-95B1-B545E38BDAF5-h8G6r0blFSE@public.gmane.org>
2017-09-18  8:30               ` Maxime Ripard
     [not found]                 ` <20170918083045.7bfiialtbm7w6i7j-ZC1Zs529Oq4@public.gmane.org>
2017-09-18 15:47                   ` [linux-sunxi] " icenowy-h8G6r0blFSE
     [not found]                     ` <e73ead447af89031749e85207cac1e69-h8G6r0blFSE@public.gmane.org>
2017-09-20  7:52                       ` Maxime Ripard
     [not found]                         ` <20170920075223.jaeswlhcqgu4yhse-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-09-20  8:04                           ` Icenowy Zheng
     [not found]                             ` <27449039-F0D4-4663-B596-C95D4408D471-h8G6r0blFSE@public.gmane.org>
2017-09-21 19:32                               ` [linux-sunxi] " Maxime Ripard
2017-09-14 14:52   ` [PATCH v4 2/6] iio: adc: sun4i-gpadc-iio: rename A33-specified registers to contain A33 Icenowy Zheng
     [not found]     ` <20170914145251.21784-3-icenowy-h8G6r0blFSE@public.gmane.org>
2017-09-18  7:34       ` Maxime Ripard
2017-09-18  8:29       ` Lee Jones [this message]
2017-09-14 14:52   ` [PATCH v4 3/6] iio: adc: sun4i-gpadc-iio: rework code for supporting newer THS variants Icenowy Zheng
     [not found]     ` <20170914145251.21784-4-icenowy-h8G6r0blFSE@public.gmane.org>
2017-09-18  7:36       ` Maxime Ripard
2017-09-14 14:52   ` [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Icenowy Zheng
     [not found]     ` <20170914145251.21784-5-icenowy-h8G6r0blFSE@public.gmane.org>
2017-09-16  9:45       ` Quentin Schulz
     [not found]         ` <445ea236-35e9-8d5a-e580-b2bdcf5f7776-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-09-16 10:14           ` icenowy-h8G6r0blFSE
     [not found]             ` <0b395ea1743a14a62855fc2a2dc74411-h8G6r0blFSE@public.gmane.org>
2017-09-16 10:35               ` Quentin Schulz
2017-09-18  8:24               ` Maxime Ripard
2017-09-16 22:16           ` Jonathan Cameron
2017-09-14 14:52   ` [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone Icenowy Zheng
     [not found]     ` <20170914145251.21784-7-icenowy-h8G6r0blFSE@public.gmane.org>
2017-09-16 10:05       ` Quentin Schulz
     [not found]         ` <b41a80ec-23d5-a614-f6cc-d09c5a459e03-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-09-16 22:17           ` Jonathan Cameron
2017-09-18  8:27             ` Maxime Ripard
     [not found]               ` <20170918082703.riqntqilakzhirc5-ZC1Zs529Oq4@public.gmane.org>
2017-09-24 14:23                 ` Jonathan Cameron
2017-09-14 14:52 ` [PATCH v4 5/6] ARM: sun8i: h3: add support for the thermal sensor in H3 Icenowy Zheng
2017-09-18  8:25   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918082948.2bl5e44tzsufdj7n@dell \
    --to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=icenowy-h8G6r0blFSE@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox