From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-leds@vger.kernel.org
Cc: linux-media@vger.kernel.rg, devicetree@vger.kernel.org, pavel@ucw.cz
Subject: [PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example
Date: Mon, 18 Sep 2017 13:17:54 +0300 [thread overview]
Message-ID: <20170918101756.8562-5-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170918101756.8562-1-sakari.ailus@linux.intel.com>
Specify the exact label used if the label property is omitted in DT, as
well as use label in the example that conforms to LED device naming.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Documentation/devicetree/bindings/leds/ams,as3645a.txt | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..9adba41e74b3 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -39,7 +39,9 @@ ams,input-max-microamp: Maximum flash controller input current. The
Optional properties of the flash child node
===========================================
-label : The label of the flash LED.
+label : The label of the flash LED. The label is otherwise assumed to
+ be the device node name concatenated with ":white:" and the
+ name of the flash LED node is assumed if omitted.
Required properties of the indicator child node (1)
@@ -52,7 +54,9 @@ led-max-microamp: Maximum indicator current. The allowed values are
Optional properties of the indicator child node
===============================================
-label : The label of the indicator LED.
+label : The label of the indicator LED. The label is otherwise assumed
+ to be the device node name concatenated with ":red:" and the
+ name of the indicator LED node is assumed if omitted.
Example
@@ -69,11 +73,11 @@ Example
flash-max-microamp = <320000>;
led-max-microamp = <60000>;
ams,input-max-microamp = <1750000>;
- label = "as3645a:flash";
+ label = "as3645a:white:flash";
};
indicator@1 {
reg = <0x1>;
led-max-microamp = <10000>;
- label = "as3645a:indicator";
+ label = "as3645a:red:indicator";
};
};
--
2.11.0
next prev parent reply other threads:[~2017-09-18 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 10:17 [PATCH v2 0/6] AS3645A fixes Sakari Ailus
2017-09-18 10:17 ` [PATCH v2 1/6] as3645a: Use ams,input-max-microamp as documented in DT bindings Sakari Ailus
2017-09-18 10:17 ` [PATCH v2 2/6] dt: bindings: as3645a: Use LED number to refer to LEDs Sakari Ailus
2017-09-18 10:17 ` [PATCH v2 3/6] as3645a: Use integer numbers for parsing LEDs Sakari Ailus
2017-09-18 10:17 ` Sakari Ailus [this message]
[not found] ` <20170918101756.8562-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-18 10:17 ` [PATCH v2 5/6] as3645a: Add colour to LED name Sakari Ailus
2017-09-18 10:17 ` [PATCH v2 6/6] as3645a: Unregister indicator LED on device unbind Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918101756.8562-5-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.rg \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).