From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example
Date: Mon, 18 Sep 2017 12:56:55 +0200 [thread overview]
Message-ID: <20170918105655.GA14591@amd> (raw)
In-Reply-To: <20170918102349.8935-5-sakari.ailus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Hi!
> Specify the exact label used if the label property is omitted in DT, as
> well as use label in the example that conforms to LED device naming.
>
> @@ -69,11 +73,11 @@ Example
> flash-max-microamp = <320000>;
> led-max-microamp = <60000>;
> ams,input-max-microamp = <1750000>;
> - label = "as3645a:flash";
> + label = "as3645a:white:flash";
> };
> indicator@1 {
> reg = <0x1>;
> led-max-microamp = <10000>;
> - label = "as3645a:indicator";
> + label = "as3645a:red:indicator";
> };
> };
Ok, but userspace still has no chance to determine if this is flash
from main camera or flash for front camera; todays smartphones have
flashes on both cameras.
So.. Can I suggset as3645a:white:main_camera_flash or main_flash or
....?
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-18 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 10:23 [RESEND PATCH v2 0/6] AS3645A fixes Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 1/6] as3645a: Use ams,input-max-microamp as documented in DT bindings Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 2/6] dt: bindings: as3645a: Use LED number to refer to LEDs Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 3/6] as3645a: Use integer numbers for parsing LEDs Sakari Ailus
[not found] ` <20170918102349.8935-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-18 10:23 ` [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example Sakari Ailus
2017-09-18 10:56 ` Pavel Machek [this message]
2017-09-18 14:49 ` Sakari Ailus
2017-09-18 20:54 ` Pavel Machek
2017-09-19 21:01 ` Jacek Anaszewski
2017-09-20 20:53 ` Rob Herring
2017-09-22 21:07 ` Jacek Anaszewski
2017-09-23 21:12 ` Jacek Anaszewski
2017-11-18 13:38 ` Jacek Anaszewski
2017-09-25 3:52 ` Rob Herring
2017-09-18 10:23 ` [RESEND PATCH v2 5/6] as3645a: Add colour to LED name Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 6/6] as3645a: Unregister indicator LED on device unbind Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918105655.GA14591@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).