From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [RFC PATCH 0/7] AXP803 AC/Battery support Date: Thu, 21 Sep 2017 15:46:21 +0100 Message-ID: <20170921154621.0000328d@huawei.com> References: <20170920151814.22461-1-icenowy@aosc.io> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170920151814.22461-1-icenowy-h8G6r0blFSE@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Icenowy Zheng Cc: Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , Lee Jones , Quentin Schulz , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 20 Sep 2017 23:18:07 +0800 Icenowy Zheng wrote: > The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power inputs: > AC, USB and Battery. > > This patchset adds support for the AC and Battery supplies, which is useful > for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, Pinebook). > > The USB supply is not yet supported in this patchset because it's not > present on Pine series boards. > > In order to enable battery monitoring the ADC for battery is also enabled > for AXs. > > In order to enable battery monitoring the ADC for battery is also enabled > for AXP803. I'll go with the obvious question... Why an RFC rather than a standard patch submission? I'm not immediately seeing what is controversial! Jonathan > > Icenowy Zheng (7): > dt-bindings: add compatibles for AXP803 Battery/USB power supplies > iio: adc: axp20x-adc: allow to skip ADC rate setup now > iio: adc: axp20x-adc: add support for AXP803 > power: supply: axp20x-battery: support AXP803 > mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery > arm64: allwinner: a64: add power supply nodes in AXP803 DTSI > arm64: allwinner: a64: enable AC and Battery for Pine64 > > .../bindings/power/supply/axp20x_battery.txt | 1 + > .../bindings/power/supply/axp20x_usb_power.txt | 1 + > arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ > .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ > drivers/iio/adc/axp20x_adc.c | 114 ++++++++++++++++++++- > drivers/mfd/axp20x.c | 11 ++ > drivers/power/supply/axp20x_battery.c | 88 ++++++++++++++-- > 7 files changed, 226 insertions(+), 12 deletions(-) >