From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Dinh Nguyen <dinguyen@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH v2] dt-bindings: nand: denali: reduce the register space in the example
Date: Fri, 22 Sep 2017 12:06:32 +0200 [thread overview]
Message-ID: <20170922120632.74bbdd64@bbrezillon> (raw)
In-Reply-To: <1506059903-15552-1-git-send-email-yamada.masahiro@socionext.com>
On Fri, 22 Sep 2017 14:58:23 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> This example allocates much more than needed for address regions.
>
> As for "denali_reg", as you see in drivers/mtd/nand/denali.h, all
> registers fit in 0x1000.
>
> As for "nand_data", this IP is generally configured to use Indexed
> Addressing mode, where there are only two registers in the address
> translation module (CTRL: 0x00, DATA: 0x10). Altera SOCFPGA is
> also this case. So, 0x20 is enough.
>
Applied.
Thanks,
Boris
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>
> Changes in v2:
> - Add a little more explanation for rationale of this patch
>
> Documentation/devicetree/bindings/mtd/denali-nand.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/denali-nand.txt b/Documentation/devicetree/bindings/mtd/denali-nand.txt
> index 504291d..0ee8edb 100644
> --- a/Documentation/devicetree/bindings/mtd/denali-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/denali-nand.txt
> @@ -29,7 +29,7 @@ nand: nand@ff900000 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "altr,socfpga-denali-nand";
> - reg = <0xff900000 0x100000>, <0xffb80000 0x10000>;
> + reg = <0xff900000 0x20>, <0xffb80000 0x1000>;
> reg-names = "nand_data", "denali_reg";
> interrupts = <0 144 4>;
> };
prev parent reply other threads:[~2017-09-22 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 5:58 [PATCH v2] dt-bindings: nand: denali: reduce the register space in the example Masahiro Yamada
2017-09-22 10:06 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922120632.74bbdd64@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=o.rempel@pengutronix.de \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).