From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se, maxime.ripard@free-electrons.com,
robh@kernel.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
pavel@ucw.cz, sre@kernel.org
Subject: [PATCH v14 03/28] v4l: async: Use more intuitive names for internal functions
Date: Tue, 26 Sep 2017 01:25:14 +0300 [thread overview]
Message-ID: <20170925222540.371-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170925222540.371-1-sakari.ailus@linux.intel.com>
Rename internal functions to make the names of the functions better
describe what they do.
Old name New name
v4l2_async_test_notify v4l2_async_match_notify
v4l2_async_belongs v4l2_async_find_match
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/v4l2-core/v4l2-async.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index 60a1a50b9537..60ac2f4fc69e 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -60,8 +60,8 @@ static LIST_HEAD(subdev_list);
static LIST_HEAD(notifier_list);
static DEFINE_MUTEX(list_lock);
-static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *notifier,
- struct v4l2_subdev *sd)
+static struct v4l2_async_subdev *v4l2_async_find_match(
+ struct v4l2_async_notifier *notifier, struct v4l2_subdev *sd)
{
bool (*match)(struct v4l2_subdev *, struct v4l2_async_subdev *);
struct v4l2_async_subdev *asd;
@@ -95,9 +95,9 @@ static struct v4l2_async_subdev *v4l2_async_belongs(struct v4l2_async_notifier *
return NULL;
}
-static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
- struct v4l2_subdev *sd,
- struct v4l2_async_subdev *asd)
+static int v4l2_async_match_notify(struct v4l2_async_notifier *notifier,
+ struct v4l2_subdev *sd,
+ struct v4l2_async_subdev *asd)
{
int ret;
@@ -175,11 +175,11 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) {
int ret;
- asd = v4l2_async_belongs(notifier, sd);
+ asd = v4l2_async_find_match(notifier, sd);
if (!asd)
continue;
- ret = v4l2_async_test_notify(notifier, sd, asd);
+ ret = v4l2_async_match_notify(notifier, sd, asd);
if (ret < 0) {
mutex_unlock(&list_lock);
return ret;
@@ -238,9 +238,10 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd)
INIT_LIST_HEAD(&sd->async_list);
list_for_each_entry(notifier, ¬ifier_list, list) {
- struct v4l2_async_subdev *asd = v4l2_async_belongs(notifier, sd);
+ struct v4l2_async_subdev *asd = v4l2_async_find_match(notifier,
+ sd);
if (asd) {
- int ret = v4l2_async_test_notify(notifier, sd, asd);
+ int ret = v4l2_async_match_notify(notifier, sd, asd);
mutex_unlock(&list_lock);
return ret;
}
--
2.11.0
next prev parent reply other threads:[~2017-09-25 22:25 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 22:25 [PATCH v14 00/28] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 02/28] v4l: async: Remove re-probing support Sakari Ailus
2017-09-25 22:25 ` Sakari Ailus [this message]
2017-09-25 22:25 ` [PATCH v14 04/28] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 05/28] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
[not found] ` <20170925222540.371-6-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:06 ` Hans Verkuil
2017-09-26 8:11 ` Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 06/28] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 14/28] v4l: async: Prepare for async sub-device notifiers Sakari Ailus
[not found] ` <20170925222540.371-15-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:12 ` Hans Verkuil
[not found] ` <ba80e242-a3c2-39af-01cd-6aa54649fb93-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-26 8:17 ` Sakari Ailus
2017-09-26 8:20 ` Hans Verkuil
2017-09-25 22:25 ` [PATCH v14 15/28] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
2017-09-26 8:16 ` Hans Verkuil
[not found] ` <20170925222540.371-16-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:20 ` Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 17/28] dt: bindings: Add a binding for flash LED devices associated to a sensor Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 19/28] v4l: fwnode: Add a helper function for parsing generic references Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references Sakari Ailus
[not found] ` <20170925222540.371-21-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:47 ` Hans Verkuil
[not found] ` <fbd2f71d-aa6d-08ef-1723-132864bde27b-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-26 11:30 ` Sakari Ailus
[not found] ` <20170926113029.eh5i4sp6we6lvgow-z7MJbOB4PBP+e+fPlCVrcFDQ4js95KgL@public.gmane.org>
2017-10-09 12:06 ` Hans Verkuil
2017-10-10 11:27 ` Sakari Ailus
2017-10-10 13:07 ` Hans Verkuil
[not found] ` <d8a48273-7a19-0f83-4a4d-8058b7a59e0e-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-10-16 13:02 ` Sakari Ailus
2017-10-17 12:42 ` Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 21/28] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 22/28] v4l: fwnode: Add a convenience function for registering sensors Sakari Ailus
2017-09-26 8:26 ` Hans Verkuil
[not found] ` <ac50fc71-c528-a703-04bb-6abc1fc7c19a-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-26 8:29 ` Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 23/28] dt: bindings: smiapp: Document lens-focus and flash-leds properties Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 25/28] et8ek8: Add support for flash and lens devices Sakari Ailus
2017-09-26 8:27 ` Hans Verkuil
[not found] ` <20170925222540.371-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-25 22:25 ` [PATCH v14 01/28] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 07/28] rcar-vin: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-30 13:17 ` Niklas Söderlund
[not found] ` <20170930131709.GP17182-ofJ5d6taAgIKcZgyrm77+z0dHWC0CY5B@public.gmane.org>
2017-10-02 11:58 ` Sakari Ailus
[not found] ` <3f940721-f190-4662-cfda-d99a0d97bf08-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-02 12:14 ` Niklas Söderlund
[not found] ` <20171002121422.GQ17182-ofJ5d6taAgIKcZgyrm77+z0dHWC0CY5B@public.gmane.org>
2017-10-02 12:24 ` Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 08/28] omap3isp: Fix check for our own sub-devices Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 09/28] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 10/28] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 11/28] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 12/28] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 13/28] v4l: async: Allow async notifier register call succeed with no subdevs Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 16/28] v4l: async: Ensure only unique fwnodes are registered to notifiers Sakari Ailus
2017-09-26 8:22 ` Hans Verkuil
2017-09-25 22:25 ` [PATCH v14 18/28] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 22/28] v4l: async: Add a convenience function for registering sensors Sakari Ailus
[not found] ` <20170925222540.371-23-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:24 ` Hans Verkuil
2017-09-25 22:25 ` [PATCH v14 24/28] smiapp: Add support for flash and lens devices Sakari Ailus
[not found] ` <20170925222540.371-26-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:26 ` Hans Verkuil
2017-09-25 22:25 ` [PATCH v14 26/28] ov5670: " Sakari Ailus
2017-09-26 8:27 ` Hans Verkuil
2017-09-25 22:25 ` [PATCH v14 28/28] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
2017-09-25 22:25 ` [PATCH v14 27/28] ov13858: Add support for flash and lens devices Sakari Ailus
[not found] ` <20170925222540.371-29-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-26 8:27 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925222540.371-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).