From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 13/14] arm64: allwinner: a64: fix pin name
Date: Tue, 26 Sep 2017 09:53:52 +0200 [thread overview]
Message-ID: <20170926075352.GA20634@Red> (raw)
In-Reply-To: <CAGb2v67R1k_RxK4n+eGNyzqD44efSwTKZ028=5AiiBbVqBeEjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Sep 26, 2017 at 03:46:13PM +0800, Chen-Yu Tsai wrote:
> On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
> <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > All pinmux nodes should have the suffix "_pins" or "_pin".
> >
> > In the case where there are multiple choices, the node name should convey
> > what or which pingroup the choice is.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 +++---
> > 7 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> > index 45bdbfb96126..36a56e3ab92f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> > @@ -248,7 +248,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> > index 2beef9e6cb88..15019edb7dd6 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> > @@ -198,7 +198,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > index 338e786155b1..ec62c86cc236 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -194,6 +194,6 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> > index 5f8ff4017d45..1c8b9d2721f0 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> > @@ -85,7 +85,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > index 806442d3e846..69743ff171d0 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > @@ -232,7 +232,7 @@
> > /* On Exp and Euler connectors */
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > index 0eb2acedf8c3..e41eb71eb438 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > @@ -135,7 +135,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index b02a8476b0c8..2d2937b7dc68 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -347,7 +347,7 @@
> > function = "spi1";
> > };
> >
> > - uart0_pins_a: uart0 {
> > + uart0_pb_pins: uart0 {
>
> You are again confusing node names with node labels.
> And it doesn't match what your commit message says.
>
> The node name is what never changes even when the device
> tree is compiled into a binary blob. The label gets compiled
> out, and any references to it are converted to an integer
> index, much like how a goto label in C gets compiled.
>
> Of the two, the node name is what I asked to be changed.
> Please take a look at arch/arm/boot/dts/sun8i-a83t.dtsi
> for a proper example of what I am asking for. Note that
> node names should use hyphens, not underscores, while
> labels should use underscores. For the pinmux nodes
> the name and label would likely be the same except for
> this exception. So your uart0 label changes are good.
> Please keep them.
>
Sorry, I misunderstood your query.
I will fix that.
Regards
Corentin Labbe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-26 7:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 7:22 [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 01/14] ARM: dts: sunxi: h3/h5: Fix simple-bus unit address format error Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 02/14] ARM: dts: sunxi: h3/h5: Fix i2c2 register address Corentin Labbe
2018-08-01 13:11 ` Icenowy Zheng
2017-09-26 7:22 ` [PATCH v3 03/14] ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 04/14] ARM: dts: nanopi: " Corentin Labbe
[not found] ` <20170926072234.27481-1-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26 7:22 ` [PATCH v3 05/14] ARM: dts: orangepi2: " Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 12/14] ARM: dts: sun8i: a83t: Fix simple-bus unit address format error Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 13/14] arm64: allwinner: a64: fix pin name Corentin Labbe
[not found] ` <20170926072234.27481-14-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26 7:46 ` Chen-Yu Tsai
[not found] ` <CAGb2v67R1k_RxK4n+eGNyzqD44efSwTKZ028=5AiiBbVqBeEjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-26 7:53 ` Corentin Labbe [this message]
2017-09-26 7:48 ` [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings Chen-Yu Tsai
[not found] ` <CAGb2v64AK-xifjcowUk1mp4TRwHFPOqjZR58Bd5w7Bei52T06g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-26 8:58 ` Maxime Ripard
2017-09-26 13:01 ` Chen-Yu Tsai
2017-09-27 15:18 ` Chen-Yu Tsai
2017-09-26 7:22 ` [PATCH v3 06/14] ARM: dts: sun8i: orangepi-lite: Fix node with unit name and no reg property Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 07/14] ARM: dts: sun8i: orangepi one: " Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 08/14] ARM: dts: sun8i: orangepipc: " Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 09/14] ARM: dts: sun8i: orangepi-plus: " Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 10/14] arm64: allwinner: a64: Fix simple-bus unit address format error Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 11/14] arm64: allwinner: a64: Fix node with unit name and no reg property Corentin Labbe
2017-09-26 7:22 ` [PATCH v3 14/14] ARM: dts: sun8i: fix pin name Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926075352.GA20634@Red \
--to=clabbe.montjoie-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).